From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 31n3IE1ybGAUUAAAWB0awg (envelope-from ) for ; Tue, 06 Apr 2021 10:38:05 -0400 Received: by simark.ca (Postfix, from userid 112) id 784531E939; Tue, 6 Apr 2021 10:38:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 798221E590 for ; Tue, 6 Apr 2021 10:38:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB772384407D; Tue, 6 Apr 2021 14:38:03 +0000 (GMT) Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by sourceware.org (Postfix) with ESMTPS id 33A8A384407D for ; Tue, 6 Apr 2021 14:38:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 33A8A384407D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kichwacoders.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=jonah@kichwacoders.com Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 1FD9AB05EA for ; Tue, 6 Apr 2021 10:38:00 -0400 (EDT) (envelope-from jonah@kichwacoders.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=sasl; bh=fEm9cNhwxtYj4TaiaLXjRzcCfMc=; b=rtyNVl hmKJHV2LJiHsUXdTdirlB4IcqQE5q1uuUj6NQq8s2NN+k5V0u4s0lJLoFKhsbpp0 +8mwlljYWP+29w/0DD49gSy29nPtgZrsh1MlezCzIWQV0F7AWnvG2Q2AGFYKdPsT pNh0D7fkbIvRkvcETLPswhM44HP06Dr8dJivA= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 16077B05E9 for ; Tue, 6 Apr 2021 10:38:00 -0400 (EDT) (envelope-from jonah@kichwacoders.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kichwacoders.com; h=mime-version:references:in-reply-to:from:date:message-id:subject:to:cc:content-type; s=mesmtp; bh=Sok7phKuW97+i0CbBwV2MQHhiJsKIlU27FL3hRNEmVI=; b=LZwgTGlM6m8SQQXOElXAneHA46bVqNC4Q/GdsdYvul034u5q2pd8YxJC6gyvh/lhGD2SUsCLLx+PwmF7z+mVfKYu6zE8AzXZI4NT+jdNom6okuyIiR+dKBrVOj0bpClLAtOM2fxAiISF7n+YaV2Vu4JDYRN59LeIEYnuLwJCr5s= Received: from mail-wm1-f49.google.com (unknown [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 7720AB05E8 for ; Tue, 6 Apr 2021 10:37:59 -0400 (EDT) (envelope-from jonah@kichwacoders.com) Received: by mail-wm1-f49.google.com with SMTP id y20-20020a1c4b140000b029011f294095d3so2353386wma.3 for ; Tue, 06 Apr 2021 07:37:59 -0700 (PDT) X-Gm-Message-State: AOAM531nq8Rn1oVhy+cH2Xzluqj37SfOU4NEN0owcDtjSl2Se+FqHOEe jImVNsyN/uMFj7jnQPdGTtf7Ij48fXtCIxYwYBQ= X-Google-Smtp-Source: ABdhPJwcXxVmJxYlWS0xqINGv3RegaBnbO6/ypkq4hQ1sKEZcutAmRHcuTtQwU2C8IFlXPY++fQCcoeC/i6wF0XMZWo= X-Received: by 2002:a1c:bdc4:: with SMTP id n187mr4515261wmf.68.1617719878573; Tue, 06 Apr 2021 07:37:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonah Graham Date: Tue, 6 Apr 2021 10:37:22 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] Breakpoint conditions at locations with differing contexts To: "Aktemur, Tankut Baris" X-Pobox-Relay-ID: AF24E8A2-96E5-11EB-8123-74DE23BA3BAF-18936988!pb-smtp2.pobox.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Tue, 6 Apr 2021 at 10:11, Aktemur, Tankut Baris < tankut.baris.aktemur@intel.com> wrote: > Hi Jonah, > Hi Baris, > > Thanks for the feedback and reporting this issue. > Thanks for implementing it :-) > I'll submit a patch to fix it. > Great. AFAICT -break-insert with a condition included always acts as if -force-condition was included. i.e. "break method -force-condition if symbol" is equivalent to "26-break-insert -c symbol -f method" > > "N*" is the third possible value and it means "disabled because the > condition is invalid at the location". I'll also submit a patch to > update the doc. > Great. > > > Can the warning string be part of the breakpoint structure returned in > MI? > > Are you referring to the "warning: failed to validate condition > at location 1, disabling:" string? I'm not sure it should be a part > of the breakpoint structure. Wouldn't the 'N*' value suffice to give > the necessary information? > It is sufficient. I assume therefore that "N*" in a reply to break-insert always means "warning: failed to validate condition at location 1, disabling:" (What does the "1" refer to? IIUC it is the ".1" in the breakpoint number?). In the breakpoint table N* always means "Breakpoint condition is invalid at this location" and that the breakpoint is disabled? > > > > 2. The other problem is I want to enable the -force-condition in the UI, > but AFAICT that isn't supported from MI? If it is, I couldn't figure out > the invocation that worked. > > This flag does not exist. I'll submit a patch to recognize it in > the MI command. > Great. > > > > > Any guidance you can provide is most welcome. > > > > Thanks, > > Jonah > > Thanks. > -Baris > Thanks again, Jonah > >