On Thu, Sep 1, 2011 at 1:08 PM, Kevin Pouget wrote: > On Thu, Sep 1, 2011 at 12:07 PM, Eli Zaretskii wrote: >>> From: Kevin Pouget >>> Date: Thu, 1 Sep 2011 10:44:39 +0200 >>> Cc: Tom Tromey , gdb-patches@sourceware.org >>> >>> On Wed, Aug 31, 2011 at 7:56 PM, Eli Zaretskii wrote: >>> >> From: Tom Tromey >>> >> Cc: Kevin Pouget , gdb-patches@sourceware.org >>> >> Date: Wed, 31 Aug 2011 11:53:21 -0600 >>> >> >>> >> >>>>> "Eli" == Eli Zaretskii writes: >>> >> >>> >> Eli> I'd still like to hear from someone "in the know" how is it possible >>> >> Eli> that the exit code won't be available, but let's not block the commit >>> >> Eli> on that behalf. >>> >> >>> >> It can happen at least on detach. >>> > >>> > Right, thanks.  Perhaps we should mention that in parentheses. >>> > >>> >>> do you want it to appear in my patch, something like >>> >>> > Optional, will exist only in the case that the inferior exited with some status---i.e., not detached) >>> >>> along with >>> >>> >> +An integer representing the exit code which the inferior has returned. >>> > I think we would be better off without that "has" word. >>> >>> ? >> >> No, I meant something like >> >>  An integer representing the exit code, if available, which the >>  inferior has returned.  (The exit code could be unavailable if, for >>  example, @value{GDBN} detaches from the inferior.) >> > > right, I've updated the patch, is it fine for you ? > > > thanks, > > Kevin > > 2011-09-20  Kevin Pouget   > >        PR python/12691: Add the inferior to Python exited event >        * python/py-exitedevent.c (create_exited_event_object): Add inferior >        to exited_event. >        * python/py-event.h (emit_exited_event): Likewise >        * python/-inferior.c (python_inferior_exit): Likewise > >  2011-09-01  Kevin Pouget   > >        PR python/12691: Add the inferior to Python exited event >        * gdb.python/py-events.exp: Test the inferior attribute of exited >        event with a fork. >        * gdb.python/py-events.py: Print inferior number on exit. >        * gdb.python/py-events.c: Fork the inferior. > >  2011-09-01  Kevin Pouget   > >        PR python/12691: Add the inferior to Python exited event >        * gdb.texinfo (Events In Python): Describe exited inferior attribute. > ping Eli, could you confirm that you agree with the last version of the documentation? Thanks, Kevin