On Wed, Aug 31, 2011 at 7:49 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Kevin" == Kevin Pouget <kevin.pouget@gmail.com> writes:
>
> Kevin> 2011-04-30  Kevin Pouget  <kevin.pouget@st.com>
> Kevin>  Handle multiple breakpoint hits in Python interface:
> Kevin>  * gdb.texinfo (Events In Python): New function documentation:
> Kevin>  gdb.BreakpointEvent.breakpoints. Indicate that
> Kevin>  gdb.BreakpointEvent.breakpoint is now deprecated.
> [...]
>
> Kevin> +          if (PyList_Append (list, (PyObject *) current_bs->breakpoint_at->py_bp_object))
>
> I suggest introducing a PyObject* variable whose value is the second
> argument here.  Then you don't need to reformat this line or the
> subsequent assignment to first_bp:
>
> Kevin> +            first_bp = (PyObject *) current_bs->breakpoint_at->py_bp_object;

done

> Kevin> +  Py_XDECREF(list);
>
> Missing space before "(".

done

> Could you please write NEWS patches for your change to the Python API?

I added this line:
>  ** The "gdb.breakpoint" function has been deprecated and in favor of  "gdb.breakpoints".

> Otherwise seems reasonable.

Thanks,

I attached a patch with these modifications


Cordially,

Kevin