Re: [RFC] Python Finish Breakpoints

Tom Tromey
2011-12-21T17:11:57Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> Great! I'll fix this last bits and commit it in the next few days
>> Is it okay for 7.4 branch as well ?

Joel> Tom asked me on IRC whether it would be OK for 7.4 as well, with
Joel> some doubts on his side. With the time difference, I wasn't there
Joel> anymore, so I thought I'd answer here. As always, if a Global
Joel> Maintainer (such as Tom) is confident about a given patch, that's
Joel> always good enough for me to put it in.

Joel> I'm not sure whether Tom was asking me to look at the patch and
Joel> make an evaluation myself. I skimmed the patch, and at first sight,
Joel> it seems big, and slightly intrusive (in the sense that it touches
Joel> several files, many of them critical to all platforms). My initial
Joel> impression, which would need a more careful read of your patch
Joel> to be confirmed, is that it might be a little risky to do so.

Joel> Tom: Just let me know if you'd like me to look at the patch more
Joel> in detail.

I was thinking about it last night, and I think it is ok to go in.

I think the changes outside of Python are pretty easily verified as
being safe.

As for the Python changes, if something is wrong in the implementation
of the new code -- well, it is a new feature, I think it won't break
anything existing.

So, I think it is ok for 7.4.

Tom