Re: [PATCH] Add bp_location to Python interface

Eli Zaretskii
2012-01-11T10:16:43Z

> From: Kevin Pouget <kevin.pouget@gmail.com>
> Date: Wed, 11 Jan 2012 10:47:55 +0100
> Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com
>
> >> +Return a tuple containing a sequence of @code{gdb.BpLocation} objects
> >> +(see below) associated with this breakpoint. Â A breakpoint with no location
> >> +is a pending breakpoint (@xref{Set Breaks, , pending breakpoints}).
> > Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â ^^^^^
> > Still an @xref...
>
> sorry, I missed it in the first run ...

See below, it sounds like I totally failed to explain myself in this
matter.

> +@defun gdb.locations ()
> +Return a tuple containing a sequence of @code{gdb.BpLocation} objects
> +(see below) associated with this breakpoint. A breakpoint with no location
> +is a pending breakpoint (@xref{Set Breaks, , pending breakpoints}).

This @xref should become @pxref, because the cross reference is in
parentheses (that's the `p' part of `pxref') and is not a complete
sentence.

The other @xref that you changed to @pxref should be left alone.

> -become invisible to the user. @xref{Breakpoints In Python}, for further
> +become invisible to the user. @pxref{Breakpoints In Python}, for further
> details about this argument.

This should be @xref, as it is not in parentheses and is a complete
sentence.

Thanks, and sorry for my evidently unclear wording.