From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21256 invoked by alias); 13 Oct 2011 11:27:05 -0000 Received: (qmail 21248 invoked by uid 22791); 13 Oct 2011 11:27:04 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Oct 2011 11:26:49 +0000 Received: by vcbfk1 with SMTP id fk1so884730vcb.0 for ; Thu, 13 Oct 2011 04:26:49 -0700 (PDT) Received: by 10.52.72.196 with SMTP id f4mr3328655vdv.68.1318505209070; Thu, 13 Oct 2011 04:26:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.180.75 with HTTP; Thu, 13 Oct 2011 04:26:29 -0700 (PDT) In-Reply-To: References: <201110121659.13715.pedro@codesourcery.com> From: Kevin Pouget Date: Thu, 13 Oct 2011 11:27:00 -0000 Message-ID: Subject: Re: [RFC][Python] gdbpy_frame_stop_reason_string bug To: Tom Tromey , Pedro Alves Cc: pmuldoon@redhat.com, gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=bcaec50160ef9f05b804af2c6aec X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00385.txt.bz2 --bcaec50160ef9f05b804af2c6aec Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1217 On Thu, Oct 13, 2011 at 1:24 PM, Kevin Pouget wrot= e: > On Wed, Oct 12, 2011 at 7:06 PM, Tom Tromey wrote: >>>>>>> "Pedro" =3D=3D Pedro Alves writes: >> >> Pedro> We should definitely reimplement these enums in a table in a >> Pedro> .def file. =A0That's 2 places already that map the enums to >> Pedro> something else. =A0This one is missing UNWIND_UNAVAILABLE. >> >> Makes sense to me. >> >> Pedro> And what do you think of making UNWIND_FIRST_ERROR >> Pedro> an alias like in my patch? =A0Do you think that's likely >> Pedro> to break anything? >> >> I think it would be fine. > > > Hello, > > here is a patch which implements the enums in a .def file, as > suggested earlier. Please let me know what you think about it (tested > with no regression on X86_64) > > UNWIND_FIRST_ERROR is now an "enum alias", instead of being defined by > the preprocessor (the only way I managed to implement it), as well as > UNWIND_FIRST and UNWIND_LAST, used for bound-checking in py-frame.c > > I also moved the original enum comments to the .def file with no modifica= tion > > > Thanks, > > Kevin (with the file attached this time, sorry for the repost) --bcaec50160ef9f05b804af2c6aec Content-Type: text/x-patch; charset=US-ASCII; name="unwind_stop_reasons.def.patch" Content-Disposition: attachment; filename="unwind_stop_reasons.def.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gtpnx0z30 Content-length: 6930 ZGlmZiAtLWdpdCBhL2dkYi9mcmFtZS5jIGIvZ2RiL2ZyYW1lLmMKaW5kZXgg NTgyNDAyMC4uNzBjMzcyZiAxMDA2NDQKLS0tIGEvZ2RiL2ZyYW1lLmMKKysr IGIvZ2RiL2ZyYW1lLmMKQEAgLTIzNTEsMjMgKzIzNTEsMTEgQEAgZnJhbWVf c3RvcF9yZWFzb25fc3RyaW5nIChlbnVtIHVud2luZF9zdG9wX3JlYXNvbiBy ZWFzb24pCiB7CiAgIHN3aXRjaCAocmVhc29uKQogICAgIHsKLSAgICBjYXNl IFVOV0lORF9OVUxMX0lEOgotICAgICAgcmV0dXJuIF8oInVud2luZGVyIGRp ZCBub3QgcmVwb3J0IGZyYW1lIElEIik7CisjZGVmaW5lIFNFVChuYW1lLCBk ZXNjcmlwdGlvbikgXAorICAgIGNhc2UgbmFtZTogcmV0dXJuIF8oZGVzY3Jp cHRpb24pOworI2luY2x1ZGUgImdkYi91bndpbmRfc3RvcF9yZWFzb25zLmRl ZiIKKyN1bmRlZiBTRVQKIAotICAgIGNhc2UgVU5XSU5EX1VOQVZBSUxBQkxF OgotICAgICAgcmV0dXJuIF8oIk5vdCBlbm91Z2ggcmVnaXN0ZXJzIG9yIG1l bW9yeSBhdmFpbGFibGUgdG8gdW53aW5kIGZ1cnRoZXIiKTsKLQotICAgIGNh c2UgVU5XSU5EX0lOTkVSX0lEOgotICAgICAgcmV0dXJuIF8oInByZXZpb3Vz IGZyYW1lIGlubmVyIHRvIHRoaXMgZnJhbWUgKGNvcnJ1cHQgc3RhY2s/KSIp OwotCi0gICAgY2FzZSBVTldJTkRfU0FNRV9JRDoKLSAgICAgIHJldHVybiBf KCJwcmV2aW91cyBmcmFtZSBpZGVudGljYWwgdG8gdGhpcyBmcmFtZSAoY29y cnVwdCBzdGFjaz8pIik7Ci0KLSAgICBjYXNlIFVOV0lORF9OT19TQVZFRF9Q QzoKLSAgICAgIHJldHVybiBfKCJmcmFtZSBkaWQgbm90IHNhdmUgdGhlIFBD Iik7Ci0KLSAgICBjYXNlIFVOV0lORF9OT19SRUFTT046Ci0gICAgY2FzZSBV TldJTkRfRklSU1RfRVJST1I6CiAgICAgZGVmYXVsdDoKICAgICAgIGludGVy bmFsX2Vycm9yIChfX0ZJTEVfXywgX19MSU5FX18sCiAJCSAgICAgICJJbnZh bGlkIGZyYW1lIHN0b3AgcmVhc29uIik7CmRpZmYgLS1naXQgYS9nZGIvZnJh bWUuaCBiL2dkYi9mcmFtZS5oCmluZGV4IGY1ODY2YmQuLjMxNzcxNGMgMTAw NjQ0Ci0tLSBhL2dkYi9mcmFtZS5oCisrKyBiL2dkYi9mcmFtZS5oCkBAIC00 NDYsNDcgKzQ0NiwxNiBAQCBleHRlcm4gc3RydWN0IGFkZHJlc3Nfc3BhY2Ug KmdldF9mcmFtZV9hZGRyZXNzX3NwYWNlIChzdHJ1Y3QgZnJhbWVfaW5mbyAq KTsKIAogZW51bSB1bndpbmRfc3RvcF9yZWFzb24KICAgewotICAgIC8qIE5v IHBhcnRpY3VsYXIgcmVhc29uOyBlaXRoZXIgd2UgaGF2ZW4ndCB0cmllZCB1 bndpbmRpbmcgeWV0LAotICAgICAgIG9yIHdlIGRpZG4ndCBmYWlsLiAgKi8K LSAgICBVTldJTkRfTk9fUkVBU09OLAotCi0gICAgLyogVGhlIHByZXZpb3Vz IGZyYW1lJ3MgYW5hbHl6ZXIgcmV0dXJucyBhbiBpbnZhbGlkIHJlc3VsdAot ICAgICAgIGZyb20gdGhpc19pZC4KLQotICAgICAgIEZJWE1FIGRyb3cvMjAw Ni0wOC0xNjogVGhpcyBpcyBob3cgR0RCIHVzZWQgdG8gaW5kaWNhdGUgZW5k IG9mCi0gICAgICAgc3RhY2suICBXZSBzaG91bGQgbWlncmF0ZSB0byBhIG1v ZGVsIHdoZXJlIGZyYW1lcyBhbHdheXMgaGF2ZSBhCi0gICAgICAgdmFsaWQg SUQsIGFuZCB0aGlzIGJlY29tZXMgbm90IGp1c3QgYW4gZXJyb3IgYnV0IGFu IGludGVybmFsCi0gICAgICAgZXJyb3IuICBCdXQgdGhhdCdzIGEgcHJvamVj dCBmb3IgYW5vdGhlciBkYXkuICAqLwotICAgIFVOV0lORF9OVUxMX0lELAot Ci0gICAgLyogVGhpcyBmcmFtZSBpcyB0aGUgb3V0ZXJtb3N0LiAgKi8KLSAg ICBVTldJTkRfT1VURVJNT1NULAotCi0gICAgLyogQWxsIHRoZSBjb25kaXRp b25zIGFmdGVyIHRoaXMgcG9pbnQgYXJlIGNvbnNpZGVyZWQgZXJyb3JzOwot ICAgICAgIGFibm9ybWFsIHN0YWNrIHRlcm1pbmF0aW9uLiAgSWYgYSBiYWNr dHJhY2Ugc3RvcHMgZm9yIG9uZQotICAgICAgIG9mIHRoZXNlIHJlYXNvbnMs IHdlJ2xsIGxldCB0aGUgdXNlciBrbm93LiAgVGhpcyBtYXJrZXIKLSAgICAg ICBpcyBub3QgYSB2YWxpZCBzdG9wIHJlYXNvbi4gICovCi0gICAgVU5XSU5E X0ZJUlNUX0VSUk9SLAotCi0gICAgLyogQ2FuJ3QgdW53aW5kIGZ1cnRoZXIs IGJlY2F1c2UgdGhhdCB3b3VsZCByZXF1aXJlIGtub3dpbmcgdGhlCi0gICAg ICAgdmFsdWVzIG9mIHJlZ2lzdGVycyBvciBtZW1vcnkgdGhhdCBoYXZlbid0 IGJlZW4gY29sbGVjdGVkLiAgKi8KLSAgICBVTldJTkRfVU5BVkFJTEFCTEUs Ci0KLSAgICAvKiBUaGlzIGZyYW1lIElEIGxvb2tzIGxpa2UgaXQgb3VnaHQg dG8gYmVsb25nIHRvIGEgTkVYVCBmcmFtZSwKLSAgICAgICBidXQgd2UgZ290 IGl0IGZvciBhIFBSRVYgZnJhbWUuICBOb3JtYWxseSwgdGhpcyBpcyBhIHNp Z24gb2YKLSAgICAgICB1bndpbmRlciBmYWlsdXJlLiAgSXQgY291bGQgYWxz byBpbmRpY2F0ZSBzdGFjayBjb3JydXB0aW9uLiAgKi8KLSAgICBVTldJTkRf SU5ORVJfSUQsCi0KLSAgICAvKiBUaGlzIGZyYW1lIGhhcyB0aGUgc2FtZSBJ RCBhcyB0aGUgcHJldmlvdXMgb25lLiAgVGhhdCBtZWFucwotICAgICAgIHRo YXQgdW53aW5kaW5nIGZ1cnRoZXIgd291bGQgYWxtb3N0IGNlcnRhaW5seSBn aXZlIHVzIGFub3RoZXIKLSAgICAgICBmcmFtZSB3aXRoIGV4YWN0bHkgdGhl IHNhbWUgSUQsIHNvIGJyZWFrIHRoZSBjaGFpbi4gIE5vcm1hbGx5LAotICAg ICAgIHRoaXMgaXMgYSBzaWduIG9mIHVud2luZGVyIGZhaWx1cmUuICBJdCBj b3VsZCBhbHNvIGluZGljYXRlCi0gICAgICAgc3RhY2sgY29ycnVwdGlvbi4g ICovCi0gICAgVU5XSU5EX1NBTUVfSUQsCi0KLSAgICAvKiBUaGUgZnJhbWUg dW53aW5kZXIgZGlkbid0IGZpbmQgYW55IHNhdmVkIFBDLCBidXQgd2UgbmVl ZGVkCi0gICAgICAgb25lIHRvIHVud2luZCBmdXJ0aGVyLiAgKi8KLSAgICBV TldJTkRfTk9fU0FWRURfUEMsCisjZGVmaW5lIFNFVChuYW1lLCBkZXNjcmlw dGlvbikgbmFtZSwKKyNkZWZpbmUgRklSU1RfRU5UUlkobmFtZSkgVU5XSU5E X0ZJUlNUID0gbmFtZSwKKyNkZWZpbmUgTEFTVF9FTlRSWShuYW1lKSBVTldJ TkRfTEFTVCA9IG5hbWUsCisjZGVmaW5lIEZJUlNUX0VSUk9SKG5hbWUpIFVO V0lORF9GSVJTVF9FUlJPUiA9IG5hbWUsCisKKyNpbmNsdWRlICJnZGIvdW53 aW5kX3N0b3BfcmVhc29ucy5kZWYiCisjdW5kZWYgU0VUCisjdW5kZWYgRklS U1RfRU5UUlkKKyN1bmRlZiBMQVNUX0VOVFJZCisjdW5kZWYgRklSU1RfRVJS T1IKICAgfTsKIAogLyogUmV0dXJuIHRoZSByZWFzb24gd2h5IHdlIGNhbid0 IHVud2luZCBwYXN0IHRoaXMgZnJhbWUuICAqLwpkaWZmIC0tZ2l0IGEvZ2Ri L3B5dGhvbi9weS1mcmFtZS5jIGIvZ2RiL3B5dGhvbi9weS1mcmFtZS5jCmlu ZGV4IDc1YWE0NGUuLjY0Mzg4ZGQgMTAwNjQ0Ci0tLSBhL2dkYi9weXRob24v cHktZnJhbWUuYworKysgYi9nZGIvcHl0aG9uL3B5LWZyYW1lLmMKQEAgLTU0 Miw3ICs1NDIsNyBAQCBnZGJweV9mcmFtZV9zdG9wX3JlYXNvbl9zdHJpbmcg KFB5T2JqZWN0ICpzZWxmLCBQeU9iamVjdCAqYXJncykKICAgaWYgKCFQeUFy Z19QYXJzZVR1cGxlIChhcmdzLCAiaSIsICZyZWFzb24pKQogICAgIHJldHVy biBOVUxMOwogCi0gIGlmIChyZWFzb24gPCAwIHx8IHJlYXNvbiA+IFVOV0lO RF9OT19TQVZFRF9QQykKKyAgaWYgKHJlYXNvbiA8IFVOV0lORF9GSVJTVCB8 fCByZWFzb24gPiBVTldJTkRfTEFTVCkKICAgICB7CiAgICAgICBQeUVycl9T ZXRTdHJpbmcgKFB5RXhjX1ZhbHVlRXJyb3IsIAogCQkgICAgICAgXygiSW52 YWxpZCBmcmFtZSBzdG9wIHJlYXNvbi4iKSk7CkBAIC01ODUsNiArNTg1LDgg QEAgZnJhcHlfcmljaGNvbXBhcmUgKFB5T2JqZWN0ICpzZWxmLCBQeU9iamVj dCAqb3RoZXIsIGludCBvcCkKIHZvaWQKIGdkYnB5X2luaXRpYWxpemVfZnJh bWVzICh2b2lkKQogeworICBpbnQgdW53aW5kX2NwdCA9IDA7CisKICAgZnJh bWVfb2JqZWN0X3R5cGUudHBfbmV3ID0gUHlUeXBlX0dlbmVyaWNOZXc7CiAg IGlmIChQeVR5cGVfUmVhZHkgKCZmcmFtZV9vYmplY3RfdHlwZSkgPCAwKQog ICAgIHJldHVybjsKQEAgLTU5OSwxOCArNjAxLDExIEBAIGdkYnB5X2luaXRp YWxpemVfZnJhbWVzICh2b2lkKQogICBQeU1vZHVsZV9BZGRJbnRDb25zdGFu dCAoZ2RiX21vZHVsZSwgIlNJR1RSQU1QX0ZSQU1FIiwgU0lHVFJBTVBfRlJB TUUpOwogICBQeU1vZHVsZV9BZGRJbnRDb25zdGFudCAoZ2RiX21vZHVsZSwg IkFSQ0hfRlJBTUUiLCBBUkNIX0ZSQU1FKTsKICAgUHlNb2R1bGVfQWRkSW50 Q29uc3RhbnQgKGdkYl9tb2R1bGUsICJTRU5USU5FTF9GUkFNRSIsIFNFTlRJ TkVMX0ZSQU1FKTsKLSAgUHlNb2R1bGVfQWRkSW50Q29uc3RhbnQgKGdkYl9t b2R1bGUsCi0JCQkgICAiRlJBTUVfVU5XSU5EX05PX1JFQVNPTiIsIFVOV0lO RF9OT19SRUFTT04pOwotICBQeU1vZHVsZV9BZGRJbnRDb25zdGFudCAoZ2Ri X21vZHVsZSwKLQkJCSAgICJGUkFNRV9VTldJTkRfTlVMTF9JRCIsIFVOV0lO RF9OVUxMX0lEKTsKLSAgUHlNb2R1bGVfQWRkSW50Q29uc3RhbnQgKGdkYl9t b2R1bGUsCi0JCQkgICAiRlJBTUVfVU5XSU5EX0ZJUlNUX0VSUk9SIiwgVU5X SU5EX0ZJUlNUX0VSUk9SKTsKLSAgUHlNb2R1bGVfQWRkSW50Q29uc3RhbnQg KGdkYl9tb2R1bGUsCi0JCQkgICAiRlJBTUVfVU5XSU5EX0lOTkVSX0lEIiwg VU5XSU5EX0lOTkVSX0lEKTsKLSAgUHlNb2R1bGVfQWRkSW50Q29uc3RhbnQg KGdkYl9tb2R1bGUsCi0JCQkgICAiRlJBTUVfVU5XSU5EX1NBTUVfSUQiLCBV TldJTkRfU0FNRV9JRCk7Ci0gIFB5TW9kdWxlX0FkZEludENvbnN0YW50IChn ZGJfbW9kdWxlLAotCQkJICAgIkZSQU1FX1VOV0lORF9OT19TQVZFRF9QQyIs IFVOV0lORF9OT19TQVZFRF9QQyk7CisKKyNkZWZpbmUgU0VUKG5hbWUsIGRl c2NyaXB0aW9uKSBcCisgIFB5TW9kdWxlX0FkZEludENvbnN0YW50IChnZGJf bW9kdWxlLCAiRlJBTUVfIiNuYW1lLCB1bndpbmRfY3B0KyspOworI2luY2x1 ZGUgImdkYi91bndpbmRfc3RvcF9yZWFzb25zLmRlZiIKKyN1bmRlZiBTRVQK IAogICBQeV9JTkNSRUYgKCZmcmFtZV9vYmplY3RfdHlwZSk7CiAgIFB5TW9k dWxlX0FkZE9iamVjdCAoZ2RiX21vZHVsZSwgIkZyYW1lIiwgKFB5T2JqZWN0 ICopICZmcmFtZV9vYmplY3RfdHlwZSk7Cg== --bcaec50160ef9f05b804af2c6aec--