Hello,

I would like to discuss this patch which introduces a new Python class
gdb.BpLocation, mapped from breakpoint.h::struct bp_location.

I noticed that the Python interface doesn't offer so many details
about breakpoint location, just gdb.Breakpoint.location, the string
used to set the breakpoint (its linespec?)

So this new class, which is currently strictly read-only and not
instantiatable, exports the address and inferior in which the
breakpoint was set (and an enabled flag, and a link to its owner
breakpoint).

BpLocation object are available through the gdb.Breakpoint.locations method.

I think that this class would also help Python users to better
control/understand where their breakpoints are set with Tom's recent
changes about ambiguous linespec

+* GDB now handles ambiguous linespecs more consistently; the existing
+  FILE:LINE support has been expanded to other types of linespecs.  A
+  breakpoint will now have locations at all the matching points in all
+  inferiors, and locations will be added or subtracted according to
+  inferior changes.


Please let me know what you think about it,
build and tested with no regression on Fedora/x86_64

cordially,

Kevin


2011-12-08  Kevin Pouget  <kevin.pouget@st.com>
	* Makefile.in (SUBDIR_PYTHON_OBS): Add py-bploc.o
	(SUBDIR_PYTHON_SRCS): Add python/py-bploc.c
	Add build rule for this file.
	* breakpoint.h (struct bploc_object): Forward declaration.
	(struct bp_location): Add py_bploc_obj.
	* breakpoint.c (free_bp_location): Call gdbpy_bplocation_free.
	* python/py-bploc.c: New file.
	* python/py-breakpoint.c (bppy_locations): New function.
	(breakpoint_object_methods): New method binding: locations().
	* python/python-internal.h (bploc_object): New typedef.
	(bplocation_to_bplocation_object): New prototype.
	(gdbpy_initialize_bplocation): Likewise.
	* python/python.c (gdbpy_bplocation_free): New empty stub.
	(_initialize_python): Call gdbpy_initialize_bplocation.
	* python/python.h (gdbpy_bplocation_free): New prototype.
	
doc/
	* gdb.texinfo (Breakpoints In Python): Document
	gdb.Breakpoint.locations and gdb.BpLocation.


testsuite/
	* gdb.python/py-breakpoint.exp: Test gdb.BpLocation.