From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1638 invoked by alias); 15 Sep 2011 14:19:30 -0000 Received: (qmail 1629 invoked by uid 22791); 15 Sep 2011 14:19:28 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-vw0-f43.google.com (HELO mail-vw0-f43.google.com) (209.85.212.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Sep 2011 14:19:14 +0000 Received: by vws10 with SMTP id 10so4301249vws.30 for ; Thu, 15 Sep 2011 07:19:14 -0700 (PDT) Received: by 10.220.142.6 with SMTP id o6mr317735vcu.88.1316096354133; Thu, 15 Sep 2011 07:19:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.178.11 with HTTP; Thu, 15 Sep 2011 07:18:54 -0700 (PDT) In-Reply-To: <09787EF419216C41A903FD14EE5506DD0307EF986F@AUSX7MCPC103.AMER.DELL.COM> References: <83vctdej0n.fsf@gnu.org> <83ty8xebob.fsf@gnu.org> <83obz5ea7z.fsf@gnu.org> <09787EF419216C41A903FD14EE5506DD0307EF986F@AUSX7MCPC103.AMER.DELL.COM> From: Kevin Pouget Date: Thu, 15 Sep 2011 15:27:00 -0000 Message-ID: Subject: Re: [PATCH] PR/12691 Add the inferior to Python exited event To: Paul_Koning@dell.com, eliz@gnu.org Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00272.txt.bz2 On Thu, Sep 15, 2011 at 3:57 PM, wrote: >> =A0An integer representing the exit code, if available, which the >>> =A0inferior has returned. =A0(The exit code could be unavailable if, for >>> =A0example, @value{GDBN} detaches from the inferior.) >>> >> >> right, I've updated the patch, is it fine for you ? > > The old text is more explicit about what you see if the exit code is not = available. =A0It would be good to keep that -- i.e., the attribute isn't th= ere if the exit code is not available. =A0The reason for being explicit is = that a different way of handling that situation -- and arguably a more "Pyt= honic" one -- is for the attribute to exist in all cases but have the value= None if not applicable. =A0So you might make it: > > +An integer representing the exit code, if available, which the inferior > +has returned. =A0(The exit code could be unavailable if, for example, > +@value{GDBN} detaches from the inferior.) =A0If the exit code is > +unavailable, the attribute does not exist. I'm okay with this modification; I'll let Eli accept it before applying this patch Cordially, Kevin