From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4249 invoked by alias); 31 Aug 2011 14:58:24 -0000 Received: (qmail 4238 invoked by uid 22791); 31 Aug 2011 14:58:23 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gw0-f41.google.com (HELO mail-gw0-f41.google.com) (74.125.83.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Aug 2011 14:58:10 +0000 Received: by gwaa20 with SMTP id a20so152646gwa.0 for ; Wed, 31 Aug 2011 07:58:09 -0700 (PDT) Received: by 10.42.158.130 with SMTP id h2mr378243icx.476.1314802689283; Wed, 31 Aug 2011 07:58:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.42.4.8 with HTTP; Wed, 31 Aug 2011 07:57:48 -0700 (PDT) In-Reply-To: <83vctdej0n.fsf@gnu.org> References: <83vctdej0n.fsf@gnu.org> From: Kevin Pouget Date: Wed, 31 Aug 2011 14:58:00 -0000 Message-ID: Subject: Re: [PATCH] PR/12691 Add the inferior to Python exited event To: Eli Zaretskii Cc: tromey@redhat.com, gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=90e6ba6e88643e95f504abce5b18 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00659.txt.bz2 --90e6ba6e88643e95f504abce5b18 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1712 On Wed, Aug 31, 2011 at 4:46 PM, Eli Zaretskii wrote: >> From: Kevin Pouget >> Date: Wed, 31 Aug 2011 16:33:55 +0200 >> Cc: gdb-patches@sourceware.org >> >> The doc was accepted, but I had to reshape the paragraph during the >> update, Eli, could you please tell me what you think about it? > > I have a couple of minor comments: >> +@defivar ExitedEvent inferior >> +A reference to the inferior which triggered the exited event. > > I'd suggest to use @code{exited}, since this is a Python symbol. this one is fine, >> =A0@defivar ExitedEvent exit_code >> -An integer representing the exit code which the inferior has returned. >> +An integer representing the exit code which the inferior has returned. > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0^^^ > I think we would be better off without that "has" word. > >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (Optional, >> +will exist only in the case that the inferior exited with some status.) > > I understand you want to tell that the exit_code attribute is > optional? =A0This calls for some rewording, but I actually don't > understand how can it be that an inferior doesn't return any exit code > at all. =A0AFAIK, the exit code could be random garbage, but it's always > there. =A0Can you explain? but for these two, I didn't write it myself: as you can read in the patch, I only rearranged the sentence to include my information, the points you mention were not changed. (Let me know if you want me to change something anyway) Thanks, Kevin --90e6ba6e88643e95f504abce5b18 Content-Type: application/octet-stream; name=0001-PR-12691-Add-the-inferior-to-Python-exited-event Content-Disposition: attachment; filename=0001-PR-12691-Add-the-inferior-to-Python-exited-event Content-Transfer-Encoding: base64 X-Attachment-Id: f_gs0feih40 Content-length: 4958 RnJvbSBmNzViZTFlYmExMmUzMmEwZWJjZWNlZGUyZmNkNjk3ZDNiNGY2NzJi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZXZpbiBQb3VnZXQg PGtldmluLnBvdWdldEBzdC5jb20+CkRhdGU6IFdlZCwgMzEgQXVnIDIwMTEg MTY6MzI6NDUgKzAyMDAKU3ViamVjdDogW1BBVENIXSBQUi8xMjY5MSBBZGQg dGhlIGluZmVyaW9yIHRvIFB5dGhvbiBleGl0ZWQgZXZlbnQKCi0tLQogZ2Ri L2RvYy9nZGIudGV4aW5mbyAgICAgICAgICAgICAgICAgICAgfCAgIDEwICsr KysrKy0tLS0KIGdkYi9weXRob24vcHktZXhpdGVkZXZlbnQuYyAgICAgICAg ICAgIHwgICAgNiArKysrKysKIGdkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9w eS1ldmVudHMuYyAgIHwgICAgMSArCiBnZGIvdGVzdHN1aXRlL2dkYi5weXRo b24vcHktZXZlbnRzLmV4cCB8ICAgMTEgKysrKysrKysrKy0KIGdkYi90ZXN0 c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMucHkgIHwgICAgMSArCiA1IGZp bGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZ2RiL2RvYy9nZGIudGV4aW5mbyBiL2dkYi9kb2Mv Z2RiLnRleGluZm8KaW5kZXggMjNiMmE5OC4uNTFhYWFkNCAxMDA2NDQKLS0t IGEvZ2RiL2RvYy9nZGIudGV4aW5mbworKysgYi9nZGIvZG9jL2dkYi50ZXhp bmZvCkBAIC0yMjI4NSwxMiArMjIyODUsMTQgQEAgaW5oZXJpdGVkIGF0dHJp YnV0ZSByZWZlciB0byBAY29kZXtnZGIuVGhyZWFkRXZlbnR9IGFib3ZlLgog CiBAaXRlbSBldmVudHMuZXhpdGVkCiBFbWl0cyBAY29kZXtldmVudHMuRXhp dGVkRXZlbnR9IHdoaWNoIGluZGljYXRlcyB0aGF0IHRoZSBpbmZlcmlvciBo YXMgZXhpdGVkLgotQGNvZGV7ZXZlbnRzLkV4aXRlZEV2ZW50fSBoYXMgb25l IG9wdGlvbmFsIGF0dHJpYnV0ZS4gIFRoaXMgYXR0cmlidXRlCi13aWxsIGV4 aXN0IG9ubHkgaW4gdGhlIGNhc2UgdGhhdCB0aGUgaW5mZXJpb3IgZXhpdGVk IHdpdGggc29tZQotc3RhdHVzLgorQGNvZGV7ZXZlbnRzLkV4aXRlZEV2ZW50 fSBoYXMgdHdvIGF0dHJpYnV0ZXM6CiBAdGFibGUgQGNvZGUKIEBkZWZpdmFy IEV4aXRlZEV2ZW50IGV4aXRfY29kZQotQW4gaW50ZWdlciByZXByZXNlbnRp bmcgdGhlIGV4aXQgY29kZSB3aGljaCB0aGUgaW5mZXJpb3IgaGFzIHJldHVy bmVkLgorQW4gaW50ZWdlciByZXByZXNlbnRpbmcgdGhlIGV4aXQgY29kZSB3 aGljaCB0aGUgaW5mZXJpb3IgaGFzIHJldHVybmVkLiAoT3B0aW9uYWwsCit3 aWxsIGV4aXN0IG9ubHkgaW4gdGhlIGNhc2UgdGhhdCB0aGUgaW5mZXJpb3Ig ZXhpdGVkIHdpdGggc29tZSBzdGF0dXMuKQorQGVuZCBkZWZpdmFyCitAZGVm aXZhciBFeGl0ZWRFdmVudCBpbmZlcmlvcgorQSByZWZlcmVuY2UgdG8gdGhl IGluZmVyaW9yIHdoaWNoIHRyaWdnZXJlZCB0aGUgQHtleGl0ZWR9IGV2ZW50 LgogQGVuZCBkZWZpdmFyCiBAZW5kIHRhYmxlCiAKZGlmZiAtLWdpdCBhL2dk Yi9weXRob24vcHktZXhpdGVkZXZlbnQuYyBiL2dkYi9weXRob24vcHktZXhp dGVkZXZlbnQuYwppbmRleCAwODE1MGU1Li41ZWU2ZWI4IDEwMDY0NAotLS0g YS9nZGIvcHl0aG9uL3B5LWV4aXRlZGV2ZW50LmMKKysrIGIvZ2RiL3B5dGhv bi9weS1leGl0ZWRldmVudC5jCkBAIC0zNyw2ICszNywxMiBAQCBjcmVhdGVf ZXhpdGVkX2V2ZW50X29iamVjdCAoY29uc3QgTE9OR0VTVCAqZXhpdF9jb2Rl KQogCQkJICAgICBQeUxvbmdfRnJvbUxvbmdMb25nICgqZXhpdF9jb2RlKSkg PCAwKQogICAgIGdvdG8gZmFpbDsKIAorICBpbmZfb2JqID0gaW5mZXJpb3Jf dG9faW5mZXJpb3Jfb2JqZWN0IChpbmYpOworICBpZiAoIWluZl9vYmogfHwg ZXZweV9hZGRfYXR0cmlidXRlIChleGl0ZWRfZXZlbnQsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICJpbmZlcmlvciIsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluZl9vYmopIDwg MCkKKyAgICBnb3RvIGZhaWw7CisKICAgcmV0dXJuIGV4aXRlZF9ldmVudDsK IAogICBmYWlsOgpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0 aG9uL3B5LWV2ZW50cy5jIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5 LWV2ZW50cy5jCmluZGV4IGNlYjY5N2UuLjY2NWNhNTEgMTAwNjQ0Ci0tLSBh L2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMuYworKysgYi9n ZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRzLmMKQEAgLTE3LDYg KzE3LDcgQEAKICovCiAKIGludCBzZWNvbmQoKXsKKyAgZm9yaygpIDsKICAg cmV0dXJuIDEyOwogfQogCmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2dk Yi5weXRob24vcHktZXZlbnRzLmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5 dGhvbi9weS1ldmVudHMuZXhwCmluZGV4IGU1ZDZkYWYuLmNkZjRhZTYgMTAw NjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMu ZXhwCisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMu ZXhwCkBAIC00Miw2ICs0Miw4IEBAIGlmICFbcnVudG9fbWFpbiBdIHRoZW4g ewogICAgIHJldHVybiAtMQogfQogCitnZGJfdGVzdF9ub19vdXRwdXQgInNl dCBkZXRhY2gtb24tZm9yayBvZmYiICJEb24ndCBkZXRhY2ggb24gZm9yayIK KwogZ2RiX3Rlc3QgIlRlc3RfRXZlbnRzIiAiRXZlbnQgdGVzdGVycyByZWdp c3RlcmVkLiIKIAogZ2RiX2JyZWFrcG9pbnQgImZpcnN0IgpAQCAtNTYsNCAr NTgsMTEgQEAgYWxsIHRocmVhZHMgc3RvcHBlZCIKICN0ZXN0IGV4aXRlZCBl dmVudC4KIGdkYl90ZXN0ICJjb250aW51ZSIgIi4qZXZlbnQgdHlwZTogY29u dGludWUuKgogLipldmVudCB0eXBlOiBleGl0LioKLS4qZXhpdCBjb2RlOiAx Mi4qIgorLipleGl0IGNvZGU6IDEyLioKKy4qZXhpdCBpbmY6IDEuKiIgIklu ZmVyaW9yIDEgdGVybWluYXRlZC4iCisKK2dkYl90ZXN0ICJpbmZlcmlvciAy IiAiLipTd2l0Y2hpbmcgdG8gaW5mZXJpb3IgMi4qIgorZ2RiX3Rlc3QgImNv bnRpbnVlIiAiLipldmVudCB0eXBlOiBjb250aW51ZS4qCisuKmV2ZW50IHR5 cGU6IGV4aXQuKgorLipleGl0IGNvZGU6IDEyLioKKy4qZXhpdCBpbmY6IDIu KiIgIkluZmVyaW9yIDEgdGVybWluYXRlZC4iCmRpZmYgLS1naXQgYS9nZGIv dGVzdHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRzLnB5IGIvZ2RiL3Rlc3Rz dWl0ZS9nZGIucHl0aG9uL3B5LWV2ZW50cy5weQppbmRleCA5ZjA1YjlmLi5i NDBmMDc0IDEwMDY0NAotLS0gYS9nZGIvdGVzdHN1aXRlL2dkYi5weXRob24v cHktZXZlbnRzLnB5CisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9w eS1ldmVudHMucHkKQEAgLTQxLDYgKzQxLDcgQEAgZGVmIGV4aXRfaGFuZGxl ciAoZXZlbnQpOgogICAgIGlmIChpc2luc3RhbmNlIChldmVudCwgZ2RiLkV4 aXRlZEV2ZW50KSk6CiAgICAgICAgIHByaW50ICJldmVudCB0eXBlOiBleGl0 IgogICAgIHByaW50ICJleGl0IGNvZGU6ICVkIiAlIChldmVudC5leGl0X2Nv ZGUpCisgICAgcHJpbnQgImV4aXQgaW5mOiAlZCIgJSAoZXZlbnQuaW5mZXJp b3IubnVtKQogCiBkZWYgY29udGludWVfaGFuZGxlciAoZXZlbnQpOgogICAg IGlmIChpc2luc3RhbmNlIChldmVudCwgZ2RiLkNvbnRpbnVlRXZlbnQpKToK LS0gCjEuNy42Cgo= --90e6ba6e88643e95f504abce5b18--