From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17423 invoked by alias); 25 Oct 2011 07:20:57 -0000 Received: (qmail 17410 invoked by uid 22791); 25 Oct 2011 07:20:54 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Oct 2011 07:20:39 +0000 Received: by vcbfk1 with SMTP id fk1so183002vcb.0 for ; Tue, 25 Oct 2011 00:20:39 -0700 (PDT) Received: by 10.220.142.8 with SMTP id o8mr1990963vcu.38.1319527239096; Tue, 25 Oct 2011 00:20:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.180.75 with HTTP; Tue, 25 Oct 2011 00:20:19 -0700 (PDT) In-Reply-To: <8339eie2ij.fsf@gnu.org> References: <201110141600.20561.pedro@codesourcery.com> <8339eie2ij.fsf@gnu.org> From: Kevin Pouget Date: Tue, 25 Oct 2011 08:31:00 -0000 Message-ID: Subject: Re: [RFC][Python] gdbpy_frame_stop_reason_string bug To: Eli Zaretskii Cc: pedro@codesourcery.com, pmuldoon@redhat.com, gdb-patches@sourceware.org, tromey@redhat.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00650.txt.bz2 On Mon, Oct 24, 2011 at 7:13 PM, Eli Zaretskii wrote: >> From: Kevin Pouget >> Date: Mon, 24 Oct 2011 18:27:01 +0200 >> Cc: Pedro Alves , pmuldoon@redhat.com, gdb-patch= es@sourceware.org, >> =A0 =A0 =A0 Tom Tromey >> >> ping, you might have missed this thread Eli > > Yes, sorry. > >> +@item gdb.FRAME_UNWIND_FIRST_ERROR >> +All the conditions after this alias are considered errors; > > Hmm... =A0This table is preceded by this text: > > =A0@defun Frame.unwind_stop_reason () > =A0Return an integer representing the reason why it's not possible to find > =A0more frames toward the outermost frame. =A0Use > =A0@code{gdb.frame_stop_reason_string} to convert the value returned by t= his > =A0function to a string. The value can be one of: > > So "conditions after this alias" seems inappropriate in the list that > follows, because we are not describing conditions or aliases. =A0Can you > rephrase this to be consistent with the rest of the list. I'm not sure about you see wrong with "alias". We could replace it with "reference" (like the & operator in C++, but also used in Python and Java), but it sounds more or less the same to me. What do you think about: "Stop reasons greater or equal to this value/alias/reference" > And why is it important that the value is an alias for another? it's important because it's not a distinct value as the other ones, so > frame_stop_reason_string(UNWIND_FIRST_ERROR) =3D=3D frame_stop_reason_str= ing(UNWIND_UNAVAILABLE) is True, which might be counter-intuitive if you don't know that UNWIND_FIRST_ERROR is an alias/reference >> +abnormal stack termination. =A0Current value is gdb.FRAME_UNWIND_UNAVAI= LABLE. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > This should be in @code{}. I'll change it > Okay with these changes. Thanks for your time, Kevin