From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19735 invoked by alias); 31 Aug 2011 12:45:28 -0000 Received: (qmail 19726 invoked by uid 22791); 31 Aug 2011 12:45:27 -0000 X-SWARE-Spam-Status: No, hits=0.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KAM_STOCKTIP,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-yw0-f41.google.com (HELO mail-yw0-f41.google.com) (209.85.213.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Aug 2011 12:45:03 +0000 Received: by ywm13 with SMTP id 13so562004ywm.0 for ; Wed, 31 Aug 2011 05:45:03 -0700 (PDT) Received: by 10.42.132.138 with SMTP id d10mr326274ict.208.1314794703153; Wed, 31 Aug 2011 05:45:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.42.4.8 with HTTP; Wed, 31 Aug 2011 05:44:43 -0700 (PDT) In-Reply-To: References: <201104121355.11278.pedro@codesourcery.com> <201104121441.56034.pedro@codesourcery.com> From: Kevin Pouget Date: Wed, 31 Aug 2011 12:45:00 -0000 Message-ID: Subject: Re: [PATCH] GDB checkpoint can't/shouldn't be possible with multiple threads on Linux To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=90e6ba6e85343bebb404abcc7ff2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00653.txt.bz2 --90e6ba6e85343bebb404abcc7ff2 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1032 On Tue, Apr 12, 2011 at 3:54 PM, Kevin Pouget wrote: > > On Tue, Apr 12, 2011 at 9:41 AM, Pedro Alves wrote: > > Small nit I should have caught before: > > > > On Tuesday 12 April 2011 14:27:49, Kevin Pouget wrote: > >> +static int > >> +inf_has_multiple_thread_cb (struct thread_info *tp, void *data) > >> +{ > >> + int *has_multiple_threads = (int *) data; > > > > can you rename this local as well, in line with the other > > local in the other function? To "count", or "count_p", or something > > like that. Thanks. (pre-approved) > > fixed with count_p, thanks Hello, my copyright assignment is now ready, so I regenerated the patch against the up-to-date trunk Cordially, Kevin -- 2011-08-31 Kevin Pouget PR threads/12628 * linux-fork.c (checkpoint_command): Disallow checkpointing of processes with multiple threads. (inf_has_multiple_thread_cb): New function. (inf_has_multiple_threads): New function. --90e6ba6e85343bebb404abcc7ff2 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Disallow-checkpointing-of-multiple-threads.patch" Content-Disposition: attachment; filename="0001-Disallow-checkpointing-of-multiple-threads.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gs0aowff0 Content-length: 2579 RnJvbSBhYWYwYmVkZmU2YWE2MWJhMDY3NjFkYmUzODE3NzBiYTg2YmRkZjZh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZXZpbiBQb3VnZXQg PGtldmluLnBvdWdldEBzdC5jb20+CkRhdGU6IFR1ZSwgMTIgQXByIDIwMTEg MTA6MzE6NDAgLTA0MDAKU3ViamVjdDogW1BBVENIXSBEaXNhbGxvdyBjaGVj a3BvaW50aW5nIG9mIG11bHRpcGxlIHRocmVhZHMKClNpZ25lZC1vZmYtYnk6 IEtldmluIFBvdWdldCA8a2V2aW4ucG91Z2V0QHN0LmNvbT4KLS0tCiBnZGIv bGludXgtZm9yay5jIHwgICAzNSArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKwogMSBmaWxlcyBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCsp LCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2dkYi9saW51eC1mb3Jr LmMgYi9nZGIvbGludXgtZm9yay5jCmluZGV4IDdmNjU0YWYuLmRlNTEyYzMg MTAwNjQ0Ci0tLSBhL2dkYi9saW51eC1mb3JrLmMKKysrIGIvZ2RiL2xpbnV4 LWZvcmsuYwpAQCAtNjE2LDYgKzYxNiwzMyBAQCBsaW51eF9mb3JrX2NoZWNr cG9pbnRpbmdfcCAoaW50IHBpZCkKICAgcmV0dXJuIChjaGVja3BvaW50aW5n X3BpZCA9PSBwaWQpOwogfQogCisvKiBDYWxsYmFjayBmb3IgaXRlcmF0ZSBv dmVyIHRocmVhZHMuICBVc2VkIHRvIGNoZWNrIHdoZXRoZXIKKyAgIHRoZSBj dXJyZW50IGluZmVyaW9yIGlzIG11bHRpLXRocmVhZGVkLiAgUmV0dXJucyB0 cnVlIGFzIHNvb24KKyAgIGFzIGl0IHNlZXMgdGhlIHNlY29uZCB0aHJlYWQg b2YgdGhlIGN1cnJlbnQgaW5mZXJpb3IuICAqLworCitzdGF0aWMgaW50Citp bmZfaGFzX211bHRpcGxlX3RocmVhZF9jYiAoc3RydWN0IHRocmVhZF9pbmZv ICp0cCwgdm9pZCAqZGF0YSkKK3sKKyAgaW50ICpjb3VudF9wID0gKGludCAq KSBkYXRhOworICAKKyAgaWYgKGN1cnJlbnRfaW5mZXJpb3IgKCktPnBpZCA9 PSBwdGlkX2dldF9waWQgKHRwLT5wdGlkKSkKKyAgICAoKmNvdW50X3ApKys7 CisgIAorICAvKiBTdG9wIHRoZSBpdGVyYXRpb24gaWYgbXVsdGlwbGUgdGhy ZWFkcyBoYXZlIGJlZW4gZGV0ZWN0ZWQuICAqLworICByZXR1cm4gKmNvdW50 X3AgPiAxOworfQorCisvKiBSZXR1cm4gdHJ1ZSBpZiB0aGUgY3VycmVudCBp bmZlcmlvciBpcyBtdWx0aS10aHJlYWRlZC4gICovCisKK3N0YXRpYyBpbnQK K2luZl9oYXNfbXVsdGlwbGVfdGhyZWFkcyAodm9pZCkKK3sKKyAgaW50IGNv dW50ID0gMDsKKworICBpdGVyYXRlX292ZXJfdGhyZWFkcyAoaW5mX2hhc19t dWx0aXBsZV90aHJlYWRfY2IsICZjb3VudCk7CisgIHJldHVybiAoY291bnQg PiAxKTsKK30KKwogc3RhdGljIHZvaWQKIGNoZWNrcG9pbnRfY29tbWFuZCAo Y2hhciAqYXJncywgaW50IGZyb21fdHR5KQogewpAQCAtNjI4LDYgKzY1NSwx NCBAQCBjaGVja3BvaW50X2NvbW1hbmQgKGNoYXIgKmFyZ3MsIGludCBmcm9t X3R0eSkKICAgcGlkX3QgcmV0cGlkOwogICBzdHJ1Y3QgY2xlYW51cCAqb2xk X2NoYWluOwogCisgIGlmICghdGFyZ2V0X2hhc19leGVjdXRpb24pIAorICAg IGVycm9yIChfKCJUaGUgcHJvZ3JhbSBpcyBub3QgYmVpbmcgcnVuLiIpKTsK KworICAvKiBFbnN1cmUgdGhhdCB0aGUgaW5mZXJpb3IgaXMgbm90IG11bHRp dGhyZWFkZWQuICAqLworICB1cGRhdGVfdGhyZWFkX2xpc3QgKCk7CisgIGlm IChpbmZfaGFzX211bHRpcGxlX3RocmVhZHMgKCkpCisgICAgZXJyb3IgKF8o ImNoZWNrcG9pbnQ6IGNhbid0IGNoZWNrcG9pbnQgbXVsdGlwbGUgdGhyZWFk cy4iKSk7CisgIAogICAvKiBNYWtlIHRoZSBpbmZlcmlvciBmb3JrLCByZWNv cmQgaXRzIChhbmQgZ2RiJ3MpIHN0YXRlLiAgKi8KIAogICBpZiAobG9va3Vw X21pbmltYWxfc3ltYm9sICgiZm9yayIsIE5VTEwsIE5VTEwpICE9IE5VTEwp Ci0tIAoxLjcuNgoK --90e6ba6e85343bebb404abcc7ff2--