From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13166 invoked by alias); 31 Aug 2011 14:34:33 -0000 Received: (qmail 12682 invoked by uid 22791); 31 Aug 2011 14:34:31 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gw0-f41.google.com (HELO mail-gw0-f41.google.com) (74.125.83.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Aug 2011 14:34:16 +0000 Received: by gwaa20 with SMTP id a20so129820gwa.0 for ; Wed, 31 Aug 2011 07:34:16 -0700 (PDT) Received: by 10.42.96.65 with SMTP id i1mr407522icn.275.1314801255839; Wed, 31 Aug 2011 07:34:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.42.4.8 with HTTP; Wed, 31 Aug 2011 07:33:55 -0700 (PDT) In-Reply-To: References: From: Kevin Pouget Date: Wed, 31 Aug 2011 14:34:00 -0000 Message-ID: Subject: Re: [PATCH] PR/12691 Add the inferior to Python exited event To: Tom Tromey , Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=20cf303bfb12cdf79304abce0530 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00657.txt.bz2 --20cf303bfb12cdf79304abce0530 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 2333 On Tue, Apr 26, 2011 at 10:22 AM, Kevin Pouget wro= te: > On Mon, Apr 25, 2011 at 2:19 PM, Tom Tromey wrote: >> >> >>>>> "Kevin" =3D=3D Kevin Pouget writes: >> >> Kevin> Following Tom's advise >> Kevin> (http://sourceware.org/ml/gdb/2011-04/msg00116.html), here is a p= atch >> Kevin> which hooks the inferior to the `exited' event object >> Kevin> let me know what you think about it >> >> It looks pretty good, but I think it needs a couple small changes. >> >> Kevin> + =A0if (evpy_add_attribute (exited_event, >> Kevin> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"inferior", >> Kevin> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0inferior_to_= inferior_object (inf)) < 0) >> Kevin> + =A0 =A0goto fail; >> >> This does not account for the possibility that >> inferior_to_inferior_object could fail. =A0I think there has >> to be a temporary object that is explicitly checked against NULL. > > > done, it should only fail when the process runs out of space, so GDB > must handle it somewhere else > >> Kevin> +gdb_test "continue" ".*event type: continue.* >> Kevin> +.*event type: exit.* >> Kevin> +.*exit code: 12.* >> Kevin> +.*exit inf: 2.*" >> >> Pass a test name to gdb_test. > > right Hello, this patch was not explicitly accepted, could you please review this version updated against the last trunk? The doc was accepted, but I had to reshape the paragraph during the update, Eli, could you please tell me what you think about it? Cordially, Kevin 2011-04-21 Kevin Pouget PR python/12691: Add the inferior to Python exited event * python/py-exitedevent.c (create_exited_event_object): Add inferior to exited_event. * python/py-event.h (emit_exited_event): Likewise * python/-inferior.c (python_inferior_exit): Likewise 2011-04-21 Kevin Pouget PR python/12691: Add the inferior to Python exited event * gdb.python/py-events.exp: Test the inferior attribute of exited event with a fork. * gdb.python/py-events.py: Print inferior number on exit. * gdb.python/py-events.c: Fork the inferior. 2011-04-21 Kevin Pouget PR python/12691: Add the inferior to Python exited event * gdb.texinfo (Events In Python): Describe exited inferior attribute. --20cf303bfb12cdf79304abce0530 Content-Type: application/octet-stream; name=0001-PR-12691-Add-the-inferior-to-Python-exited-event Content-Disposition: attachment; filename=0001-PR-12691-Add-the-inferior-to-Python-exited-event Content-Transfer-Encoding: base64 X-Attachment-Id: f_gs0epiep0 Content-length: 4954 RnJvbSA5Y2FhM2VkYzY1ZWMxYmVmNWFjNTRkNjc2MzY1YzU1OTU2NzRjZTdl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZXZpbiBQb3VnZXQg PGtldmluLnBvdWdldEBzdC5jb20+CkRhdGU6IFdlZCwgMzEgQXVnIDIwMTEg MTY6MzI6NDUgKzAyMDAKU3ViamVjdDogW1BBVENIXSBQUi8xMjY5MSBBZGQg dGhlIGluZmVyaW9yIHRvIFB5dGhvbiBleGl0ZWQgZXZlbnQKCi0tLQogZ2Ri L2RvYy9nZGIudGV4aW5mbyAgICAgICAgICAgICAgICAgICAgfCAgIDEwICsr KysrKy0tLS0KIGdkYi9weXRob24vcHktZXhpdGVkZXZlbnQuYyAgICAgICAg ICAgIHwgICAgNiArKysrKysKIGdkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9w eS1ldmVudHMuYyAgIHwgICAgMSArCiBnZGIvdGVzdHN1aXRlL2dkYi5weXRo b24vcHktZXZlbnRzLmV4cCB8ICAgMTEgKysrKysrKysrKy0KIGdkYi90ZXN0 c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMucHkgIHwgICAgMSArCiA1IGZp bGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZ2RiL2RvYy9nZGIudGV4aW5mbyBiL2dkYi9kb2Mv Z2RiLnRleGluZm8KaW5kZXggMjNiMmE5OC4uYmJjN2E3ZCAxMDA2NDQKLS0t IGEvZ2RiL2RvYy9nZGIudGV4aW5mbworKysgYi9nZGIvZG9jL2dkYi50ZXhp bmZvCkBAIC0yMjI4NSwxMiArMjIyODUsMTQgQEAgaW5oZXJpdGVkIGF0dHJp YnV0ZSByZWZlciB0byBAY29kZXtnZGIuVGhyZWFkRXZlbnR9IGFib3ZlLgog CiBAaXRlbSBldmVudHMuZXhpdGVkCiBFbWl0cyBAY29kZXtldmVudHMuRXhp dGVkRXZlbnR9IHdoaWNoIGluZGljYXRlcyB0aGF0IHRoZSBpbmZlcmlvciBo YXMgZXhpdGVkLgotQGNvZGV7ZXZlbnRzLkV4aXRlZEV2ZW50fSBoYXMgb25l IG9wdGlvbmFsIGF0dHJpYnV0ZS4gIFRoaXMgYXR0cmlidXRlCi13aWxsIGV4 aXN0IG9ubHkgaW4gdGhlIGNhc2UgdGhhdCB0aGUgaW5mZXJpb3IgZXhpdGVk IHdpdGggc29tZQotc3RhdHVzLgorQGNvZGV7ZXZlbnRzLkV4aXRlZEV2ZW50 fSBoYXMgdHdvIGF0dHJpYnV0ZXM6CiBAdGFibGUgQGNvZGUKIEBkZWZpdmFy IEV4aXRlZEV2ZW50IGV4aXRfY29kZQotQW4gaW50ZWdlciByZXByZXNlbnRp bmcgdGhlIGV4aXQgY29kZSB3aGljaCB0aGUgaW5mZXJpb3IgaGFzIHJldHVy bmVkLgorQW4gaW50ZWdlciByZXByZXNlbnRpbmcgdGhlIGV4aXQgY29kZSB3 aGljaCB0aGUgaW5mZXJpb3IgaGFzIHJldHVybmVkLiAoT3B0aW9uYWwsCit3 aWxsIGV4aXN0IG9ubHkgaW4gdGhlIGNhc2UgdGhhdCB0aGUgaW5mZXJpb3Ig ZXhpdGVkIHdpdGggc29tZSBzdGF0dXMuKQorQGVuZCBkZWZpdmFyCitAZGVm aXZhciBFeGl0ZWRFdmVudCBpbmZlcmlvcgorQSByZWZlcmVuY2UgdG8gdGhl IGluZmVyaW9yIHdoaWNoIHRyaWdnZXJlZCB0aGUgZXhpdGVkIGV2ZW50Lgog QGVuZCBkZWZpdmFyCiBAZW5kIHRhYmxlCiAKZGlmZiAtLWdpdCBhL2dkYi9w eXRob24vcHktZXhpdGVkZXZlbnQuYyBiL2dkYi9weXRob24vcHktZXhpdGVk ZXZlbnQuYwppbmRleCAwODE1MGU1Li41ZWU2ZWI4IDEwMDY0NAotLS0gYS9n ZGIvcHl0aG9uL3B5LWV4aXRlZGV2ZW50LmMKKysrIGIvZ2RiL3B5dGhvbi9w eS1leGl0ZWRldmVudC5jCkBAIC0zNyw2ICszNywxMiBAQCBjcmVhdGVfZXhp dGVkX2V2ZW50X29iamVjdCAoY29uc3QgTE9OR0VTVCAqZXhpdF9jb2RlKQog CQkJICAgICBQeUxvbmdfRnJvbUxvbmdMb25nICgqZXhpdF9jb2RlKSkgPCAw KQogICAgIGdvdG8gZmFpbDsKIAorICBpbmZfb2JqID0gaW5mZXJpb3JfdG9f aW5mZXJpb3Jfb2JqZWN0IChpbmYpOworICBpZiAoIWluZl9vYmogfHwgZXZw eV9hZGRfYXR0cmlidXRlIChleGl0ZWRfZXZlbnQsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICJpbmZlcmlvciIsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluZl9vYmopIDwgMCkK KyAgICBnb3RvIGZhaWw7CisKICAgcmV0dXJuIGV4aXRlZF9ldmVudDsKIAog ICBmYWlsOgpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9u L3B5LWV2ZW50cy5jIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LWV2 ZW50cy5jCmluZGV4IGNlYjY5N2UuLjY2NWNhNTEgMTAwNjQ0Ci0tLSBhL2dk Yi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMuYworKysgYi9nZGIv dGVzdHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRzLmMKQEAgLTE3LDYgKzE3 LDcgQEAKICovCiAKIGludCBzZWNvbmQoKXsKKyAgZm9yaygpIDsKICAgcmV0 dXJuIDEyOwogfQogCmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2dkYi5w eXRob24vcHktZXZlbnRzLmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhv bi9weS1ldmVudHMuZXhwCmluZGV4IGU1ZDZkYWYuLmNkZjRhZTYgMTAwNjQ0 Ci0tLSBhL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMuZXhw CisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMuZXhw CkBAIC00Miw2ICs0Miw4IEBAIGlmICFbcnVudG9fbWFpbiBdIHRoZW4gewog ICAgIHJldHVybiAtMQogfQogCitnZGJfdGVzdF9ub19vdXRwdXQgInNldCBk ZXRhY2gtb24tZm9yayBvZmYiICJEb24ndCBkZXRhY2ggb24gZm9yayIKKwog Z2RiX3Rlc3QgIlRlc3RfRXZlbnRzIiAiRXZlbnQgdGVzdGVycyByZWdpc3Rl cmVkLiIKIAogZ2RiX2JyZWFrcG9pbnQgImZpcnN0IgpAQCAtNTYsNCArNTgs MTEgQEAgYWxsIHRocmVhZHMgc3RvcHBlZCIKICN0ZXN0IGV4aXRlZCBldmVu dC4KIGdkYl90ZXN0ICJjb250aW51ZSIgIi4qZXZlbnQgdHlwZTogY29udGlu dWUuKgogLipldmVudCB0eXBlOiBleGl0LioKLS4qZXhpdCBjb2RlOiAxMi4q IgorLipleGl0IGNvZGU6IDEyLioKKy4qZXhpdCBpbmY6IDEuKiIgIkluZmVy aW9yIDEgdGVybWluYXRlZC4iCisKK2dkYl90ZXN0ICJpbmZlcmlvciAyIiAi LipTd2l0Y2hpbmcgdG8gaW5mZXJpb3IgMi4qIgorZ2RiX3Rlc3QgImNvbnRp bnVlIiAiLipldmVudCB0eXBlOiBjb250aW51ZS4qCisuKmV2ZW50IHR5cGU6 IGV4aXQuKgorLipleGl0IGNvZGU6IDEyLioKKy4qZXhpdCBpbmY6IDIuKiIg IkluZmVyaW9yIDEgdGVybWluYXRlZC4iCmRpZmYgLS1naXQgYS9nZGIvdGVz dHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRzLnB5IGIvZ2RiL3Rlc3RzdWl0 ZS9nZGIucHl0aG9uL3B5LWV2ZW50cy5weQppbmRleCA5ZjA1YjlmLi5iNDBm MDc0IDEwMDY0NAotLS0gYS9nZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHkt ZXZlbnRzLnB5CisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1l dmVudHMucHkKQEAgLTQxLDYgKzQxLDcgQEAgZGVmIGV4aXRfaGFuZGxlciAo ZXZlbnQpOgogICAgIGlmIChpc2luc3RhbmNlIChldmVudCwgZ2RiLkV4aXRl ZEV2ZW50KSk6CiAgICAgICAgIHByaW50ICJldmVudCB0eXBlOiBleGl0Igog ICAgIHByaW50ICJleGl0IGNvZGU6ICVkIiAlIChldmVudC5leGl0X2NvZGUp CisgICAgcHJpbnQgImV4aXQgaW5mOiAlZCIgJSAoZXZlbnQuaW5mZXJpb3Iu bnVtKQogCiBkZWYgY29udGludWVfaGFuZGxlciAoZXZlbnQpOgogICAgIGlm IChpc2luc3RhbmNlIChldmVudCwgZ2RiLkNvbnRpbnVlRXZlbnQpKToKLS0g CjEuNy42Cgo= --20cf303bfb12cdf79304abce0530--