On Thu, Sep 1, 2011 at 11:56 AM, Pedro Alves <pedro@codesourcery.com> wrote:
> Please teach your browser to attach files to gmail as
> some text based content type, like patch/diff or
> text/x-patch.

I'm sorry for that, it was on purpose that I removed the '.patch', but
I actually mixed up everything ...
From now one there should be no problem, I'll take extra care about
it, thanks for the tip (I guess there is no way to clean up the
archive ... ?)

On Thu, Sep 1, 2011 at 12:12 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> +  ** The "gdb.breakpoint" function has been deprecated and in favor of
>> +     "gdb.breakpoints".
>
> Without the "and", this is okay.

done

>> +@code{gdb.BreakpointEvent} event indicates that one or several breakpoints have
>                                                   ^^^^^^^^^^^^^^
> "one or more"

done

>> +@defivar BreakpointEvent breakpoints
>> +A sequence containing references to all the breakpoints (type
>> +@code{gdb.Breakpoint}) that were hit.
>>  @xref{Breakpoints In Python}, for details of the @code{gdb.Breakpoint} object.
>> +@defivar BreakpointEvent breakpoint
>
> This cannot be right: each @defivar should end with the corresponding
> "@end defivar".  Didn't makeinfo bitch at you?

yes sorry it does; I naïvely expected `make' to build --and crash--
the documentation

>> +A reference to the first breakpoint that was hit of type @code{gdb.Breakpoint}.
>
> As opposed to what? watchpoints, catchpoints etc.?  IOW, why do you
> need to mention the type issue?

these are not my words, I just updated the sentence to mention that
it's now deprecated.
But you're right, it is redundant with "(type @code{gdb.Breakpoint})"
mentioned in the previous lines (I removed it).

I understand this precision as a way to tell the Python type of the
object, and/or that it's a breakpoint hit, and nothing else
(watchpoints/catchpoints are not handled in Python yet, AFAIK)


Cordially,

Kevin

--

2011-04-30  Kevin Pouget  <kevin.pouget@st.com>

	Handle multiple breakpoint hits in Python interface:
	* gdb.texinfo (Events In Python): New function documentation:
	gdb.BreakpointEvent.breakpoints. Indicate that
	gdb.BreakpointEvent.breakpoint is now deprecated.

2011-04-30  Kevin Pouget  <kevin.pouget@st.com>

	Handle multiple breakpoint hits in Python interface:
	* python/py-bpevent.c (create_breakpoint_event_object): Rename C/Python
	variable to breakpoints.
	* python/py-stopevent.c (emit_stop_event): Return a Python tuple of
	bps instead of single breakpoint. Fix some space typos.
	* python/py-stopevent.c (create_breakpoint_event_object): Rename
	variable to breakpoints.

2011-04-30  Kevin Pouget  <kevin.pouget@st.com>

	Handle multiple breakpoint hits in Python interface:
	* gdb.python/py-events.exp: Set a duplicate breakpoint and check its
	presence.
	* gdb.python/py-events.py (breakpoint_stop_handler): Browse all the
	breakpoint hits.