On Thu, Oct 13, 2011 at 5:19 PM, Pedro Alves wrote: > The patch appears to be missing unwind_stop_reasons.def. > >> +#define SET(name, description) \ >> +  PyModule_AddIntConstant (gdb_module, "FRAME_"#name, unwind_cpt++); >> +#include "gdb/unwind_stop_reasons.def" > > What's that `unwind_cpt' for?  Wouldn't: > > #define SET(name, description) \ >  PyModule_AddIntConstant (gdb_module, "FRAME_"#name, name); > > work? yes indeed, I didn't catch this one I've updated the patch and include the missing file, thanks Kevin gdb/ 2011-10-14 Kevin Pouget * frame.c (frame_stop_reason_string): Rewrite using unwind_stop_reasons.def. * frame.h (enum unwind_stop_reason): Likewise. * python/py-frame.c (gdbpy_initialize_frames): Likewise. (gdbpy_frame_stop_reason_string): Use new enum unwind_stop_reason constants for bound-checking. include/gdb/ 2011-10-14 Kevin Pouget * unwind_stop_reasons.def: New file.