From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10303 invoked by alias); 9 Nov 2011 15:49:37 -0000 Received: (qmail 10292 invoked by uid 22791); 9 Nov 2011 15:49:35 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Nov 2011 15:49:19 +0000 Received: by vws16 with SMTP id 16so1824630vws.0 for ; Wed, 09 Nov 2011 07:49:19 -0800 (PST) Received: by 10.52.3.73 with SMTP id a9mr5320739vda.80.1320853759161; Wed, 09 Nov 2011 07:49:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.187.140 with HTTP; Wed, 9 Nov 2011 07:48:58 -0800 (PST) In-Reply-To: References: From: Kevin Pouget Date: Wed, 09 Nov 2011 15:49:00 -0000 Message-ID: Subject: Re: [python] [patch] PR python/13329 To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00229.txt.bz2 On Wed, Nov 9, 2011 at 4:35 PM, Phil Muldoon wrote: > > This patch changes the behavior of 'python stack-print' to three modes: > full, message or none. =A0The default has been set to "message". > > =A0full - will print the exception message and the stack. > =A0message - will print the exception type and message only. > =A0none - nothing will be printed. > > This patch also fixes a bug where we were calling gdbpy_print_stack > after a few PyRun_SimpleString calls. =A0This is not necessary as that > API deals with the exception internally and prints its own stack. > > This is backwards compatible with the deprecated maint set python print-s= ack. > > on - will set the mode to "full". > off - will set the mode to "none". > > Tested with no regressions. > > Cheers, > > Phil > Thanks Phil, that's exactly what I was looking for :) just a remark, + fprintf_filtered (gdb_stderr, + _("Error occurred computing Python error" \ + "message.\n")); this error message sounds strange to me, is it correct? Cheers, Kevin