Re: [RFC] Python Finish Breakpoints

Eli Zaretskii
2011-10-24T13:01:03Z

> From: Kevin Pouget <kevin.pouget@gmail.com>
> Date: Mon, 24 Oct 2011 11:14:42 +0200
> Cc: gdb-patches@sourceware.org
>
> I've updated the doc and testsuite accordingly, and as far as I've
> seen, there is no regression on X86_64/Fedora
> (I need still need to improve my test environment)

Thanks.

> +@subsubsection Finish Breakpoints
> +
> +@cindex python finish breakpoints
> +@tindex gdb.FinishBreakpoint

No @node? Why not?

> +extends @code{gdb.Breakpoint}. The underlying breakpoint will be disabled
^^^^^^^^^^
A typo.

> +and deleted when the execution will run out of the breakoint scope (i.e.@:
^^^^^^^^^
Another one.

> +breakpoint to become invisible to the user. @xref{Breakpoints In Python}
> +for further details about this argument.

You need a comma after the braces (didn't "make info" bitch at you?).

> +In some circonstances (e.g.@: @code{longjmp}, C++ exceptions, @value{GDBN}
^^^^^^^^^^^^^
A typo. Also, we use "C@{++}" throughout the document, it looks
prettier in print.

> +@code{return} command, ...), a function may not properly terminate, and thus
^^^
Please use @dots{} here instead of literal dots.

> +was not computable. This attribute is not writable.

Two blanks, please.

Okay with these changes.