On Tue, Dec 6, 2011 at 9:45 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Kevin" == Kevin Pouget <kevin.pouget@gmail.com> writes:
>
> Kevin> you're right, fixed
>
> Thanks.
>
> Tom> I think this still needs a NEWS entry.
>
> Kevin> nop, it was in the patch :)
>
> Whoops :-)
>
> Kevin> (no regression against current git source tree)
>
> This is ok.  Thank you very much.
>
> Tom

and we're .... not ready!

there are some regressions this morning, certainly due to your
ambiguous linespec patch!

first one is quite obvious:

a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp
-if ![runto "getpid"] then {
-    fail "Cannot run to getpid."
+if ![runto_main] then {
+    fail "Cannot run to main."     return 0 }
+gdb_breakpoint "getpid" {temporary}
+gdb_test "continue" "Temporary breakpoint .*in getpid.*" "continue to getpid"
+

"break getpid" used to work before actually starting the inferior, but
now it's unresolved


for the second one I'll need your opinion:

> bpfinishpy_detect_out_scope_cb (struct breakpoint *b, void *args)
> ...
> if (b->pspace == current_inferior ()->pspace
>     && (!target_has_registers
>         || frame_find_by_id (b->frame_id) == NULL))
>           bpfinishpy_out_of_scope (finish_bp);


bpfinishpy_out_of_scope can't be triggered anymore because you set
b->pspace to NULL. I hesitated about how to fix it, but I think that
FinishBP have to be bound to the pspace in which they were set, so I
added this line:

> bpfinishpy_init (PyObject *self, PyObject *args, PyObject *kwargs)
> ...
>   /* Bind the breakpoint with the current program space.  */
>   self_bpfinish->py_bp.bp->pspace = current_program_space;

I'm not sure whether your plans are to eventually get rid of this
field, but the pspace comments seem to indicate that this is the right
way to do


Cordially,

Kevin

--

2011-12-07  Kevin Pouget  <kevin.pouget@st.com>

	Introduce gdb.FinishBreakpoint in Python

	* Makefile.in (SUBDIR_PYTHON_OBS): Add py-finishbreakpoint.o.
	(SUBDIR_PYTHON_SRCS): Add python/py-finishbreakpoint.c.
	Add build rule for this file.
	* infcmd.c (print_return_value): Split to create get_return_value.
	(get_return_value): New function based on print_return_value. Handle
	case where stop_registers are not set.
	* inferior.h (get_return_value): New prototype.
	* python/py-breakpoint.c (bppy_pending_object): Make non-static.
	(gdbpy_breakpoint_created): Set is_py_finish_bp is necessary.
	(struct breakpoint_object): Move to python-internal.h
	(BPPY_REQUIRE_VALID): Likewise.
	(BPPY_SET_REQUIRE_VALID): Likewise.
	(gdbpy_breakpoint_created): Initialize is_finish_bp.
	(gdbpy_should_stop): Add  pre/post hooks before/after calling stop
	method.
	* python/python-internal.h (breakpoint_object_type): Add as extern.
	(bppy_pending_object): Likewise.
	(typedef struct breakpoint_object) Removed.
	(struct breakpoint_object): Moved from py-breakpoint.c.
	Add field is_finish_bp.
	(BPPY_REQUIRE_VALID): Moved from py-breakpoint.c.
	(BPPY_SET_REQUIRE_VALID): Likewise.
	(frame_object_to_frame_info): New prototype.
	(gdbpy_initialize_finishbreakpoints): New prototype.
	(bpfinishpy_is_finish_bp): Likewise.
	(bpfinishpy_pre_stop_hook): Likewise.
	(bpfinishpy_post_stop_hook): Likewise.
	* python/py-finishbreakpoint.c: New file.
	* python/py-frame.c(frame_object_to_frame_info): Make non-static and
	accept PyObject instead of frame_object.
	(frapy_is_valid): Don't cast to frame_object.
	(frapy_name): Likewise.
	(frapy_type): Likewise.
	(frapy_unwind_stop_reason): Likewise.
	(frapy_pc): Likewise.
	(frapy_block): Likewise.
	(frapy_function): Likewise.
	(frapy_older): Likewise.
	(frapy_newer): Likewise.
	(frapy_find_sal): Likewise.
	(frapy_read_var): Likewise.
	(frapy_select): Likewise.
	* python/python.c (gdbpy_is_stopped_at_finish_bp): New noop function.
	(_initialize_python): Add gdbpy_initialize_finishbreakpoints.
	* python/python.h: Include breakpoint.h
	(gdbpy_is_stopped_at_finish_bp): New prototype.

doc/
	* gdb.texinfo (Finish Breakpoints in Python): New subsection.
	(Python API): Add menu entry for Finish Breakpoints.

testsuite/
	* gdb.python/py-breakpoint.exp (mult_line): Define and use variable
	instead of line number.
	* gdb.python/py-finish-breakpoint.c: New file.
	* gdb.python/py-finish-breakpoint.exp: New file.
	* gdb.python/py-finish-breakpoint.py: New file.
	* gdb.python/py-finish-breakpoint2.cc: New file.
	* gdb.python/py-finish-breakpoint2.exp: New file.
	* gdb.python/py-finish-breakpoint2.py: New file.