From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17615 invoked by alias); 19 Sep 2011 10:16:37 -0000 Received: (qmail 17604 invoked by uid 22791); 19 Sep 2011 10:16:34 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-vw0-f50.google.com (HELO mail-vw0-f50.google.com) (209.85.212.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Sep 2011 10:16:17 +0000 Received: by vws14 with SMTP id 14so9639300vws.23 for ; Mon, 19 Sep 2011 03:16:16 -0700 (PDT) Received: by 10.220.158.9 with SMTP id d9mr572482vcx.18.1316427376110; Mon, 19 Sep 2011 03:16:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.178.11 with HTTP; Mon, 19 Sep 2011 03:15:56 -0700 (PDT) In-Reply-To: References: From: Kevin Pouget Date: Mon, 19 Sep 2011 10:37:00 -0000 Message-ID: Subject: Re: [PATCH] PR/12691 Add the inferior to Python exited event To: Tom Tromey Cc: Eli Zaretskii , gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=e0cb4e8878e3202abd04ad48a261 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00354.txt.bz2 --e0cb4e8878e3202abd04ad48a261 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 2396 On Wed, Aug 31, 2011 at 5:50 PM, Tom Tromey wrote: >>>>>> "Kevin" =3D=3D Kevin Pouget writes: > > Kevin> this patch was not explicitly accepted, could you please review th= is > Kevin> version updated against the last trunk? > > Code bits are ok. =A0Thanks. > > Tom Hello, There was a discrepancy between the version of the patch you approved (http://sourceware.org/ml/gdb-patches/2011-08/msg00659/0001-PR-12691-Add-th= e-inferior-to-Python-exited-event) and the one I originally submitted (I certainly missed a step during the April->August update in the git tree): gdb/doc/gdb.texinfo | 10 ++++++---- gdb/python/py-exitedevent.c | 6 ++++++ gdb/testsuite/gdb.python/py-events.c | 1 + gdb/testsuite/gdb.python/py-events.exp | 11 ++++++++++- gdb/testsuite/gdb.python/py-events.py | 1 + 5 files changed, 24 insertions(+), 5 deletions(-) and > gdb/doc/gdb.texinfo | 12 ++++++++---- > gdb/python/py-event.h | 2 +- > gdb/python/py-exitedevent.c | 13 ++++++++++--- > gdb/python/py-inferior.c | 2 +- gdb/testsuite/gdb.python/py-events.c | 1 + gdb/testsuite/gdb.python/py-events.exp | 11 ++++++++++- gdb/testsuite/gdb.python/py-events.py | 1 + so I think it has to be re-approved. There is no regression on x86_64 against the up-to-date GIT tree and the generated PDF looks as expected. Thanks, Kevin (I can't build the CVS tree because of missing ".deps/*.Po" files from GDB/binutils, don't know where the problem comes from) 2011-09-20 Kevin Pouget PR python/12691: Add the inferior to Python exited event * python/py-exitedevent.c (create_exited_event_object): Add inferior to exited_event. * python/py-event.h (emit_exited_event): Likewise * python/-inferior.c (python_inferior_exit): Likewise 2011-09-01 Kevin Pouget PR python/12691: Add the inferior to Python exited event * gdb.python/py-events.exp: Test the inferior attribute of exited event with a fork. * gdb.python/py-events.py: Print inferior number on exit. * gdb.python/py-events.c: Fork the inferior. 2011-09-01 Kevin Pouget PR python/12691: Add the inferior to Python exited event * gdb.texinfo (Events In Python): Describe exited inferior attribute. --e0cb4e8878e3202abd04ad48a261 Content-Type: text/x-patch; charset=US-ASCII; name="0001-PR-12691-Add-the-inferior-to-Python-exited-event.patch" Content-Disposition: attachment; filename="0001-PR-12691-Add-the-inferior-to-Python-exited-event.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gsraru1m0 Content-length: 7634 RnJvbSBlM2E1NTU4MTA1NTMwYmEwYzk1YWUwZjVhZjFjOThiYzZmMDRlMDhh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZXZpbiBQb3VnZXQg PGtldmluLnBvdWdldEBzdC5jb20+CkRhdGU6IE1vbiwgMTkgU2VwIDIwMTEg MTE6MzE6MDIgKzAyMDAKU3ViamVjdDogW1BBVENIXSBQUi8xMjY5MSBBZGQg dGhlIGluZmVyaW9yIHRvIFB5dGhvbiBleGl0ZWQgZXZlbnQKCi0tLQogZ2Ri L2RvYy9nZGIudGV4aW5mbyAgICAgICAgICAgICAgICAgICAgfCAgIDEyICsr KysrKysrLS0tLQogZ2RiL3B5dGhvbi9weS1ldmVudC5oICAgICAgICAgICAg ICAgICAgfCAgICAyICstCiBnZGIvcHl0aG9uL3B5LWV4aXRlZGV2ZW50LmMg ICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKy0tLQogZ2RiL3B5dGhvbi9w eS1pbmZlcmlvci5jICAgICAgICAgICAgICAgfCAgICAyICstCiBnZGIvdGVz dHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRzLmMgICB8ICAgIDEgKwogZ2Ri L3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LWV2ZW50cy5leHAgfCAgIDExICsr KysrKysrKystCiBnZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRz LnB5ICB8ICAgIDEgKwogNyBmaWxlcyBjaGFuZ2VkLCAzMiBpbnNlcnRpb25z KCspLCAxMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nZGIvZG9jL2dk Yi50ZXhpbmZvIGIvZ2RiL2RvYy9nZGIudGV4aW5mbwppbmRleCAwNTEzNzdk Li5lNTVlZmIxIDEwMDY0NAotLS0gYS9nZGIvZG9jL2dkYi50ZXhpbmZvCisr KyBiL2dkYi9kb2MvZ2RiLnRleGluZm8KQEAgLTIyMjg5LDEyICsyMjI4OSwx NiBAQCBpbmhlcml0ZWQgYXR0cmlidXRlIHJlZmVyIHRvIEBjb2Rle2dkYi5U aHJlYWRFdmVudH0gYWJvdmUuCiAKIEBpdGVtIGV2ZW50cy5leGl0ZWQKIEVt aXRzIEBjb2Rle2V2ZW50cy5FeGl0ZWRFdmVudH0gd2hpY2ggaW5kaWNhdGVz IHRoYXQgdGhlIGluZmVyaW9yIGhhcyBleGl0ZWQuCi1AY29kZXtldmVudHMu RXhpdGVkRXZlbnR9IGhhcyBvbmUgb3B0aW9uYWwgYXR0cmlidXRlLiAgVGhp cyBhdHRyaWJ1dGUKLXdpbGwgZXhpc3Qgb25seSBpbiB0aGUgY2FzZSB0aGF0 IHRoZSBpbmZlcmlvciBleGl0ZWQgd2l0aCBzb21lCi1zdGF0dXMuCitAY29k ZXtldmVudHMuRXhpdGVkRXZlbnR9IGhhcyB0d28gYXR0cmlidXRlczoKIEB0 YWJsZSBAY29kZQogQGRlZnZhciBFeGl0ZWRFdmVudC5leGl0X2NvZGUKLUFu IGludGVnZXIgcmVwcmVzZW50aW5nIHRoZSBleGl0IGNvZGUgd2hpY2ggdGhl IGluZmVyaW9yIGhhcyByZXR1cm5lZC4KK0FuIGludGVnZXIgcmVwcmVzZW50 aW5nIHRoZSBleGl0IGNvZGUsIGlmIGF2YWlsYWJsZSwgd2hpY2ggdGhlIGlu ZmVyaW9yIAoraGFzIHJldHVybmVkLiAgKFRoZSBleGl0IGNvZGUgY291bGQg YmUgdW5hdmFpbGFibGUgaWYsIGZvciBleGFtcGxlLAorQHZhbHVle0dEQk59 IGRldGFjaGVzIGZyb20gdGhlIGluZmVyaW9yLikgSWYgdGhlIGV4aXQgY29k ZSBpcyB1bmF2YWlsYWJsZSwKK3RoZSBhdHRyaWJ1dGUgZG9lcyBub3QgZXhp c3QuCitAZW5kIGRlZnZhcgorQGRlZnZhciBFeGl0ZWRFdmVudCBpbmZlcmlv cgorQSByZWZlcmVuY2UgdG8gdGhlIGluZmVyaW9yIHdoaWNoIHRyaWdnZXJl ZCB0aGUgQGNvZGV7ZXhpdGVkfSBldmVudC4KIEBlbmQgZGVmdmFyCiBAZW5k IHRhYmxlCiAKZGlmZiAtLWdpdCBhL2dkYi9weXRob24vcHktZXZlbnQuaCBi L2dkYi9weXRob24vcHktZXZlbnQuaAppbmRleCBmNGIzZWUyLi40OWQ3YjZh IDEwMDY0NAotLS0gYS9nZGIvcHl0aG9uL3B5LWV2ZW50LmgKKysrIGIvZ2Ri L3B5dGhvbi9weS1ldmVudC5oCkBAIC0xMDQsNyArMTA0LDcgQEAgdHlwZWRl ZiBzdHJ1Y3QKIH0gZXZlbnRfb2JqZWN0OwogCiBleHRlcm4gaW50IGVtaXRf Y29udGludWVfZXZlbnQgKHB0aWRfdCBwdGlkKTsKLWV4dGVybiBpbnQgZW1p dF9leGl0ZWRfZXZlbnQgKGNvbnN0IExPTkdFU1QgKmV4aXRfY29kZSk7Citl eHRlcm4gaW50IGVtaXRfZXhpdGVkX2V2ZW50IChjb25zdCBMT05HRVNUICpl eGl0X2NvZGUsIHN0cnVjdCBpbmZlcmlvciAqaW5mKTsKIAogZXh0ZXJuIGlu dCBldnB5X2VtaXRfZXZlbnQgKFB5T2JqZWN0ICpldmVudCwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBldmVudHJlZ2lzdHJ5X29iamVjdCAqcmVn aXN0cnkpOwpkaWZmIC0tZ2l0IGEvZ2RiL3B5dGhvbi9weS1leGl0ZWRldmVu dC5jIGIvZ2RiL3B5dGhvbi9weS1leGl0ZWRldmVudC5jCmluZGV4IDA4MTUw ZTUuLjg1ZWEyZTIgMTAwNjQ0Ci0tLSBhL2dkYi9weXRob24vcHktZXhpdGVk ZXZlbnQuYworKysgYi9nZGIvcHl0aG9uL3B5LWV4aXRlZGV2ZW50LmMKQEAg LTIyLDkgKzIyLDEwIEBACiBzdGF0aWMgUHlUeXBlT2JqZWN0IGV4aXRlZF9l dmVudF9vYmplY3RfdHlwZTsKIAogc3RhdGljIFB5T2JqZWN0ICoKLWNyZWF0 ZV9leGl0ZWRfZXZlbnRfb2JqZWN0IChjb25zdCBMT05HRVNUICpleGl0X2Nv ZGUpCitjcmVhdGVfZXhpdGVkX2V2ZW50X29iamVjdCAoY29uc3QgTE9OR0VT VCAqZXhpdF9jb2RlLCBzdHJ1Y3QgaW5mZXJpb3IgKmluZikKIHsKICAgUHlP YmplY3QgKmV4aXRlZF9ldmVudDsKKyAgUHlPYmplY3QgKmluZl9vYmo7CiAK ICAgZXhpdGVkX2V2ZW50ID0gY3JlYXRlX2V2ZW50X29iamVjdCAoJmV4aXRl ZF9ldmVudF9vYmplY3RfdHlwZSk7CiAKQEAgLTM3LDYgKzM4LDEyIEBAIGNy ZWF0ZV9leGl0ZWRfZXZlbnRfb2JqZWN0IChjb25zdCBMT05HRVNUICpleGl0 X2NvZGUpCiAJCQkgICAgIFB5TG9uZ19Gcm9tTG9uZ0xvbmcgKCpleGl0X2Nv ZGUpKSA8IDApCiAgICAgZ290byBmYWlsOwogCisgIGluZl9vYmogPSBpbmZl cmlvcl90b19pbmZlcmlvcl9vYmplY3QgKGluZik7CisgIGlmICghaW5mX29i aiB8fCBldnB5X2FkZF9hdHRyaWJ1dGUgKGV4aXRlZF9ldmVudCwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImluZmVyaW9yIiwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW5mX29i aikgPCAwKQorICAgIGdvdG8gZmFpbDsKKwogICByZXR1cm4gZXhpdGVkX2V2 ZW50OwogCiAgIGZhaWw6CkBAIC00OCwxNCArNTUsMTQgQEAgY3JlYXRlX2V4 aXRlZF9ldmVudF9vYmplY3QgKGNvbnN0IExPTkdFU1QgKmV4aXRfY29kZSkK ICAgIHdpbGwgY3JlYXRlIGEgbmV3IFB5dGhvbiBleGl0ZWQgZXZlbnQgb2Jq ZWN0LiAgKi8KIAogaW50Ci1lbWl0X2V4aXRlZF9ldmVudCAoY29uc3QgTE9O R0VTVCAqZXhpdF9jb2RlKQorZW1pdF9leGl0ZWRfZXZlbnQgKGNvbnN0IExP TkdFU1QgKmV4aXRfY29kZSwgc3RydWN0IGluZmVyaW9yICppbmYpCiB7CiAg IFB5T2JqZWN0ICpldmVudDsKIAogICBpZiAoZXZyZWdweV9ub19saXN0ZW5l cnNfcCAoZ2RiX3B5X2V2ZW50cy5leGl0ZWQpKQogICAgIHJldHVybiAwOwog Ci0gIGV2ZW50ID0gY3JlYXRlX2V4aXRlZF9ldmVudF9vYmplY3QgKGV4aXRf Y29kZSk7CisgIGV2ZW50ID0gY3JlYXRlX2V4aXRlZF9ldmVudF9vYmplY3Qg KGV4aXRfY29kZSwgaW5mKTsKIAogICBpZiAoZXZlbnQpCiAgICAgcmV0dXJu IGV2cHlfZW1pdF9ldmVudCAoZXZlbnQsIGdkYl9weV9ldmVudHMuZXhpdGVk KTsKZGlmZiAtLWdpdCBhL2dkYi9weXRob24vcHktaW5mZXJpb3IuYyBiL2dk Yi9weXRob24vcHktaW5mZXJpb3IuYwppbmRleCA4ZWQzZWE1Li4yNzVjYWVh IDEwMDY0NAotLS0gYS9nZGIvcHl0aG9uL3B5LWluZmVyaW9yLmMKKysrIGIv Z2RiL3B5dGhvbi9weS1pbmZlcmlvci5jCkBAIC0xMTksNyArMTE5LDcgQEAg cHl0aG9uX2luZmVyaW9yX2V4aXQgKHN0cnVjdCBpbmZlcmlvciAqaW5mKQog ICBpZiAoaW5mLT5oYXNfZXhpdF9jb2RlKQogICAgIGV4aXRfY29kZSA9ICZp bmYtPmV4aXRfY29kZTsKIAotICBpZiAoZW1pdF9leGl0ZWRfZXZlbnQgKGV4 aXRfY29kZSkgPCAwKQorICBpZiAoZW1pdF9leGl0ZWRfZXZlbnQgKGV4aXRf Y29kZSwgaW5mKSA8IDApCiAgICAgZ2RicHlfcHJpbnRfc3RhY2sgKCk7CiAK ICAgZG9fY2xlYW51cHMgKGNsZWFudXApOwpkaWZmIC0tZ2l0IGEvZ2RiL3Rl c3RzdWl0ZS9nZGIucHl0aG9uL3B5LWV2ZW50cy5jIGIvZ2RiL3Rlc3RzdWl0 ZS9nZGIucHl0aG9uL3B5LWV2ZW50cy5jCmluZGV4IGNlYjY5N2UuLjY2NWNh NTEgMTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1l dmVudHMuYworKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHktZXZl bnRzLmMKQEAgLTE3LDYgKzE3LDcgQEAKICovCiAKIGludCBzZWNvbmQoKXsK KyAgZm9yaygpIDsKICAgcmV0dXJuIDEyOwogfQogCmRpZmYgLS1naXQgYS9n ZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHktZXZlbnRzLmV4cCBiL2dkYi90 ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1ldmVudHMuZXhwCmluZGV4IDJkMjEz OWQuLjE4NDE5ZmEgMTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvZ2RiLnB5 dGhvbi9weS1ldmVudHMuZXhwCisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5 dGhvbi9weS1ldmVudHMuZXhwCkBAIC0zNyw2ICszNyw4IEBAIGlmICFbcnVu dG9fbWFpbiBdIHRoZW4gewogICAgIHJldHVybiAtMQogfQogCitnZGJfdGVz dF9ub19vdXRwdXQgInNldCBkZXRhY2gtb24tZm9yayBvZmYiICIiCisKIGdk Yl90ZXN0ICJUZXN0X0V2ZW50cyIgIkV2ZW50IHRlc3RlcnMgcmVnaXN0ZXJl ZC4iCiAKIGdkYl9icmVha3BvaW50ICJmaXJzdCIKQEAgLTU0LDQgKzU2LDEx IEBAIGFsbCB0aHJlYWRzIHN0b3BwZWQiCiAjdGVzdCBleGl0ZWQgZXZlbnQu CiBnZGJfdGVzdCAiY29udGludWUiICIuKmV2ZW50IHR5cGU6IGNvbnRpbnVl LioKIC4qZXZlbnQgdHlwZTogZXhpdC4qCi0uKmV4aXQgY29kZTogMTIuKiIK Ky4qZXhpdCBjb2RlOiAxMi4qCisuKmV4aXQgaW5mOiAxLioiICJJbmZlcmlv ciAxIHRlcm1pbmF0ZWQuIgorCitnZGJfdGVzdCAiaW5mZXJpb3IgMiIgIi4q U3dpdGNoaW5nIHRvIGluZmVyaW9yIDIuKiIKK2dkYl90ZXN0ICJjb250aW51 ZSIgIi4qZXZlbnQgdHlwZTogY29udGludWUuKgorLipldmVudCB0eXBlOiBl eGl0LioKKy4qZXhpdCBjb2RlOiAxMi4qCisuKmV4aXQgaW5mOiAyLioiICJJ bmZlcmlvciAyIHRlcm1pbmF0ZWQuIgpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3Rz dWl0ZS9nZGIucHl0aG9uL3B5LWV2ZW50cy5weSBiL2dkYi90ZXN0c3VpdGUv Z2RiLnB5dGhvbi9weS1ldmVudHMucHkKaW5kZXggMTBhZWE0Zi4uNmJkZDkz NSAxMDA2NDQKLS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LWV2 ZW50cy5weQorKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHktZXZl bnRzLnB5CkBAIC00Myw2ICs0Myw3IEBAIGRlZiBleGl0X2hhbmRsZXIgKGV2 ZW50KToKICAgICBpZiAoaXNpbnN0YW5jZSAoZXZlbnQsIGdkYi5FeGl0ZWRF dmVudCkpOgogICAgICAgICBwcmludCAiZXZlbnQgdHlwZTogZXhpdCIKICAg ICBwcmludCAiZXhpdCBjb2RlOiAlZCIgJSAoZXZlbnQuZXhpdF9jb2RlKQor ICAgIHByaW50ICJleGl0IGluZjogJWQiICUgKGV2ZW50LmluZmVyaW9yLm51 bSkKIAogZGVmIGNvbnRpbnVlX2hhbmRsZXIgKGV2ZW50KToKICAgICBpZiAo aXNpbnN0YW5jZSAoZXZlbnQsIGdkYi5Db250aW51ZUV2ZW50KSk6Ci0tIAox LjcuNgoK --e0cb4e8878e3202abd04ad48a261--