From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25444 invoked by alias); 27 Oct 2011 11:10:16 -0000 Received: (qmail 25433 invoked by uid 22791); 27 Oct 2011 11:10:15 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Oct 2011 11:09:57 +0000 Received: by vcbfk1 with SMTP id fk1so2877327vcb.0 for ; Thu, 27 Oct 2011 04:09:56 -0700 (PDT) Received: by 10.220.108.84 with SMTP id e20mr984791vcp.3.1319713790847; Thu, 27 Oct 2011 04:09:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.180.75 with HTTP; Thu, 27 Oct 2011 04:09:19 -0700 (PDT) In-Reply-To: References: <201110141600.20561.pedro@codesourcery.com> <8339eie2ij.fsf@gnu.org> From: Kevin Pouget Date: Thu, 27 Oct 2011 12:11:00 -0000 Message-ID: Subject: Re: [RFC][Python] gdbpy_frame_stop_reason_string bug To: Eli Zaretskii Cc: pedro@codesourcery.com, pmuldoon@redhat.com, gdb-patches@sourceware.org, tromey@redhat.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00725.txt.bz2 On Wed, Oct 19, 2011 at 10:59 PM, Tom Tromey wrote: > ... > The code bits are fine with one nit fixed. > > Kevin> +#include "../unwind_stop_reasons.def" > > I don't think you need ".." here. > > Thanks for doing this. On Thu, Oct 27, 2011 at 12:02 PM, Eli Zaretskii wrote: >> From: Kevin Pouget >> Date: Thu, 27 Oct 2011 11:40:50 +0200 >> Cc: pedro@codesourcery.com, pmuldoon@redhat.com, gdb-patches@sourceware.= org, >> =A0 =A0 =A0 tromey@redhat.com >> >> is it your last word for not mentioning the current value of the alias? > > I prefer not to mention that, yes. =A0But if you feel strongly about it, > I won't fight you. Not a strong feeling, so I committed the patch without it: http://sourceware.org/ml/gdb-cvs/2011-10/msg00195.html Thanks, Kevin