From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31407 invoked by alias); 15 Sep 2011 12:20:14 -0000 Received: (qmail 31396 invoked by uid 22791); 15 Sep 2011 12:20:12 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-vw0-f43.google.com (HELO mail-vw0-f43.google.com) (209.85.212.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Sep 2011 12:19:55 +0000 Received: by vws10 with SMTP id 10so4144129vws.30 for ; Thu, 15 Sep 2011 05:19:54 -0700 (PDT) Received: by 10.52.176.169 with SMTP id cj9mr172628vdc.117.1316089194151; Thu, 15 Sep 2011 05:19:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.178.11 with HTTP; Thu, 15 Sep 2011 05:19:33 -0700 (PDT) In-Reply-To: <201109051256.24817.pedro@codesourcery.com> References: <201109051256.24817.pedro@codesourcery.com> From: Kevin Pouget Date: Thu, 15 Sep 2011 12:31:00 -0000 Message-ID: Subject: Re: [PATCH] Remove same-pc breakpoint notification for internal BPs To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=bcaec5186a92e8ff7404acf9e496 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00266.txt.bz2 --bcaec5186a92e8ff7404acf9e496 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1786 On Mon, Sep 5, 2011 at 1:56 PM, Pedro Alves wrote: > On Wednesday 31 August 2011 14:18:00, Kevin Pouget wrote: >> On Wed, Apr 27, 2011 at 3:02 PM, Kevin Pouget w= rote: >> > Hello, >> > >> > here is an updated version of the patch, which uses `user_breakpoint_p' >> > >> > >> > thanks, >> > >> > Kevin (still waiting for copyright papers) >> >> >> Hello, >> >> this patch was not explicitly approved when I first submitted it, =A0but >> all the concerns were addressed; please let me not if it looks good to >> you > > This is okay, thanks. > > On Wednesday 31 August 2011 14:18:00, Kevin Pouget wrote: >> =A0 =A0ALL_BREAKPOINTS (b) >> - =A0 =A0others +=3D breakpoint_has_pc (b, pspace, pc, section); >> + =A0 =A0others +=3D (breakpoint_has_pc (b, pspace, pc, section) >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 && user_breakpoint_p (b)); >> =A0 =A0if (others > 0) >> =A0 =A0 =A0{ >> =A0 =A0 =A0 =A0if (others =3D=3D 1) >> @@ -5418,7 +5419,7 @@ describe_other_breakpoints (struct gdbarch *gdbarc= h, >> =A0 =A0 =A0 =A0else /* if (others =3D=3D ???) */ >> =A0 =A0 =A0 =A0 printf_filtered (_("Note: breakpoints ")); >> =A0 =A0 =A0 =A0ALL_BREAKPOINTS (b) >> - =A0 =A0 =A0 if (breakpoint_has_pc (b, pspace, pc, section)) >> + =A0 =A0 =A0 if (breakpoint_has_pc (b, pspace, pc, section) && user_bre= akpoint_p (b)) > > > I'd suggest flipping the tests order so the cheaper test is done > first, like: > >> + =A0 =A0others +=3D (user_breakpoint_p (b) >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 && breakpoint_has_pc (b, pspace, pc, secti= on)); > > and > >> + =A0 =A0 =A0 if (user_breakpoint_p (b) && breakpoint_has_pc (b, pspace,= pc, section)) > > Okay with or without that change. > > -- > Pedro Alves > commited with the change you suggested Thanks, Kevin --bcaec5186a92e8ff7404acf9e496 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Remove-same-pc-breakpoint-notification-for-internal-.patch" Content-Disposition: attachment; filename="0001-Remove-same-pc-breakpoint-notification-for-internal-.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gslpj0gx0 Content-length: 1989 RnJvbSA0MjFkMTYyNWY3NjFjNDk4N2Y4MzE1YTI3MmQzYmJmYmZlMTRhNTJl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZXZpbiBQb3VnZXQg PGtldmluLnBvdWdldEBzdC5jb20+CkRhdGU6IFdlZCwgMjAgQXByIDIwMTEg MTU6MzY6NTEgLTA0MDAKU3ViamVjdDogW1BBVENIXSBSZW1vdmUgc2FtZS1w YyBicmVha3BvaW50IG5vdGlmaWNhdGlvbiBmb3IgaW50ZXJuYWwgQlBzCgot LS0KIGdkYi9icmVha3BvaW50LmMgfCAgICA3ICsrKystLS0KIDEgZmlsZXMg Y2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL2dkYi9icmVha3BvaW50LmMgYi9nZGIvYnJlYWtwb2ludC5j CmluZGV4IDIzNTIxOTEuLjM0NzRjYWYgMTAwNjQ0Ci0tLSBhL2dkYi9icmVh a3BvaW50LmMKKysrIGIvZ2RiL2JyZWFrcG9pbnQuYwpAQCAtNTM5Nyw3ICs1 Mzk3LDcgQEAgYnJlYWtwb2ludF9oYXNfcGMgKHN0cnVjdCBicmVha3BvaW50 ICpiLAogICByZXR1cm4gMDsKIH0KIAotLyogUHJpbnQgYSBtZXNzYWdlIGRl c2NyaWJpbmcgYW55IGJyZWFrcG9pbnRzIHNldCBhdCBQQy4gIFRoaXMKKy8q IFByaW50IGEgbWVzc2FnZSBkZXNjcmliaW5nIGFueSB1c2VyLWJyZWFrcG9p bnRzIHNldCBhdCBQQy4gIFRoaXMKICAgIGNvbmNlcm5zIHdpdGggbG9naWNh bCBicmVha3BvaW50cywgc28gd2UgbWF0Y2ggcHJvZ3JhbSBzcGFjZXMsIG5v dAogICAgYWRkcmVzcyBzcGFjZXMuICAqLwogCkBAIC01NDEwLDcgKzU0MTAs OCBAQCBkZXNjcmliZV9vdGhlcl9icmVha3BvaW50cyAoc3RydWN0IGdkYmFy Y2ggKmdkYmFyY2gsCiAgIHN0cnVjdCBicmVha3BvaW50ICpiOwogCiAgIEFM TF9CUkVBS1BPSU5UUyAoYikKLSAgICBvdGhlcnMgKz0gYnJlYWtwb2ludF9o YXNfcGMgKGIsIHBzcGFjZSwgcGMsIHNlY3Rpb24pOworICAgIG90aGVycyAr PSAodXNlcl9icmVha3BvaW50X3AgKGIpCisgICAgICAgICAgICAgICAmJiBi cmVha3BvaW50X2hhc19wYyAoYiwgcHNwYWNlLCBwYywgc2VjdGlvbikpOwog ICBpZiAob3RoZXJzID4gMCkKICAgICB7CiAgICAgICBpZiAob3RoZXJzID09 IDEpCkBAIC01NDE4LDcgKzU0MTksNyBAQCBkZXNjcmliZV9vdGhlcl9icmVh a3BvaW50cyAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gsCiAgICAgICBlbHNl IC8qIGlmIChvdGhlcnMgPT0gPz8/KSAqLwogCXByaW50Zl9maWx0ZXJlZCAo XygiTm90ZTogYnJlYWtwb2ludHMgIikpOwogICAgICAgQUxMX0JSRUFLUE9J TlRTIChiKQotCWlmIChicmVha3BvaW50X2hhc19wYyAoYiwgcHNwYWNlLCBw Yywgc2VjdGlvbikpCisJaWYgKHVzZXJfYnJlYWtwb2ludF9wIChiKSAmJiBi cmVha3BvaW50X2hhc19wYyAoYiwgcHNwYWNlLCBwYywgc2VjdGlvbikpCiAJ ICB7CiAJICAgIG90aGVycy0tOwogCSAgICBwcmludGZfZmlsdGVyZWQgKCIl ZCIsIGItPm51bWJlcik7Ci0tIAoxLjcuNgoK --bcaec5186a92e8ff7404acf9e496--