Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christian Biesinger <cbiesinger@google.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/4] Micro-optimize DWARF partial symbol reading
Date: Wed, 20 May 2020 14:30:52 -0500	[thread overview]
Message-ID: <CAPTJ0XHwj5RqTg=2RsDRR2oeDjgCc+Z71tWRj8Vo1YXNXrV+VA@mail.gmail.com> (raw)
In-Reply-To: <20200520174032.9525-1-tromey@adacore.com>

On Wed, May 20, 2020 at 12:40 PM Tom Tromey <tromey@adacore.com> wrote:
>
> A personal goal of mine is to improve the startup time of gdb.  In the
> long run, I think the answer lies partly with threading, and perhaps
> with a more radical rewrite of the DWARF psymbol reader.  However,
> those are difficult goals; and in the short term, I found that just
> profiling the reader and making small improvements can make a
> difference.
>
> This series improves the performance of the DWARF partial symbol
> reader about 10% (more in one case) on some real-world executables.
> See the first patch for details (I chose to put the details there so
> they would end up in the eventual git log).
>
> Regression tested on x86-64 Fedora 30.
>
> Let me know what you think.

These look good to me, for what it's worth.

Christian


  parent reply	other threads:[~2020-05-20 19:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 17:40 Tom Tromey
2020-05-20 17:40 ` [PATCH 1/4] Attribute method inlining Tom Tromey
2020-05-20 19:40   ` Tom Tromey
2020-05-21  1:08   ` Hannes Domani
2020-05-21 14:26     ` Pedro Alves
2020-05-21 15:03       ` Hannes Domani
2020-05-21 16:42         ` Pedro Alves
2020-05-21 17:18           ` Hannes Domani
2020-05-22 15:47             ` Pedro Alves
2020-05-22 20:28               ` Pedro Alves
2020-05-20 17:40 ` [PATCH 2/4] Lazily compute partial DIE name Tom Tromey
2020-05-20 17:40 ` [PATCH 3/4] Inline abbrev lookup Tom Tromey
2020-05-20 17:40 ` [PATCH 4/4] Use add_partial_symbol in load_partial_dies Tom Tromey
2020-05-20 19:30 ` Christian Biesinger [this message]
2020-05-20 21:08 ` [PATCH 0/4] Micro-optimize DWARF partial symbol reading Simon Marchi
2020-05-27 17:48 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPTJ0XHwj5RqTg=2RsDRR2oeDjgCc+Z71tWRj8Vo1YXNXrV+VA@mail.gmail.com' \
    --to=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox