From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57258 invoked by alias); 24 Jan 2020 14:54:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57247 invoked by uid 89); 24 Jan 2020 14:54:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-29.4 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2045, HX-Spam-Relays-External:209.85.210.67 X-HELO: mail-ot1-f67.google.com Received: from mail-ot1-f67.google.com (HELO mail-ot1-f67.google.com) (209.85.210.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Jan 2020 14:54:10 +0000 Received: by mail-ot1-f67.google.com with SMTP id b18so1864947otp.0 for ; Fri, 24 Jan 2020 06:54:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dalWbuQc0uKxjzDu1JmWHg81V3xVL+TDyvMzio09dAs=; b=LWt/KzXsjsVuVqkMUM8h9uUP9Ir7Pg89vJC4Xuzoeh2Ngwhkbjkx0eYw6DpqjrglgU zRI4VuTRy/BBoraZaDDbid6mrEOYdqWOacOMKlIeV7gUNWAH7Tb/7Ekt0sMxFWig7Yni IYw94oQG3zGKC4Gvy43tSsPuVOp+ZAkTTD/MpYz3MquGRoWQF+ROOys3OCfj+WZRn4Wc 2+Z9DrmGUoithpa1Ig5djO/L6gg3WcYRNlaKxwpaMYV/y7KXCvlyouSmfzCvfVevsRZR Ny+zuE9R24NwskyYCLDD2uRvD/yOAi33YXIlI/XiQFWh3LAo8oNCzczYJblz010PRety DSDg== MIME-Version: 1.0 References: <20200124141458.171392-3-cbiesinger@chromium.org> <20200124141818.172490-1-cbiesinger@chromium.org> <2afe5687-5be2-7650-d4e3-3aceed3f68f2@gmx.com> In-Reply-To: <2afe5687-5be2-7650-d4e3-3aceed3f68f2@gmx.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Fri, 24 Jan 2020 14:58:00 -0000 Message-ID: Subject: Re: [PATCH 2/3 v2] Define _KMEMUSER in arm-nbsd-nat.c To: Kamil Rytarowski Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00796.txt.bz2 Hi Kamil, I have a related question. NetBSD applied this patch: https://www.mail-archive.com/tech@openbsd.org/msg44100.html Do you know which NetBSD version that shipped in? Can we apply that patch to GDB as-is or should we attempt to support the older struct layout as well? Thanks, Christian On Fri, Jan 24, 2020 at 3:29 PM Kamil Rytarowski wrote: > > On 24.01.2020 15:18, cbiesinger@chromium.org wrote: > > From: Christian Biesinger > > > > Fixes the below compile error on ARM NetBSD 9.0_RC1 (the only version I > > tested). types.h does not define register_t by default. > > > > We already use this define elsewhere, notably in bsd-kvm.c. > > > > In file included from ../../gdb/arm-nbsd-nat.c:28: > > /usr/include/machine/frame.h:54:2: error: unknown type name 'register_t'; did you mean '__register_t'? > > register_t tf_spsr; > > ^ > > /usr/include/machine/types.h:77:14: note: '__register_t' declared here > > typedef int __register_t; > > ^ > > > > There are other compile errors that this does not fix. > > > > gdb/ChangeLog: > > > > 2020-01-24 Christian Biesinger > > > > * arm-nbsd-nat.c: Define _KMEMUSER to get the declaration of > > register_t. > > > > Change-Id: I82c21d38189ee59ea0af2538ba84b771d268722e > > --- > > gdb/arm-nbsd-nat.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/gdb/arm-nbsd-nat.c b/gdb/arm-nbsd-nat.c > > index 00f919194b..4844b51a3c 100644 > > --- a/gdb/arm-nbsd-nat.c > > +++ b/gdb/arm-nbsd-nat.c > > @@ -17,6 +17,8 @@ > > You should have received a copy of the GNU General Public License > > along with this program. If not, see . */ > > > > +/* We define this to get types like register_t. */ > > +#define _KMEMUSER > > #include "defs.h" > > #include "gdbcore.h" > > #include "inferior.h" > > > > While gdb is the right user for _KMEMUSER, here we should probably go > for -D_KERNTYPES as it is the canonical symbol for register_t. >