From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by sourceware.org (Postfix) with ESMTPS id 78EE33857C62 for ; Mon, 14 Sep 2020 16:25:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 78EE33857C62 Received: by mail-qt1-x842.google.com with SMTP id y11so337042qtn.9 for ; Mon, 14 Sep 2020 09:25:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ALPO9WnfERB8K2vYjadtPqLZyESI1tDK9oaCyhmFp+c=; b=YHJ0ph17iTlLFgRclWxRSBmZaSUN+xi/wjj2tZ3DACSqKanuPqhrhDUO/PgyY0Z6Z7 +5rtBU62iHBH30a0tHIFiJGWTFyBO1OipE6zcOxvFGfT4bUIqsRdUJ63Lc+tPTJpLAmn 2G2OV3Yg23E4c672riLlexIEmFanOVYQtdt9ZQHyvPrWOzQfcsjspoa+A6DkMaB8f8Eo N3q5HMc7CUBgVXrqsQQ8xXBJ9+CQiK9fBPYByNlWofGXqBinRDOOrEa+E609TLnNdu1P RiEtUCb3MydQS3e4JWlh7NE/GND1KOOnCW/OgdJS5baLDtYav7LMk85kSIez1IkTW2hX OUDg== X-Gm-Message-State: AOAM532oWccoMePvXLqVRWwjTTC9ImhId8INkL7HLE0vAxoaJIjlKnN1 xxQqEtw3akA+3K5pAB7Kg6V1UHxddkVaUwOXMJ/ktg== X-Google-Smtp-Source: ABdhPJz2vRaO5KhwIWnVQbtQ9xZfylSabFcakMhiuOs+KYyooLYK9TwZKExQa7J1V5BfdMZQ0rXTJysPFQuMkoHeajY= X-Received: by 2002:ac8:581:: with SMTP id a1mr1538466qth.161.1600100746831; Mon, 14 Sep 2020 09:25:46 -0700 (PDT) MIME-Version: 1.0 References: <7174ea3f-ea3d-dad9-ab63-df7586ae0f9e@polymtl.ca> In-Reply-To: <7174ea3f-ea3d-dad9-ab63-df7586ae0f9e@polymtl.ca> From: Christian Biesinger Date: Mon, 14 Sep 2020 18:25:09 +0200 Message-ID: Subject: Re: [PATCH] gdb, gdbserver, gdbsupport: fix leading space vs tabs issues To: Simon Marchi Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.3 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2020 16:25:48 -0000 On Mon, Sep 14, 2020 at 6:13 PM Simon Marchi via Gdb-patches wrote: > > Many spots incorrectly use only spaces for indentation (for example, > there are a lot of spots in ada-lang.c). I've always found it awkward > when I needed to edit one of these spots: do I keep the original wrong > indentation, or do I fix it? What if the lines around it are also > wrong, do I fix them too? I probably don't want to fix them in the same > patch, to avoid adding noise to my patch. > > So I propose to fix as much as possible once and for all (hopefully). > > One typical counter argument for this is that it makes code archeology > more difficult, because git-blame will show this commit as the last > change for these lines. For what it's worth, git blame offers a -w switch to ignore whitespace changes. Christian