Re: [PATCH 4/7] jit: make gdb_symtab::blocks a vector

Christian Biesinger via gdb-patches
2019-12-13T18:17:17Z

On Fri, Dec 13, 2019, 11:14 Simon Marchi <simon.marchi@polymtl.ca> wrote:

> On 2019-12-13 11:08 a.m., Christian Biesinger via gdb-patches wrote:
> > I personally prefer this one. And maybe add a comment that the block that
> > encloses the other one should come first?
>
> The order in which blocks appear in a blockvector is already explained in
> the comment on
> top of struct block, in block.h, so I didn't want to duplicate it. But I
> can certainly
> point to it explicitly in the comment above the std::sort call:
>
> /* Sort the blocks in the order they should appear in the blockvector.
>
> See the comment on top of struct block, in block.h, for more
> details. */
>
> Does that sound good?
>

Sounds good to me!

>