From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hgSaK5uL/F/rIAAAWB0awg (envelope-from ) for ; Mon, 11 Jan 2021 12:32:11 -0500 Received: by simark.ca (Postfix, from userid 112) id A272E1EEEF; Mon, 11 Jan 2021 12:32:11 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 544BD1E940 for ; Mon, 11 Jan 2021 12:32:11 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9B77F386102D; Mon, 11 Jan 2021 17:32:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9B77F386102D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610386330; bh=9h8JUxEgQdCLJR9ZoyaDfGC8rVnYDluc+LZ3+z3FyMg=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=W7K5+8bLZdbb5sOuO1GpdPcvr4/n08AuHGD8L6xXDIUQcY+yPgAz2N/gedyo4NQ2G 70Jt46PW/deSfYzc6wURxbsAasB3/AevSswznlfzkSKkiiwOODIaWrGdY+Y1HnCvPT q3gvOYHqxta2XZFXjotahQmxqk0NKcRppY9nj88U= Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by sourceware.org (Postfix) with ESMTPS id 60C073860C3E for ; Mon, 11 Jan 2021 17:32:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 60C073860C3E Received: by mail-qt1-x82d.google.com with SMTP id y15so259421qtv.5 for ; Mon, 11 Jan 2021 09:32:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9h8JUxEgQdCLJR9ZoyaDfGC8rVnYDluc+LZ3+z3FyMg=; b=NgvwrzWujMGExxpboXhkESA4Dfpoft0I/ug8o8kJxI2/cw/yaU84Z4UIKu4nxgwME/ pTJwK70nE+i+wutgRosK4meTpyMAJxP7aWvo3LrZVOZD0g6hyPJXV7DD7FP+N9kqxxn+ 33WOIb/3mm6DsvdlZEm6DaDxgZJyi0d9FPirluVYD5EQrHj7b/4T1BKyLRu5+tdEdo9p 7DAX7BLHhgDBuXipsDGwpRUChfWhCHJXqArYTRI+PXVZUyQBT0R/ubgOZCU8xzM6seOs grqC0S0FHY/wWqOXy6/rfKl6j3IFOfHhTu2nceT4z/uSH5MmZ7mRniVS06v4FpORyoks LNGA== X-Gm-Message-State: AOAM532tK4YdGW4QZKTdakXLdqsXSflj2OEoUEtk+H7BsaL808fyRzxy EZ/VGQF6EqQ/CSu5nfNK0ycfxJ5iRjOX3xCHR3+D/w== X-Google-Smtp-Source: ABdhPJyDv+p/41yIkPS3iL6YvXiKXIiXRexYdUG8Vb0gST1UFMilHhYjQrk/vz2VnK8P9wHDDI7tzFi6QIa1/XXNSGo= X-Received: by 2002:ac8:7c8e:: with SMTP id y14mr618228qtv.161.1610386326812; Mon, 11 Jan 2021 09:32:06 -0800 (PST) MIME-Version: 1.0 References: <20210110033752.6002-1-vapier@gentoo.org> <20210110034223.6268-1-vapier@gentoo.org> <20210111110544.GC1151657@embecosm.com> <313988fb-ed42-11f7-1e64-b46005580792@polymtl.ca> <02170881-4ce0-da14-a08b-da1264a3b971@linaro.org> In-Reply-To: <02170881-4ce0-da14-a08b-da1264a3b971@linaro.org> Date: Mon, 11 Jan 2021 18:31:29 +0100 Message-ID: Subject: Re: [PATCH] sim: switch to autogenerated ChangeLog files To: Luis Machado Content-Type: text/plain; charset="UTF-8" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Christian Biesinger via Gdb-patches Reply-To: Christian Biesinger Cc: gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Mon, Jan 11, 2021 at 6:10 PM Luis Machado via Gdb-patches wrote: > > On 1/11/21 2:00 PM, Simon Marchi via Gdb-patches wrote: > > On 2021-01-11 6:05 a.m., Andrew Burgess wrote: > >> I think sim/ should follow the same policy as gdb/ for now. Do feel > >> free to raise this as a suggestion for gdb/ in general though, it > >> would be an interesting conversation to observe. > > > > Last time I tried the gitlog-to-changelog script on GDB, it produced > > horrible results. Probably because it was not designed for C++. > > > > Making a script to produce ChangeLogs for C code is already very > > difficult, making it work with good results for C++ would be even > > worst. And most importantly, I think it would be wasted development > > time. > > > > My opinion is that we should either keep hand-written ChangeLogs, or > > admit that ChangeLogs are not useful and get rid of them altogether > > (and you know which side I lean towards). But auto-generating > > ChangeLogs, other than allowing to check the "we have ChangeLog" box, > > doesn't produce anything useful. > > Ever since we moved binutils-gdb to git, ChangeLog's started to feel > like a waste of time. Now, with broader use of C++, it is even worse. It > makes things more verbose and harder for tools to find the right scope > (is the change in a function? A class? A member function?). And the > limit of 80 columns adds to that burden, since we need to watch out for > the length of the line. It feels like a puzzle sometimes. > > "git log" produces very useful information, and we make the commit > messages very verbose (more than other projects) so developers can have > a pretty good idea of what has changed and why. > > I'm strongly in favor of dropping ChangeLog's from GDB. I would love this as well. There was some discussion almost a year ago in a thread titled "Using the vcs_to_changelog.py script" (https://sourceware.org/pipermail/gdb-patches/2020-February/165728.html) Christian