From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4DS3Cw4RgGFnbgAAWB0awg (envelope-from ) for ; Mon, 01 Nov 2021 12:08:46 -0400 Received: by simark.ca (Postfix, from userid 112) id 2C2E61F0BB; Mon, 1 Nov 2021 12:08:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5AA601EE14 for ; Mon, 1 Nov 2021 12:08:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EA02D385803B for ; Mon, 1 Nov 2021 16:08:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EA02D385803B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1635782925; bh=08qyev1HamBjqWkEEyEzJhXgjc1zh+6UDpU4jLeuddY=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=joIgcuaX05JQoA8FqfySFc60QabgkzUGTuQzgxvDHkvvw8Pd+L6bDR0kXlLhqZkPf lAXTrg7ryiINV8FYGJKNFcDKqwN3Q+PSUi10X9m6OLKIOH720CMlKIM+BoQ78JVUuK pXw1xKfgrRq55OPRGPVtUAvj++anDC0fJZy5amvI= Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by sourceware.org (Postfix) with ESMTPS id B787B3858432 for ; Mon, 1 Nov 2021 16:08:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B787B3858432 Received: by mail-qt1-x82e.google.com with SMTP id f1so16255374qto.9 for ; Mon, 01 Nov 2021 09:08:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=08qyev1HamBjqWkEEyEzJhXgjc1zh+6UDpU4jLeuddY=; b=avuna8Tvh0V1VfpboES1rYo0pjnfDiZhpupH7nz5GVVYt3RHffe7KgMn0rfNAkhv0h CVl21k8Ih7kN/oFgu02v7x2EbhKnQFAM3XVXMs/odQy4AuCfn5FKEa3kNCyFMlNYIJmf gtQl2h28R8lyEgVgl0WCFiJJo3aYerUXfeRj7ucbeb3CI/BXgP6shP6xG+RaTJBNL9Az jBW04TBRP+vy3sZLV5k4AZFyo02pCMDMIrvy4LqkP2FvWftQ0G7MbWKtd+5NjmmWGANq d26+mrUQ6X2yIJUzFlq4fIdAmwiGMcYukWJGVGKobl4L/3GpmIgDF2a2qOD2XHbYHJZg YK3Q== X-Gm-Message-State: AOAM531iY3ZDoPxKbcU8NsWpBNUkmyw0aW5rz/6vwaulUL+r+CNrSf2F wnWVsQfpUbHQFXRuKMVEuXan6Nlodl9K1AzAzmj4HQ== X-Google-Smtp-Source: ABdhPJyUngql801Zsjo80ktxLbzNpMUTdbxVEF/AMTyGyn+oUjqLDjKh4SJ0UZXWxuzAgXcdybrzBY2NTaAdNSc2zr0= X-Received: by 2002:a05:622a:606:: with SMTP id z6mr32053302qta.253.1635782905127; Mon, 01 Nov 2021 09:08:25 -0700 (PDT) MIME-Version: 1.0 References: <20211101034519.29154-1-vapier@gentoo.org> In-Reply-To: <20211101034519.29154-1-vapier@gentoo.org> Date: Mon, 1 Nov 2021 12:07:48 -0400 Message-ID: Subject: Re: [PATCH] sim: mn10300: clean up pointer casts To: Mike Frysinger Content-Type: text/plain; charset="UTF-8" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Christian Biesinger via Gdb-patches Reply-To: Christian Biesinger Cc: gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Sun, Oct 31, 2021 at 11:45 PM Mike Frysinger via Gdb-patches wrote: > --- a/sim/mn10300/dv-mn103ser.c > +++ b/sim/mn10300/dv-mn103ser.c > @@ -238,7 +238,7 @@ do_polling_event (struct hw *me, > { > SIM_DESC sd = hw_system (me); > struct mn103ser *serial = hw_data(me); > - long serial_reg = (long) data; > + long serial_reg = (uintptr_t) data; Shouldn't you change the variable type too? Otherwise this patch seems to be somewhat pointless? if ( nr_bytes == 1 ) > diff --git a/sim/mn10300/dv-mn103tim.c b/sim/mn10300/dv-mn103tim.c > index ad9c24bbc6e8..76f87380d1d8 100644 > --- a/sim/mn10300/dv-mn103tim.c > +++ b/sim/mn10300/dv-mn103tim.c > @@ -570,7 +570,7 @@ do_counter_event (struct hw *me, > void *data) > { > struct mn103tim *timers = hw_data(me); > - long timer_nr = (long) data; > + long timer_nr = (uintptr_t) data; Here too. > @@ -611,7 +611,7 @@ do_counter6_event (struct hw *me, > void *data) > { > struct mn103tim *timers = hw_data(me); > - long timer_nr = (long) data; > + long timer_nr = (uintptr_t) data; And here. Christian