From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by sourceware.org (Postfix) with ESMTPS id F0EA1385BF81 for ; Wed, 8 Apr 2020 17:29:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F0EA1385BF81 Received: by mail-qk1-x741.google.com with SMTP id v7so1069876qkc.0 for ; Wed, 08 Apr 2020 10:29:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FNg7Cj84IrMo3zQYT4kI1rIqWKA79YdlNhzjyq/ziNY=; b=fGFcEI1OWb14GrO6RIB2rRPBFEQaaD0XqvFC7iEUDBkBRExJ7DpfsaBNqkigYc+mfn z+SuQpbd2p23326/fKM9kYUAjWyV4Jcyh0VQREk9jJhFlchfZGri5O7ZN8ehJHmgARg/ F53fdmMf9fbR8/yhIfP1S2WgUDulqemTJsPam3h1eSIPl56qQb4pY7+YXbseNeqZmOlj Wvl4KshgBsYyuLMMy8bU3Maa7wcdVOI0A+fqSVOPErXF3v5Tvin14b21t+zJ4SCdf13Y fcRzGBQ55qqhGQa6RUfH4mE+YK8P1+dGLKZO3Dl+bE/wKX6RUDRuS8VQL7znbG5UNtrh 0UIg== X-Gm-Message-State: AGi0PuYD2GDKwtcJavJjoE2Tji7k9hDpwaZZr69szv/Lse5t62GsWGid jMdxYFxorCsEVz0TdnR03aaik28v2HIsimgxzWmptg== X-Google-Smtp-Source: APiQypKmB4dixN2xZf5UXPX3Xftii7qaq3DQB0YxDTp1bmfbwWpWEWA8jVYLpTDeubp2pWx5/ZCKy3buiUX3kyLrR8A= X-Received: by 2002:a05:620a:1256:: with SMTP id a22mr8105622qkl.439.1586366967149; Wed, 08 Apr 2020 10:29:27 -0700 (PDT) MIME-Version: 1.0 References: <20200408171543.6061-1-n54@gmx.com> <47fe1112-261b-6d31-3ec4-1cb3ed27ea64@gmx.com> In-Reply-To: <47fe1112-261b-6d31-3ec4-1cb3ed27ea64@gmx.com> From: Christian Biesinger Date: Wed, 8 Apr 2020 12:28:50 -0500 Message-ID: Subject: Re: [PATCH] Tune default DEBUGDIR for NetBSD To: Kamil Rytarowski Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-39.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2020 17:29:30 -0000 On Wed, Apr 8, 2020 at 12:21 PM Kamil Rytarowski wrote: > > On 08.04.2020 19:18, Christian Biesinger wrote: > > On Wed, Apr 8, 2020 at 12:16 PM Kamil Rytarowski wrote: > >> > >> NetBSD uses a custom debug file directory /usr/libdata/debug > >> for the basesystem and does not use separate debug files in > >> pkgsrc (3rd party package collections). > >> > >> gdb/ChangeLog: > >> > >> * configure.ac: Handle NetBSD specific DEBUGDIR. > >> * configure: Regenerate. > >> --- > >> gdb/ChangeLog | 5 +++++ > >> gdb/configure | 11 ++++++++++- > >> gdb/configure.ac | 11 ++++++++++- > >> 3 files changed, 25 insertions(+), 2 deletions(-) > >> > >> diff --git a/gdb/ChangeLog b/gdb/ChangeLog > >> index 7ea85799211..af6844b6ace 100644 > >> --- a/gdb/ChangeLog > >> +++ b/gdb/ChangeLog > >> @@ -1,3 +1,8 @@ > >> +2020-04-08 Kamil Rytarowski > >> + > >> + * configure.ac: Handle NetBSD specific DEBUGDIR. > >> + * configure: Regenerate. > >> + > >> 2020-04-08 Simon Marchi > >> > >> * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile > >> diff --git a/gdb/configure b/gdb/configure > >> index afafc2c8d18..636a3f69f00 100755 > >> --- a/gdb/configure > >> +++ b/gdb/configure > >> @@ -6416,6 +6416,15 @@ if test x"$gdb_cv_have_makeinfo_click" = xyes; then > >> fi > >> > >> > >> +case "${host}" in > >> + *-*-netbsd*) > >> + DEFAULTDEBUGDIR=/usr/libdata/debug > > > > Wouldn't it be better to make this ${prefix}/libdata/debug? > > > > Not really, as this path specifies the userland debug files only. In > third party we don't use separate debug files. The default prefix is > /usr/local and without specifying --prefix=/usr debug files won't work. > > This path is already hardcoded in LLDB for this OS. Oh, I see -- you're saying that GDB will usually be configured with as /usr/local prefix, but is still expected to find system debug data in /usr/libdata/debug. Makes sense. Christian > >> + ;; > >> + *) > >> + DEFAULTDEBUGDIR=${libdir}/debug > >> + ;; > >> +esac > >> + > >> > >> > >> # Check whether --with-separate-debug-dir was given. > >> @@ -6423,7 +6432,7 @@ if test "${with_separate_debug_dir+set}" = set; then : > >> withval=$with_separate_debug_dir; > >> DEBUGDIR=$withval > >> else > >> - DEBUGDIR=${libdir}/debug > >> + DEBUGDIR=${DEFAULTDEBUGDIR} > >> fi > >> > >> > >> diff --git a/gdb/configure.ac b/gdb/configure.ac > >> index b9dbe13232a..3cef95fbcb8 100644 > >> --- a/gdb/configure.ac > >> +++ b/gdb/configure.ac > >> @@ -93,9 +93,18 @@ if test x"$gdb_cv_have_makeinfo_click" = xyes; then > >> fi > >> AC_SUBST(MAKEINFO_EXTRA_FLAGS) > >> > >> +case "${host}" in > >> + *-*-netbsd*) > >> + DEFAULTDEBUGDIR=/usr/libdata/debug > >> + ;; > >> + *) > >> + DEFAULTDEBUGDIR=${libdir}/debug > >> + ;; > >> +esac > >> + > >> GDB_AC_WITH_DIR(DEBUGDIR, separate-debug-dir, > >> [look for global separate debug info in this path @<:@LIBDIR/debug@:>@], > >> - [${libdir}/debug]) > >> + [${DEFAULTDEBUGDIR}]) > >> > >> # We can't pass paths as command line arguments. > >> # Mingw32 tries to be clever and will convert the paths for us. > >> -- > >> 2.25.0 > >> >