From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121021 invoked by alias); 19 Feb 2020 15:16:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120996 invoked by uid 89); 19 Feb 2020 15:16:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-29.5 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=H*c:alternative X-HELO: mail-ot1-f43.google.com Received: from mail-ot1-f43.google.com (HELO mail-ot1-f43.google.com) (209.85.210.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Feb 2020 15:16:41 +0000 Received: by mail-ot1-f43.google.com with SMTP id g64so417151otb.13 for ; Wed, 19 Feb 2020 07:16:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DRNyZOS0/jprhE0GGgEkmg+/W068YBZ+OjY2WMjtAFw=; b=tzTXAsw997KsGrtmSsKYgVcMzv4TIiLELI8b2fm26/sLrZrYOuQY/Olg0tO8Tj5ekr F+TuP9T8Z09ohkSEEDNH5TSG3sDOc6TBeuv/DHqqn/AYjnLr0SSJ7xzNbPtg+QOEqux3 QcYn+dXhWxQxs/NGcXSQAxgXC8f8o52lLadIBApfE7RrDrRhLYTaqnfUKQaQbIztX/2c KaLRNj/XSIzpmpJ0BCc9aOMJce7E35jDD86z+F9TLkG+/a/yAQKUToqfgbIPJkhW8dKi ELZGHwI3HycCxfHyx4SqcZcVlueyUmO1UIFebOZUJrwcGnft+sNwfG9UJYJb8bGNOkOv ku3g== MIME-Version: 1.0 References: <20200219145728.14136-1-tromey@adacore.com> In-Reply-To: <20200219145728.14136-1-tromey@adacore.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Wed, 19 Feb 2020 15:16:00 -0000 Message-ID: Subject: Re: [pushed] Remove useless NULL check in python.c To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00780.txt.bz2 On Wed, Feb 19, 2020, 18:57 Tom Tromey wrote: > I noticed that do_start_initialization, in python.c, checks the result > of xmalloc. However, xmalloc cannot fail, so this check is useless. > This patch also changes the code to use XNEWVEC. > > gdb/ChangeLog > 2020-02-19 Tom Tromey > > * python/python.c (do_start_initialization): Use XNEWVEC. Remove > NULL check. > --- > gdb/ChangeLog | 5 +++++ > gdb/python/python.c | 7 +------ > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/gdb/python/python.c b/gdb/python/python.c > index 27d6042c618..fbbc159ede3 100644 > --- a/gdb/python/python.c > +++ b/gdb/python/python.c > @@ -1679,12 +1679,7 @@ do_start_initialization () > std::string oldloc = setlocale (LC_ALL, NULL); > setlocale (LC_ALL, ""); > progsize = strlen (progname.get ()); > - progname_copy = (wchar_t *) xmalloc ((progsize + 1) * sizeof (wchar_t)); > - if (!progname_copy) > - { > - fprintf (stderr, "out of memory\n"); > - return false; > - } > + progname_copy = XNEWVEC (wchar_t, progsize + 1); > Have you considered using STD::wstring instead of this manual memory management? count = mbstowcs (progname_copy, progname.get (), progsize + 1); if (count == (size_t) -1) > { > -- > 2.21.1 > >