Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christian Biesinger via Gdb-patches <gdb-patches@sourceware.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/3] sim: callback: add a getpid interface
Date: Mon, 21 Jun 2021 17:58:33 -0500	[thread overview]
Message-ID: <CAPTJ0XHiWFcH2okEWo-3JNvDOHTah7gVjD-PUvrUq4fd22n+ZQ@mail.gmail.com> (raw)
In-Reply-To: <20210621035505.29431-1-vapier@gentoo.org>

On Sun, Jun 20, 2021 at 10:55 PM Mike Frysinger via Gdb-patches
<gdb-patches@sourceware.org> wrote:
> --- a/sim/common/callback.c
> +++ b/sim/common/callback.c
> @@ -556,6 +556,17 @@ os_truncate (host_callback *p, const char *file, int64_t len)
>  #endif
>  }
>
> +static int
> +os_getpid (host_callback *p)
> +{
> +  int result;
> +
> +  result = getpid ();

sim is C11, right? Why not write this as "int result = getpid ();"?

Christian

  parent reply	other threads:[~2021-06-21 22:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21  3:55 Mike Frysinger via Gdb-patches
2021-06-21  3:55 ` [PATCH 2/3] sim: callback: generate signal map Mike Frysinger via Gdb-patches
2021-06-21  3:55 ` [PATCH 3/3] sim: callback: add missing cb_target_to_host_signal Mike Frysinger via Gdb-patches
2021-06-21 22:58 ` Christian Biesinger via Gdb-patches [this message]
2021-06-21 23:50   ` [PATCH 1/3] sim: callback: add a getpid interface Mike Frysinger via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPTJ0XHiWFcH2okEWo-3JNvDOHTah7gVjD-PUvrUq4fd22n+ZQ@mail.gmail.com \
    --to=gdb-patches@sourceware.org \
    --cc=cbiesinger@google.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox