From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id PSAiONvfNmDkIwAAWB0awg (envelope-from ) for ; Wed, 24 Feb 2021 18:23:07 -0500 Received: by simark.ca (Postfix, from userid 112) id D8D971EF78; Wed, 24 Feb 2021 18:23:07 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 569301EE0E for ; Wed, 24 Feb 2021 18:23:07 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 99E323857026; Wed, 24 Feb 2021 23:23:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 99E323857026 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1614208986; bh=wVmiU0+N2Coc9SW62ytEdCOv2j8bRVh7Hbp/OT8XSdQ=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DAhu6MbSnDtkKpkhnCp7TxJs9jtff2oLQpuM5IHuzbkLsqngMsoSlTzR3sRIwRCDZ 1jxSjJviuMeRaNs+/B/o84Powzw/XkN5NWBGPRm7jUIPuTzgs+BDNklqVmc8tV7ZD4 t/q2544QH5Vs3gVl/keCwdWBV73AqhyqPAOEQd+c= Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by sourceware.org (Postfix) with ESMTPS id 8F8833857C62 for ; Wed, 24 Feb 2021 23:23:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8F8833857C62 Received: by mail-qk1-x731.google.com with SMTP id f17so4029304qkl.5 for ; Wed, 24 Feb 2021 15:23:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ML1b4zHYW70I1zNIFj1k/K+TzZsjPpUKmKTFAoZ6Cmg=; b=QokCREmpJn5lMZE5QM6Xa0NwKYNEglK8iBAyKXg4qQyeVS20spWxBSt0p0QKdLxgdF 1jpjfRSduV4bDLNWx8m5iu2jPpePdG0dbVK7LlcRb9LgNGmTEK5IAEw4lYDt+pBom39k dJDT+YJAJ9vy4qwWPUnCu6Y3sksP9hbv9+DNZErzAlwvOo6Iye0SBFy0WiJYjCIkwdif EO4KUcqW9RwZmCzTTJajdp1r50KTXtRzSk2Msa2k7VzNnKSRvizG7L6IJ6nZ1lNpqt+Z 2Q7zyQHxd+yH/sv2dYKHcra01D4ZcvF8m2zKo4K/NqcXW2AfCQSIKDgn/p+w2yH2kSiW +gOQ== X-Gm-Message-State: AOAM530jsOMWkG6ybdHUbsgwvBj+/Z4T1BWc78emu+Am/GH+0HiYz3MW W6p229rR425Jj0B0kV4E4VPLKgF97njh3NrR7AYPz1jHkNWS4Q== X-Google-Smtp-Source: ABdhPJwTprpiJiqcRuisTXniQUKcGsqiytQFZjHUDqFv8VUjay+D+4N11uMMEKelfqACqN5QXDrwhOyGQHe3tOXhgqg= X-Received: by 2002:a37:a558:: with SMTP id o85mr342394qke.375.1614208983973; Wed, 24 Feb 2021 15:23:03 -0800 (PST) MIME-Version: 1.0 References: <20210224195945.2135883-1-kevinb@redhat.com> <87ft1lyyrz.fsf@tromey.com> <20210224145223.6052f41d@f33-m1.lan> In-Reply-To: <20210224145223.6052f41d@f33-m1.lan> Date: Thu, 25 Feb 2021 00:22:52 +0100 Message-ID: Subject: Re: [pushed] Fix aarch64-linux-hw-point.c build problem To: Kevin Buettner Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Christian Biesinger via Gdb-patches Reply-To: Christian Biesinger Cc: Tom Tromey , gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Wed, Feb 24, 2021, 22:52 Kevin Buettner via Gdb-patches < gdb-patches@sourceware.org> wrote: > On Wed, 24 Feb 2021 13:52:00 -0700 > Tom Tromey wrote: > > > >>>>> "Kevin" == Kevin Buettner via Gdb-patches < > gdb-patches@sourceware.org> writes: > > > > Kevin> gdb/ChangeLog: > > > > Kevin> * nat/aarch64-linux-hw-point.c: Include > after > > Kevin> . > > > > This seems reasonable, but a comment saying that the order matters might > > be helpful later on. > > Agreed. > > I've pushed the following (along with a suitable ChangeLog entry)... > Since you said nat/aarch64-sve-linux-ptrace.h also includes these headers, maybe add the comment there as well? > diff --git a/gdb/nat/aarch64-linux-hw-point.c > b/gdb/nat/aarch64-linux-hw-point.c > index 0278ac2bb28..af2cc4254e2 100644 > --- a/gdb/nat/aarch64-linux-hw-point.c > +++ b/gdb/nat/aarch64-linux-hw-point.c > @@ -23,8 +23,15 @@ > #include "aarch64-linux-hw-point.h" > > #include > + > +/* The order in which and are included > + can be important. often declares various PTRACE_* > + enums. often defines preprocessor constants for > + these very same symbols. When that's the case, build errors will > + result when is included before . */ > #include > #include > + > #include > > /* Number of hardware breakpoints/watchpoints the target supports. > >