From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cbiesinger@google.com>
Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com
 [IPv6:2607:f8b0:4864:20::744])
 by sourceware.org (Postfix) with ESMTPS id 0B2613895448
 for <gdb-patches@sourceware.org>; Tue, 19 May 2020 17:25:59 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0B2613895448
Received: by mail-qk1-x744.google.com with SMTP id i14so219153qka.10
 for <gdb-patches@sourceware.org>; Tue, 19 May 2020 10:25:59 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=sqALnohSRYtyngBL5dW2Iz5HcdtVtWPwl69v/mhOqDQ=;
 b=bDVtMdoPyOvY61XhGE03GHXc14Iws9Z5xRi91Unv5iOl1sOP0u/gmtIfFBfIEOMHTi
 94blexBu4ZudDEDbDuKCTcG4eNIn5JGi1QFh2hYsH38pNoOU8h9a98THSjf0+OdWXwhx
 1jmp/FP/hN1iny/s2xuot1rqkIPb501Co0KiP/EeHMAFhvs4dd8bruaJmJvmCa+MzWQn
 oNz4wu+cx4nFJCdWVz7re7a+Q4+Z05fw2VPZMmaAulJ4h4OPAUh3EglpwojuvSDptNQm
 02Fx73GxcGsQ/pnxWleqRXaqei5R4wRRPvhcAL5jQA1+UKX87+5IxrCmSpmfALQvRZRg
 vovQ==
X-Gm-Message-State: AOAM530gve7pnpbt6JoYS3D+ump17aMu9ZkfaxELovQ9dZGKPBlOUTI9
 PkNfSa/TuDP/uxxjxEqHjKMhGJdZFAc+z9BT1TU8Dg==
X-Google-Smtp-Source: ABdhPJz9EalD3q2POo9lmScJF4kPo63525ZDCpHTWSkMa+bBlbs309JH11IeNSJ/HaAM1xRYmOTGHKN7UzEpddwoID4=
X-Received: by 2002:a37:acc:: with SMTP id 195mr425639qkk.419.1589909158271;
 Tue, 19 May 2020 10:25:58 -0700 (PDT)
MIME-Version: 1.0
References: <20200519043205.GT1088@bubble.grove.modra.org>
 <111d8c5d-d615-e0ae-36de-519c43a51139@simark.ca>
In-Reply-To: <111d8c5d-d615-e0ae-36de-519c43a51139@simark.ca>
From: Christian Biesinger <cbiesinger@google.com>
Date: Tue, 19 May 2020 12:25:21 -0500
Message-ID: <CAPTJ0XHdSMqdpuHr_-C28WKisaNoBaVy6npJmAEZiXbiDD-kPg@mail.gmail.com>
Subject: Re: PR25993, read of freed memory
To: Simon Marchi <simark@simark.ca>
Cc: Alan Modra <amodra@gmail.com>, binutils@sourceware.org, 
 gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-21.5 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2020 17:26:00 -0000

On Tue, May 19, 2020 at 8:27 AM Simon Marchi <simark@simark.ca> wrote:
> Can you please change `char *name` to be `gdb::optional<std::string>`?
>
> The caller that passes a name should use string_printf to build the string, as mentioned
> above.  The caller that does not pass a name can pass `{}`, to pass an empty optional.

We may want to add C++17's std::nullopt to gdb::optional, to make it
clearer what's going on there. Then you could pass gdb::nullopt
instead of {}.

Christian