From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by sourceware.org (Postfix) with ESMTPS id 441AD385E003 for ; Wed, 25 Mar 2020 22:49:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 441AD385E003 Received: by mail-qt1-x842.google.com with SMTP id a5so3724478qtw.10 for ; Wed, 25 Mar 2020 15:49:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RqV2N+Dfx7t3ABxV9xJ1Iskqke0GF8LGbC5CjWgmD0U=; b=JU4fgOtzMfqR9nVOHtrUy81tg8KkvgD2OArvOzRXPgaeP9OJvsKdZasqWUznPKJlkY JjQmmo/XD8DymlwS8SozZtNj1LQeXly7Fj/f7G+r9AXTguZ5PUpMHHIP34q9o1ji8XUC emw9Ns4ra+2we0WvfI+ueo0xbbrU33aELpRVt4712UFsycEUWH5VbfjFmtUypv75aSKV 1cHhet1CHqMRi+rOtgKLvxzTYPSNoHh56AVA4crI7ECKYGPPBuwUGLlYidA5PpJ4lIah 0gfvVNAO41Y2PGLKlsckn3GL3zmoHJCph9pE9X32VHLVdDhlOMo8WGA17wK182PPZNQ4 p1PA== X-Gm-Message-State: ANhLgQ3P5sViAN70YUCSMonI5p9WoercAnj3bWD+x0I/8VNdLiaWB11F zBvUynsW8av4k9VUyazlSOF0ERdVOBPDbozC3dnQrVaD X-Google-Smtp-Source: ADFU+vu0vl9U1RF8NP+VOR+mUsu9UpSidCjUxfhlW89060HfvM7RjurY1ruCBbh+UAMxbdoeSx7sqjIEVrjf86V34c4= X-Received: by 2002:ac8:2d98:: with SMTP id p24mr5397540qta.349.1585176540592; Wed, 25 Mar 2020 15:49:00 -0700 (PDT) MIME-Version: 1.0 References: <20200325200715.12947-1-tom@tromey.com> In-Reply-To: <20200325200715.12947-1-tom@tromey.com> From: Christian Biesinger Date: Wed, 25 Mar 2020 17:48:24 -0500 Message-ID: Subject: Re: [PATCH 00/10] Fix two name-related bugs in DWARF reader To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-23.1 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2020 22:49:02 -0000 On Wed, Mar 25, 2020 at 3:07 PM Tom Tromey wrote: > > I started this series by trying to fix PR rust/25025. This showed > that the Rust compiler sometimes emits two mangled forms that demangle > to the same thing. > > In the end I could maybe have fixed this in a direct way (see patch #9 > for the details), but while debugging I went on a detour into the > physname code and came up with this series. > > This changes the DWARF reader to avoid demangling when constructing > partial symbols. This obsoletes my previous patch to do the same > thing; I think this approach is cleaner. > > It also attempts to fix the longstanding physname bug, PR 12707. > After this series, the demangled form is now stored on the symbol > again. I haven't read the patches yet but just to clarify, does this mean that a psymbol will now do the expected thing of storing the mangled name as the linkage_name and the demangled name as the demangled_name? Christian