From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35931 invoked by alias); 19 Dec 2019 19:32:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35922 invoked by uid 89); 19 Dec 2019 19:32:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.2 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Languages-Length:755, H*RU:209.85.210.66, HX-Spam-Relays-External:209.85.210.66, HX-HELO:sk:mail-ot X-HELO: mail-ot1-f66.google.com Received: from mail-ot1-f66.google.com (HELO mail-ot1-f66.google.com) (209.85.210.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 19:32:27 +0000 Received: by mail-ot1-f66.google.com with SMTP id c22so8494943otj.13 for ; Thu, 19 Dec 2019 11:32:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ye4BrHpo37xNsUI3CI6yTzko8leu8rs+hIu/RVmo1Bk=; b=SZgJ5/pxG66VE0SgGbFapJgsoU7gmJ/PSTXG304PuJjMvpZ10hBL2HJjqGFI4YRQVh /orV1g75lFVKbP4ZmA3vgllA6FdnWLd2cKvn8fZgavu+ZjBx8tOzobbqy/3fTE7pTX7C C4KwyHKvSdorcha7FpEHHoKhGqYASJvEzWzGEZM2xEUHfyHtU8IuOVMWptr2ZpGP4p5d pMEuoQEf0b422M7Nn5MBavaKDCl3qIEOh3/0TcC3oSUrfCAq1zVd6zyAaBiqGJ/7G4Me Ahs6KOxR2UYRegYe7hCSTkirKA/ToK7tn001yd8v8WF7Fg5hFTLufqSy/VZvrfWKEMJr HrJQ== MIME-Version: 1.0 References: <20191218210608.211751-1-cbiesinger@google.com> <87y2v886g2.fsf@tromey.com> In-Reply-To: <87y2v886g2.fsf@tromey.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Thu, 19 Dec 2019 19:32:00 -0000 Message-ID: Subject: Re: [PATCH] Consistently quote variables used with "test" To: Tom Tromey Cc: Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00836.txt.bz2 On Thu, Dec 19, 2019 at 1:24 PM Tom Tromey wrote: > > >>>>> "Christian" == Christian Biesinger via gdb-patches writes: > > Christian> This ensures that empty variables and variables with spaces are handled > Christian> correctly. > > Christian> Code was inconsistent on whether the constant string (e.g. yes/no) > Christian> should also be quoted; I tried to be consistent with surrounding code. > > Christian> This fixes the error Eli reported during configure with mingw (though that > Christian> was not fatal). > > Thanks. This is ok. Thanks, pushed. To ssh://sourceware.org/git/binutils-gdb.git 1ee7b812e7..0ad6b8ee70 HEAD -> master Christian