From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cbiesinger@google.com>
Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com
 [IPv6:2607:f8b0:4864:20::f43])
 by sourceware.org (Postfix) with ESMTPS id EC4AB385E83A
 for <gdb-patches@sourceware.org>; Tue, 28 Jul 2020 18:56:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EC4AB385E83A
Received: by mail-qv1-xf43.google.com with SMTP id r19so1137407qvw.11
 for <gdb-patches@sourceware.org>; Tue, 28 Jul 2020 11:56:44 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=nN6HSQ0Pmj82UHmLVG7VwzJi5OwKu4n0lMWDxD/jUcs=;
 b=hN81P3VJTppvC2H67P1PYXwMCxMI8E1DX5saD1Ge/GIq3cP9LTZatyUrrXsSLha2Bg
 Ww1FKROE5TWMVnPDai8+T1UkA5pCnnEti6io88nOt91hIfzE1nzDfaCUE6oNuzx0kWiw
 g7lfl7OpHs95jb6eZc7tAQPUs13sR47380ZjekAFYR0T64A59yB9DZ+hnBOGeOOtn033
 10LhWKMX7ntIY9U8ML7Co36JNKFuo2imw6bRsT6x4Qq9lgP8pL08fYoAIwa2uhCvho8S
 cUu0QJu02MR6iutgstsyr784CLLo2eXljEiT/vqM0X1fxLa64eCk7A8C1Cf5ATJtGzD3
 TpXg==
X-Gm-Message-State: AOAM5303g211szUa72jr2n5ApElw83zLfOH4wUP6GWL6Cd/Bf1WqSXz6
 IhXsOuYpUAQ55TmKE2yE6CqV5x4QfkFK2ecYTdm9vA==
X-Google-Smtp-Source: ABdhPJxxG9sjHQbvMBT5KRoVtxABgqR36lQOm+U4qFaNbXD3SnIgVvZ0uWjh8uyXAMt1IxmKNLc+Cxt0O86VijngV2Q=
X-Received: by 2002:a0c:f109:: with SMTP id i9mr27619684qvl.154.1595962604107; 
 Tue, 28 Jul 2020 11:56:44 -0700 (PDT)
MIME-Version: 1.0
References: <20200727144338.7033-1-n54@gmx.com>
 <20200728154602.3824-1-n54@gmx.com>
In-Reply-To: <20200728154602.3824-1-n54@gmx.com>
From: Christian Biesinger <cbiesinger@google.com>
Date: Tue, 28 Jul 2020 13:56:07 -0500
Message-ID: <CAPTJ0XHQ_q6JsLrP8+Xsopv-f2tyRUCqEYDTf6zXzBOu2CjAaA@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] gdb: Implement native dumpcore function
To: Kamil Rytarowski <n54@gmx.com>
Cc: gdb-patches <gdb-patches@sourceware.org>, John Baldwin <jhb@freebsd.org>, 
 Tom Tromey <tom@tromey.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-17.2 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2020 18:56:46 -0000

On Tue, Jul 28, 2020 at 10:47 AM Kamil Rytarowski <n54@gmx.com> wrote:
> +++ b/gdb/target.h
> +/* Does this target support dumpcore API?  */
> +
> +#define target_supports_dumpcore() \
> +  (current_top_target ()->supports_dumpcore) ()
> +
> +/* Generate the core file with target API.  */
> +
> +#define target_dumpcore(x) \
> +  (current_top_target ()->dumpcore (x))

These macros don't seem that useful to me, and they hide a global
variable access... would it be possible to remove them?

Christian