From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41663 invoked by alias); 27 Jan 2020 21:25:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41647 invoked by uid 89); 27 Jan 2020 21:25:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.1 required=5.0 tests=AWL,BAYES_00,DATE_IN_PAST_06_12,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=no version=3.3.1 spammy=H*f:sk:CAPTJ0X, _kmemuser, _KMEMUSER X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Jan 2020 21:25:25 +0000 Received: by mail-wr1-f66.google.com with SMTP id z3so13441088wru.3 for ; Mon, 27 Jan 2020 13:25:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1IaXtM5FwBv8hyxjqhqF0oH2tf39Hp7M6Jb/Nu/yps4=; b=CGHxK07kqbnHTY4tSsalDnO7gtIXUsfBI5T8GkiJwjrz8EXVQcjLk29QQXJNCbFN4l mx5CcmbeaQ0FaUwf9SWS4jF6+Ur4hVxFO3te73k/Jxto1ea5yuJGiUriH+3Fd2Io3jzP FIR2WiMZCcwGyD4XrSC2aUsCLdyW1b/+Bc6UIVrL64dBDyGWpg9vGvAm5G/hUHNrG2Q1 eUUd0RFQ/GCwkA445sS6z7yp7OhNFmp1UUJfhTvYm4RhWsKtEOi98kJMId5Pn3oWMvSA c7915fTRwuBw6MhQIcVJuiPDa50vB9Ejz2RntU8n1f7KQSqPTh0fwB/CWAAE4lFpase3 8nQg== MIME-Version: 1.0 References: <20200124141458.171392-3-cbiesinger@chromium.org> <20200124141818.172490-1-cbiesinger@chromium.org> <2afe5687-5be2-7650-d4e3-3aceed3f68f2@gmx.com> <7432896e-39ec-4a99-cc07-77c684b71644@gmx.com> <8126c811-3416-a4d4-5a01-17776b0df999@gmx.com> <7a00a471-ab23-a235-d9bb-1d5d574bdacd@gmx.com> In-Reply-To: <7a00a471-ab23-a235-d9bb-1d5d574bdacd@gmx.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Mon, 27 Jan 2020 21:28:00 -0000 Message-ID: Subject: Re: [PATCH 2/3 v2] Define _KMEMUSER in arm-nbsd-nat.c To: Kamil Rytarowski Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00888.txt.bz2 On Fri, Jan 24, 2020 at 5:37 PM Kamil Rytarowski wrote: > > On 24.01.2020 17:01, Christian Biesinger wrote: > > On Fri, Jan 24, 2020 at 4:49 PM Kamil Rytarowski wrote: > >> > >> On 24.01.2020 16:35, Christian Biesinger via gdb-patches wrote: > >>> On Fri, Jan 24, 2020 at 4:23 PM Kamil Rytarowski wrote: > >>>> > >>>> On 24.01.2020 15:53, Christian Biesinger via gdb-patches wrote: > >>>>> Hi Kamil, > >>>>> > >>>>> I have a related question. NetBSD applied this patch: > >>>>> https://www.mail-archive.com/tech@openbsd.org/msg44100.html > >>>>> > >>>> > >>>> Is this the right link? > >>> > >>> Yeah -- that patch changes a system header at the top and patches GDB > >>> at the bottom. > >>> > >> > >> This is not a change in NetBSD, so it is unrelated. > > > > My apologies, I completely misread that. I'll see if I can find where > > NetBSD changed their FP register data structure, or perhaps your > > downstream patch will still work (although that probably has to come > > from one of y'all for copyright reasons?) > > > > Please cherry-pick what you need and I will find the original author. > Many people in NetBSD have FSF papers done. Thanks. I think this patch would probably be the most important since it fixes a compile error: https://github.com/NetBSD/pkgsrc-wip/blob/master/gdb-netbsd/patches/patch-gdb_arm-nbsd-nat.c However, I don't understand why arm_netbsd_core_fns / fetch_core_registers was added. As far as I can tell, because that struct uses bfd_target_unknown_flavour and default_core_sniffer, it will never be used. Christian