From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cbiesinger@google.com>
Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com
 [IPv6:2607:f8b0:4864:20::831])
 by sourceware.org (Postfix) with ESMTPS id 89CE13851C16
 for <gdb-patches@sourceware.org>; Thu, 25 Jun 2020 17:32:55 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 89CE13851C16
Received: by mail-qt1-x831.google.com with SMTP id u17so5314379qtq.1
 for <gdb-patches@sourceware.org>; Thu, 25 Jun 2020 10:32:55 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=jgwmakNvsJ7wstoOB4rLtnkwGYBhF6pt/OywaX+9peM=;
 b=Q0Yx2fc1bKQkl9lOUOXROMsowa3tU3f1UNqbbLoWo+ctjoJyspGtODnCb5GWglhQVS
 SwIAenrPBfNXnBOp8EmzyfEQZTjgyyGwlXdTfNj5csl7xFutGtpyEle8N7lqZHPBPM8P
 xN45YLzdPN/b7OotViPEnKbCuQlujDQUvOGb2Ktuwzn+odAbvCuScBOL8CbdVpJxwjHy
 CL2E2Bsg/QC2WYvwNrPmIQjy+uuWpJHEjHnNndl1h05HSefVwdXVvflwTynuNWrPVkWU
 wzwOFwsmalW82RyMccoCsEP+Y7SJmfwLpFqHySqjA0e8YGuEwX74e/vRspjno55k5Vzu
 7Wgw==
X-Gm-Message-State: AOAM532VTVub5mKhFOADMhasXpCzJ3enzWScMBzQccfMa6PxA1OIFYc8
 pbE81zcsBdfu58YQWxvunBw8xjZT0Zox34qgldyOWkcy
X-Google-Smtp-Source: ABdhPJwf1sxJdCGegyPh82faDcVETGUIpM1/nQs4ARkc4l9r+eUK48XHaUVYscqMwQ7bjTHeXinngPiMXsxDswZl2nc=
X-Received: by 2002:ac8:47d0:: with SMTP id d16mr33597278qtr.349.1593106374850; 
 Thu, 25 Jun 2020 10:32:54 -0700 (PDT)
MIME-Version: 1.0
References: <6bc2b01e-3807-77b9-7d1e-d7f6a7875e49@codesourcery.com>
In-Reply-To: <6bc2b01e-3807-77b9-7d1e-d7f6a7875e49@codesourcery.com>
From: Christian Biesinger <cbiesinger@google.com>
Date: Thu, 25 Jun 2020 12:32:17 -0500
Message-ID: <CAPTJ0XHBAXpqj-5e=Z1Xu9qjK09PK6BJvkrF=0O8eCWaVyV-Ng@mail.gmail.com>
Subject: Re: [patch] gdb/testsuite: Fix POSIX-isms in gdb.base/shell.exp
To: Sandra Loosemore <sandra@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-19.1 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jun 2020 17:32:56 -0000

On Wed, Jun 24, 2020 at 8:35 PM Sandra Loosemore
<sandra@codesourcery.com> wrote:
>
> This patch fixes a group of failures in gdb.base/shell.exp on Windows
> host due to assumptions that GDB is launching a POSIX-like shell.  On
> Windows, we get CMD.EXE instead.

Hmm, if I call runtest/make check from an msys2 shell, do I really get
cmd.exe here? I ask because i wonder how many people run this from
cmd.exe as opposed to msys's shell, so it may be better to check for
cmd more specifically somehow (maybe $SHELL?)


Christian