From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78247 invoked by alias); 23 May 2019 21:25:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78234 invoked by uid 89); 23 May 2019 21:25:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-30.7 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=history, super X-HELO: mail-oi1-f196.google.com Received: from mail-oi1-f196.google.com (HELO mail-oi1-f196.google.com) (209.85.167.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 May 2019 21:25:54 +0000 Received: by mail-oi1-f196.google.com with SMTP id w9so5496984oic.9 for ; Thu, 23 May 2019 14:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kHgqYY7gjAKngFDNl9+p+tocbCRYm0kkWxuHEiXgu44=; b=f7xdWgf7u3y7O7BKksesu6id7VoiBsu+5rkqe1NlFVv5nSnnRV+5AzJG7Iu0x0teWV j7XIJSCpW5S0N+jYQbVUwSntKIyBR2jhlsj0rwgjU6ihjrJAepXyOhWZwdwD/FGJdZRL vCSz3XxKO1kxMQj+6VB2+vnfnKtes5zL+mvQvE90uEq2mPFJyul42Od4XoGTJQSMND2R roYQB9i1toH9eOOsKiT3MyauA/gm3P0Aww+mwWIZL1PVXzsKRIBucefURbp2QQo/0e7G avaqPAG3ne9tyY6lpHpqxQca10n0f4C6RQ9IL84rR81WxwnOKwuc0R8KDZffIKZc0uQL JT2A== MIME-Version: 1.0 References: <20190523183935.209380-1-cbiesinger@google.com> <20190523203227.260432-1-cbiesinger@google.com> <3fb153fb-5ef5-d756-11be-caff4d73e517@simark.ca> In-Reply-To: <3fb153fb-5ef5-d756-11be-caff4d73e517@simark.ca> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Thu, 23 May 2019 21:25:00 -0000 Message-ID: Subject: Re: [PATCH] Add an objfile getter to gdb.Type To: Simon Marchi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019-05/txt/msg00554.txt.bz2 On Thu, May 23, 2019 at 4:06 PM Simon Marchi wrote: > Just some formatting nits (don't worry that's common when starting on a project, but you get used to it quickly). No problem! Will send a new version of the patch in a second. > On 2019-05-23 4:32 p.m., Christian Biesinger via gdb-patches wrote: > > diff --git a/gdb/testsuite/gdb.python/py-type.exp b/gdb/testsuite/gdb.python/py-type.exp > > index 734f9b40fd..c299fa3410 100644 > > --- a/gdb/testsuite/gdb.python/py-type.exp > > +++ b/gdb/testsuite/gdb.python/py-type.exp > > @@ -98,6 +98,8 @@ proc test_fields {lang} { > > gdb_py_test_silent_cmd "print (st)" "print value (st)" 1 > > gdb_py_test_silent_cmd "python st = gdb.history (0)" "get value (st) from history" 1 > > gdb_py_test_silent_cmd "python fields = st.type.fields()" "get fields from st.type" 1 > > + gdb_test "python print (st.type.objfile.filename == gdb.current_progspace().filename)" "True" \ > > Space after current_progspace as well. > > > + "Check type.objfile" > > We use lower case letters for test names. This file is super inconsistent about both of those :/