From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90736 invoked by alias); 6 Dec 2019 20:36:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90681 invoked by uid 89); 6 Dec 2019 20:36:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=H*RU:209.85.167.194, HX-Spam-Relays-External:209.85.167.194, HX-Languages-Length:1009 X-HELO: mail-oi1-f194.google.com Received: from mail-oi1-f194.google.com (HELO mail-oi1-f194.google.com) (209.85.167.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Dec 2019 20:36:51 +0000 Received: by mail-oi1-f194.google.com with SMTP id a124so932844oii.13 for ; Fri, 06 Dec 2019 12:36:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ORQa8hW1kj6qnwMbzls7U3iQmtjaZHYejIv6hRbXpb8=; b=C5Bu7GEI8cqqzDmkOzCQOy7p9WrThqRo895J9y5MY6w/+960sBZGPurr81m2lpCT8r ePXnwgVTMpr/4bupNZ1MfiF4SZUcczo7wnCbMhT8OQbfELCTwi9Troer3hBwYcC45njl MCgVC54RwSwXzsAVGeZryb9hMV9mBQ0JJpO9SYtzBftT74KR4ixPcJtPoK9FTiTIExsG IiIIs5yiPwpIs4IvplaBSgXXxjadN5gbC88ggGoMC71W+BfvITUHiIEXzehfZfnoXAVf md1vKl5LHNkE6HDQq7tVuZ8v7D/Wdmu42KMSC71bmp5brd64LLgxpxyyWjwLWVnYM2Uy Pttg== MIME-Version: 1.0 References: <20191126195901.50696-1-cbiesinger@google.com> In-Reply-To: From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Fri, 06 Dec 2019 20:36:00 -0000 Message-ID: Subject: Re: [PATCH] Replace the remaining uses of strerror with safe_strerror To: Pedro Alves Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00247.txt.bz2 On Fri, Dec 6, 2019 at 2:06 PM Pedro Alves wrote: > > On 11/26/19 7:59 PM, Christian Biesinger via gdb-patches wrote: > > > index c37db579f7..724a1d24db 100644 > > --- a/gdb/gdbsupport/safe-strerror.c > > +++ b/gdb/gdbsupport/safe-strerror.c > > @@ -27,11 +27,18 @@ safe_strerror (int errnum) > > { > > static thread_local char buf[1024]; > > > > +#ifdef IN_PROCESS_AGENT > > + /* IPA does not use Gnulib, but only supports Linux, so we can safely > > + call the GNU version of strerror_r here. It is documented not to > > + return NULL. */ > > + return strerror_r (errnum, buf, sizeof (buf)); > > GDBserver and (I assume) the IPA can be built with other C runtimes on Linux, > like musl and others. Do you know how musl behaves? Oof, looks like they return int :( http://git.musl-libc.org/cgit/musl/tree/src/string/strerror_r.c I guess I'll change to #if defined(IN_PROCESS_AGENT) && defined(__GLIBC__)? Christian