Re: [PATCH v5] Improve ptrace-error detection on Linux targets

Sergio Durigan Junior
2019-09-26T17:51:11Z

On Thursday, September 26 2019, Pedro Alves wrote:

> On 9/26/19 6:32 PM, Tom Tromey wrote:
>>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>>
>> Sergio> Changes from v4:
>> Sergio> - Don't add 'dont_throw' optional argument to gdb_dlopen; use
>> Sergio> conventional try..catch.
>>
>> Sergio> - Use snprintf when printing to 'own_buf' and make sure we don't
>> Sergio> overflow the buffer.
>>
>> Thank you for doing this.
>> I think this is ok, please check it in.
>
> Please give me a bit to review before merging. I think I spotted an issue,
> but I haven't had a chance to take a look at it since before Cauldron.

Ops, I just saw this message now, after pushing the patch. Would you
like me to revert it?

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible