Re: [PATCH 1/6] Introduce scoped_pipe.h

Pedro Alves
2020-02-28T20:07:40Z

On 2/28/20 7:47 PM, Sergio Durigan Junior wrote:
> On Friday, February 28 2020, Pedro Alves wrote:
>
>> On 2/26/20 8:05 PM, Sergio Durigan Junior wrote:
>>

>>> --- /dev/null
>>> +++ b/gdb/unittests/scoped_pipe-selftests.c
>>> @@ -0,0 +1,96 @@
>>
>>> +
>>> +#include "defs.h"
>>> +
>>> +#include "gdbsupport/scoped_pipe.h"
>>> +#include "config.h"
>>
>> Was there a reason for this "config.h" include?
>
> I copied this test from the existing scoped_fd-selftests.c and adjusted
> it. I did remove other includes, but left this one untouched. I tried
> removing it now, and the file builds just fine, so I'll update my copy
> of the patch here. Thanks!

Ah, I see. That config.h include shouldn't be there in
scoped_fd-selftests.c either.

Thanks,
Pedro Alves