From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159158-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4589 invoked by alias); 30 Sep 2019 19:33:50 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 4577 invoked by uid 89); 30 Sep 2019 19:33:50 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-18.0 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=
X-HELO: mail-ot1-f68.google.com
Received: from mail-ot1-f68.google.com (HELO mail-ot1-f68.google.com) (209.85.210.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Sep 2019 19:33:49 +0000
Received: by mail-ot1-f68.google.com with SMTP id 67so9407282oto.3        for <gdb-patches@sourceware.org>; Mon, 30 Sep 2019 12:33:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=3Ay5XnopcahyAbMKjmSTMWqiKh5PGTBGIQZLU5HTR24=;        b=DaEQ/ejy83fq15TQwBmgMcIR2K5fm8vI5mS4HabhlrAZyFHMphjpRu0af8ohbsC/jG         MNdRnX4Har7tOWpW69HIWdSWY2ii3NOiK53b4MXGvrU9W7VJgtZ1TzuKP5g1Voq93Kn2         ehDfEf92bTQmJR4LspSHLbtII9gAB92Q95AWVBtDY3yL0Ev65NeTTq3hfQsOUXUZtI1b         i/cnMGT3PkEsEL4w0dmMLLS1dxy4dIiBR9l9KYWlj8mF6iHKJtKQIiEPqq42LMwbeizI         loKU4XBvC+krlU5XHgyw88ZAU6ks573uzqT6xp3Y5fYwUKrApl1NotT5yS64JegUF4QO         pSRw==
MIME-Version: 1.0
References: <20190929053440.144834-1-cbiesinger@google.com> <87zhilamf5.fsf@tromey.com> <3270c053-6981-edc5-e88a-6b836d9f1f24@redhat.com> <87muelah2g.fsf@tromey.com>
In-Reply-To: <87muelah2g.fsf@tromey.com>
From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Reply-To: Christian Biesinger <cbiesinger@google.com>
Date: Mon, 30 Sep 2019 19:33:00 -0000
Message-ID: <CAPTJ0XGfv0mNHxHTRR9bWb4P+H8b4acWk8ma9ppFfyRg8=C3ng@mail.gmail.com>
Subject: Re: [PATCH] Change some arguments to gdb::string_view instead of name+len
To: Tom Tromey <tom@tromey.com>
Cc: Pedro Alves <palves@redhat.com>, 	Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2019-09/txt/msg00625.txt.bz2

On Mon, Sep 30, 2019 at 11:24 AM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> >> Maybe safest is just to transform it to a std::string here?
>
> Pedro> Or
>
> Pedro>   "%.*s", name.size (), name.data ()
>
> Yeah, even better; not sure why I didn't remember this.
>
> Also I think it has to cast to int there.

OK, fixed. Sending a new version of the patch now.

Christian