From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84724 invoked by alias); 8 Nov 2019 17:11:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84713 invoked by uid 89); 8 Nov 2019 17:11:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.7 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy= X-HELO: mail-oi1-f180.google.com Received: from mail-oi1-f180.google.com (HELO mail-oi1-f180.google.com) (209.85.167.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Nov 2019 17:11:09 +0000 Received: by mail-oi1-f180.google.com with SMTP id 22so5868626oip.7 for ; Fri, 08 Nov 2019 09:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u1hIjH19n/NnPGviwfIhXU1oehGV2Kx4qW5A5mqN9Ds=; b=ND4isvRrfNi+llhq7ezIKF5SCLxVvIVtnOO+yg/imkPeNcGowegbY3N8OnOOcCLp98 sJqivRS1/sxBJv2HvHBT/ECMPnGEHTiKmr4J6glMl6cAip60K3+hUECgwTxiDLuZUgHa JamnWQn6PHJ5uHyZA1V2xAKmIM10CVY0c/54JEttflkwYYhuCnUU760lRWixj8/vrK+F XBYAh3nQAC4QdSLDHWlEwVBZWYz+bkarwoGtWVaU4a+7Y2P4XKyi9gh5K7e5mPvuE5rX Yd0JJPLM3NmtnFduTlsj9LuvDgRkZ1RpR9qeyAcFTIkcV2sF19qxd8Gsq5njRLiz7EMF FdGg== MIME-Version: 1.0 References: <20191106203040.5207B25B28@gnutoolchain-gerrit.osci.io> <00713bff-8560-e51f-f193-8845af83251e@redhat.com> In-Reply-To: <00713bff-8560-e51f-f193-8845af83251e@redhat.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Fri, 08 Nov 2019 17:11:00 -0000 Message-ID: Subject: Re: [review v3] Use ctime_r and localtime_r if available To: Pedro Alves Cc: gnutoolchain-gerrit@osci.io, gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00240.txt.bz2 On Fri, Nov 8, 2019 at 8:08 AM Pedro Alves wrote: > And, note that localtime, like other C functions that use global > state, are thread safe on Windows, because the C run time stores > the global buffers in thread local storage. So the gnulib > implementation ends up being thread safe there, even though > it doesn't look like it is. OK, I'll change this to use the time_r module. I'll make it depend on https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/514 since that one also imports a new module. Christian