From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17674 invoked by alias); 16 Jan 2020 02:55:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17665 invoked by uid 89); 16 Jan 2020 02:55:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.5 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_JMF_BL,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=no version=3.3.1 spammy=HX-Languages-Length:2219, H*RU:209.85.167.193, HX-Spam-Relays-External:209.85.167.193, HX-HELO:sk:mail-oi X-HELO: mail-oi1-f193.google.com Received: from mail-oi1-f193.google.com (HELO mail-oi1-f193.google.com) (209.85.167.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2020 02:55:08 +0000 Received: by mail-oi1-f193.google.com with SMTP id i1so17601237oie.8 for ; Wed, 15 Jan 2020 18:55:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zVrBY/dKPtRf7j53I7XkCoz9p+dHq89susjPj7uzRPY=; b=pkV8NiypC5oMrUWirn6M6umnUaWhlWKlIAreJWRoRpE2Dow2J6HjBlPw980qR3b/OM 99N+sFNBBfz0+3G4UCnI/NfvJMTriXuJ3Va+G21v+68TzdlauI19YRdH9HhnGr4hofJN rEOu09K8AptYpbvDmhOXx5i/jnggZWtxo/Ic3uc7FqQlgeHttbGNTeenHxJ9Ui37jz4b lkrbziV9tbKzTWCjhBzMibsItXD4k712segwGW7DG9bzORmb4BMT1BosrxBGaWSZNp8R DIzanuMmF3GbIWwvnK4kICxQPGqm5fzuhkB3RZq40alplaG4T9s15KN+6VNSXP6DfD5S 60/A== MIME-Version: 1.0 References: <20200109005807.7314-1-tom@tromey.com> <8a8de6a9-37b8-cad3-c818-be903037fe48@redhat.com> <437c1b86-0aa8-57b9-53e2-f21567e2bb14@redhat.com> <87c733a2-2b25-a954-88a1-9bfb1a7eca12@redhat.com> <4fed38dc-aaa7-b76b-880f-bab0b1b5add2@redhat.com> <09d7b39d-982d-d68b-a3c7-651616778bd5@redhat.com> In-Reply-To: From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Thu, 16 Jan 2020 02:57:00 -0000 Message-ID: Subject: Re: [PATCH v2 0/6] Move gdbsupport to top level To: Pedro Alves Cc: Tom Tromey , gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00442.txt.bz2 On Wed, Jan 15, 2020 at 5:12 PM Pedro Alves wrote: > > On 1/15/20 9:46 PM, Pedro Alves wrote: > > On 1/15/20 9:35 PM, Pedro Alves wrote: > >> On 1/15/20 8:23 PM, Pedro Alves wrote: > >>> On 1/15/20 2:55 PM, Pedro Alves wrote: > >>>> On 1/15/20 2:41 PM, Pedro Alves wrote: > >>>>> Don't know what I think of gnulib headers including . > >>>>> Maybe we should rename gdb's config.h to gdb-config.h too. > >>>> > >>>> Hit reply to soon. I meant to add, > >>>> > >>>> ... and then, add a manually-written config.h in the build > >>>> dir that does: > >>>> > >>>> #include > >>>> #include > >>>> > >>>> We'd do the same to gdbsupport, add a config.h in its > >>>> build dir that does: > >>>> > >>>> #include "gnulib/config.h" > >>>> #include > >>>> > >>>> Those config.h files would go in the build dirs so that > >>>> they're not picked by other build directories. > >>>> > >>>> With that, any "#include " in any header ends up > >>>> picking the currently-being-built project's config.h, plus > >>>> the dependencies' config.h files. > >>>> > >>>> Just a half-baked thought. Not sure it's the best idea. > >>> > >>> I tried it and it seems to work OK. Fixes the build at least. > >>> Still not sure it's the best idea. WDYT? > >>> > >>> The patch is actually quite small, but since I've rename > >>> config.h -> gdb-config.h etc., and _then_ added new config.h > >>> files, git doesn't notice the renames. > >>> > >>> I wonder whether there's anything could do to stop gnulib and > >>> gdbsupport's configure from defining PACKAGE_NAME etc. in their > >>> generated config.h files. > >>> > >> Here's an improved version, which fixes gdbserver's standalone > >> build, simplifies gdbsupport's config.h (there's no need for > >> #ifdef GDBSERVER stuff since gdbserver doesn't use gdbsupport > >> as a library yet), and adds copyright/intro comments. > >> > > > > I put this in users/palves/config.h if you want to play with it. > > I've also pushed a patch there to fix the missing -std=gnu++11 issue. For that patch, why not just use AM_CFLAGS/AM_CXXFLAGS? Christian