From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6924 invoked by alias); 26 Dec 2019 22:55:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6916 invoked by uid 89); 26 Dec 2019 22:55:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-29.6 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.210.65, H*RU:209.85.210.65, HX-HELO:sk:mail-ot X-HELO: mail-ot1-f65.google.com Received: from mail-ot1-f65.google.com (HELO mail-ot1-f65.google.com) (209.85.210.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Dec 2019 22:55:46 +0000 Received: by mail-ot1-f65.google.com with SMTP id 59so34018886otp.12 for ; Thu, 26 Dec 2019 14:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Myt8KQipbMVeoTgudTw1M8/t5HDy4vPKpHyLo7Akbiw=; b=LhTbxLQcszgNp1bQ1YPGfVicKRerXvWEVPMPXI0vDqJqaH+KNJN8A+hkgNXCZanYfw lr9D0VIAJCLJXbDk3py6A08StRSA/iU/gxSf+KKbMtledL1usQGf+l3YV6pUnYjHVhXH m7NC6m8ZKHazF8v8UWpwJzdqmougptKdQ82Mpa+/3Kk+bB4VmSzZ70csKiqfQnmVpScF m3L7Ae21zJEvjloPBNs4E3kwDK65O7m7W6i0mCSwLFJeoSxXzHzlmSQRvY3QMdBYm6NX FMsh5baxsYuw7XwR0O9lcICA/Dz1FDP+BusDiZDs+TbOhi014VrnzgcLXlG5yoWdGXud m0Tw== MIME-Version: 1.0 References: <20191224122452.1668-1-ssbssa@yahoo.de> <20191224122452.1668-2-ssbssa@yahoo.de> In-Reply-To: <20191224122452.1668-2-ssbssa@yahoo.de> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Thu, 26 Dec 2019 22:55:00 -0000 Message-ID: Subject: Re: [PATCH 2/3] solib_target_free_so memory leak To: Hannes Domani Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg01027.txt.bz2 On Tue, Dec 24, 2019 at 1:25 PM Hannes Domani via gdb-patches wrote: > > gdb/ChangeLog: > > 2019-12-24 Hannes Domani > > * solib-target.c (solib_target_free_so): Free li->offsets. > --- > gdb/solib-target.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gdb/solib-target.c b/gdb/solib-target.c > index 2b473d6066..52e2a6068b 100644 > --- a/gdb/solib-target.c > +++ b/gdb/solib-target.c > @@ -293,6 +293,7 @@ solib_target_free_so (struct so_list *so) > > gdb_assert (li->name.empty ()); > > + xfree (li->offsets); > delete li; Maybe a better fix would be to change offsets to be a unique_xmalloc_ptr? Christian