From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cbiesinger@google.com>
Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com
 [IPv6:2607:f8b0:4864:20::741])
 by sourceware.org (Postfix) with ESMTPS id 666C8385DC35
 for <gdb-patches@sourceware.org>; Thu, 25 Jun 2020 17:19:19 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 666C8385DC35
Received: by mail-qk1-x741.google.com with SMTP id 145so3585158qke.9
 for <gdb-patches@sourceware.org>; Thu, 25 Jun 2020 10:19:19 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=7dZ7eBMiXcsGPoY7Op+JVSoSP8P9/U18i1X9mcgIhKU=;
 b=p3blwg0t2v9bQi495qvgzPTbvRpWLT9pRxRBX8z5zWstZHg1QrUExzU2S8XnlriiaN
 mk+ztZDWmurKqrNytfTrc/LGxePxwlXVEUi/L877ukmCpRIebHF82HB3RwczlLgfKsE0
 iiRAcHplpZuqHcPGIuL7hqoYPb+14LRrSgWTVwGGvsQmIC4xyBLjudkrNAfM5AAh3PLN
 e1QuoSVjIiE7cnmH/P6jiySBuX59dYIPVO2+Zo2ls5Dunl7oYg/shGvtaWhiBRWMVDB/
 jqgnER3Qu0twZbTBinD4RBeVMcVsIqXF2YRtSWloFrru5jEGaoQhxnZjsVyZBf64skDo
 vuSg==
X-Gm-Message-State: AOAM5332QITKe0G5UGcgy5xrKYDyLIwxqq27DMQcC1wjE16CAVrM6DiI
 2wCcqZkal3jsBDTjevVS2m+/313OUN1sdqOHq8sW2GtC
X-Google-Smtp-Source: ABdhPJykX95GWCAuIn74cK2yIaCf/Gx3Hl59XDyu4w0yRKzNhgrVOZ4J3ab87VghjxAuX1Oxt9oOqYsuQ37ql49xiwg=
X-Received: by 2002:a05:620a:1369:: with SMTP id
 d9mr2927730qkl.419.1593105558782; 
 Thu, 25 Jun 2020 10:19:18 -0700 (PDT)
MIME-Version: 1.0
References: <20200625155517.32173-1-simon.marchi@efficios.com>
In-Reply-To: <20200625155517.32173-1-simon.marchi@efficios.com>
From: Christian Biesinger <cbiesinger@google.com>
Date: Thu, 25 Jun 2020 12:18:42 -0500
Message-ID: <CAPTJ0XGVxMrTQ8o-MNPmjJ2sSA4FWGn3sF_zssXofXojiGce5Q@mail.gmail.com>
Subject: Re: [PATCH] gdb: make inferior::terminal a unique ptr
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-17.8 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jun 2020 17:19:20 -0000

On Thu, Jun 25, 2020 at 10:55 AM Simon Marchi via Gdb-patches
<gdb-patches@sourceware.org> wrote:
> -    current_inferior ()->terminal = xstrdup (terminal_name);
> +    current_inferior ()->terminal.reset (xstrdup (terminal_name));

Perhaps it really should be a std::string?

Christian