From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48328 invoked by alias); 21 Aug 2019 18:46:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48316 invoked by uid 89); 21 Aug 2019 18:46:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-30.6 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2353 X-HELO: mail-oi1-f194.google.com Received: from mail-oi1-f194.google.com (HELO mail-oi1-f194.google.com) (209.85.167.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Aug 2019 18:46:35 +0000 Received: by mail-oi1-f194.google.com with SMTP id a127so2416878oii.2 for ; Wed, 21 Aug 2019 11:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UK5GCh7wHm1IjOugw/rKEvnpjk4cVxk5uJg3dJr2lbI=; b=Odm64AR6xOaQTE2SwbyymC7L4Cv1jJIAE6aUQb2W7zM3I+nGf5HDxJSU2DzC6vTNf1 MPFvbt505PR6OICuMbLlCS5HkOJnhHN6pMIHd7sL5fOB1o0MkYYGs9J/NX5y2a717Qkx g4WW1o71s9LUo5hBB0T+0LPT6ztnCnVbgGYhc059FhyiGk5xyqM6MULfO3grQoIM2OXd BmvhdWnPLSsHBgVrdjn0dVf9d4yxMM/+G3X8GRih9frH2DK0C0dKlalE7Jo/Lhfs0mRg IquyecK238X2o3UQQVrNqI0CkPsoj8Ulzvsv33XbckzQfGF/iWUP78KayRD/gW7ulrSD Ka4A== MIME-Version: 1.0 References: <20190820221745.147370-1-cbiesinger@google.com> <20190820221745.147370-4-cbiesinger@google.com> <871rxegzb4.fsf@redhat.com> In-Reply-To: <871rxegzb4.fsf@redhat.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Wed, 21 Aug 2019 18:46:00 -0000 Message-ID: Subject: Re: [PATCH 3/3] Load system gdbinit files from a directory To: Sergio Durigan Junior Cc: Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00508.txt.bz2 On Wed, Aug 21, 2019 at 1:15 PM Sergio Durigan Junior wrote: > > On Tuesday, August 20 2019, Christian Biesinger via gdb-patches wrote: > > > diff --git a/gdb/configure b/gdb/configure > > index cb71bbf057..e5aa2e6b3b 100755 > > --- a/gdb/configure > > +++ b/gdb/configure > > @@ -693,6 +693,7 @@ WIN32LIBS > > SER_HARDWIRE > > WERROR_CFLAGS > > WARN_CFLAGS > > +SYSTEM_GDBINIT_DIR > > SYSTEM_GDBINIT > > TARGET_SYSTEM_ROOT > > CONFIG_LDFLAGS > > @@ -824,6 +825,7 @@ infodir > > docdir > > oldincludedir > > includedir > > +runstatedir > > localstatedir > > sharedstatedir > > sysconfdir > > @@ -884,6 +886,7 @@ with_libipt_prefix > > with_included_regex > > with_sysroot > > with_system_gdbinit > > +with_system_gdbinit_dir > > enable_werror > > enable_build_warnings > > enable_gdb_build_warnings > > @@ -956,6 +959,7 @@ datadir='${datarootdir}' > > sysconfdir='${prefix}/etc' > > sharedstatedir='${prefix}/com' > > localstatedir='${prefix}/var' > > +runstatedir='${localstatedir}/run' > > includedir='${prefix}/include' > > oldincludedir='/usr/include' > > docdir='${datarootdir}/doc/${PACKAGE}' > > @@ -1208,6 +1212,15 @@ do > > | -silent | --silent | --silen | --sile | --sil) > > silent=yes ;; > > > > + -runstatedir | --runstatedir | --runstatedi | --runstated \ > > + | --runstate | --runstat | --runsta | --runst | --runs \ > > + | --run | --ru | --r) > > + ac_prev=runstatedir ;; > > + -runstatedir=* | --runstatedir=* | --runstatedi=* | --runstated=* \ > > + | --runstate=* | --runstat=* | --runsta=* | --runst=* | --runs=* \ > > + | --run=* | --ru=* | --r=*) > > + runstatedir=$ac_optarg ;; > > + > > Something else I forgot to comment: this 'runstatedir' addition seems > unrelated to the patch; it's probably due to the autoconf version you're > using to regenerate these files. > > Make sure you have the correct versions installed: > > https://sourceware.org/gdb/wiki/DeveloperTips#Editing_configure.ac Turns out the debian version of autoconf has a local patch to do this runstate thing :( https://sources.debian.org/src/autoconf/2.69-11/debian/patches/add-runstatedir.patch/ Anyway, I'll hold off on updating this patch pending the discussion about the approach in the other thread. (But patches 1 and 2 may still be good to get committed) Christian