From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 859 invoked by alias); 10 Feb 2020 16:42:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 824 invoked by uid 89); 10 Feb 2020 16:42:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-29.2 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=dong, blame, Helps, HX-Spam-Relays-External:209.85.210.67 X-HELO: mail-ot1-f67.google.com Received: from mail-ot1-f67.google.com (HELO mail-ot1-f67.google.com) (209.85.210.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Feb 2020 16:42:57 +0000 Received: by mail-ot1-f67.google.com with SMTP id d3so6990463otp.4 for ; Mon, 10 Feb 2020 08:42:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iyAa06TA6IyKIB5HyZAJYVykMKZDrQr3ld0wwpBe51w=; b=WLKKj4g7D1qM+oG05lHvwoDEzd5aR7vUO6yeu+KuG/Sqwfad+944u49rlXOY68/daa CTLkJsWA8tqaev12crNegEIjOrB9eTKub8BDbvV4pZA8ZWxMgKP4Z+HA7kFcRh+ayTQF ftuodll7XJXLCtufmyGhHAwl1wnQyYV6xRNtLuEtcpivHbBiy5A8zPJrHjx0v445+tlM fTrYZL+znUpjmdu43vomRoYpL8tNno9DTRaxXNBxOkfKZZiZ7gnKrS2EKc2I9b6gvdE+ LeWL0HSQSOTy0aa9DkhLSPS7Cqmgq23R4rjtfrMBTlBq+rSGbYhFYxmCAoYkaeMHWB4S Eqvw== MIME-Version: 1.0 References: <20200210164024.32445-1-simon.marchi@efficios.com> <20200210164024.32445-3-simon.marchi@efficios.com> In-Reply-To: <20200210164024.32445-3-simon.marchi@efficios.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Mon, 10 Feb 2020 16:42:00 -0000 Message-ID: Subject: Re: [PATCH 3/3] Add -Wstrict-null-sentinel to gdbsupport/warning.m4 To: Simon Marchi Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00289.txt.bz2 On Mon, Feb 10, 2020 at 10:40 AM Simon Marchi wrote: > > Commit 85f0dd3ce ("[gdb] Fix -Wstrict-null-sentinel warnings") fixed > some violations of -Wstrict-null-sentinel. If we want to enforce this > warning, I think we should enable it in our warning.m4 file. > > gdbsupport/ChangeLog: > > * warning.m4: Add -Wstrict-null-sentinel. > * configure: Re-generate. > > gdbserver/ChangeLog: > > * configure: Re-generate. > > gdb/ChangeLog: > > * configure: Re-generate. > --- > gdb/configure | 3 ++- > gdbserver/configure | 3 ++- > gdbsupport/configure | 3 ++- > gdbsupport/warning.m4 | 3 ++- > 4 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/gdb/configure b/gdb/configure > index a1d150649729..2ce910c808ce 100755 > --- a/gdb/configure > +++ b/gdb/configure > @@ -16111,7 +16111,8 @@ build_warnings="-Wall -Wpointer-arith \ > -Wdeprecated-copy \ > -Wdeprecated-copy-dtor \ > -Wredundant-move \ > --Wmissing-declarations" > +-Wmissing-declarations \ > +-Wstrict-null-sentinel" > > case "${host}" in > *-*-mingw32*) > diff --git a/gdbserver/configure b/gdbserver/configure > index 4b9d7e3718fa..bd0e667af69b 100755 > --- a/gdbserver/configure > +++ b/gdbserver/configure > @@ -9815,7 +9815,8 @@ build_warnings="-Wall -Wpointer-arith \ > -Wdeprecated-copy \ > -Wdeprecated-copy-dtor \ > -Wredundant-move \ > --Wmissing-declarations" > +-Wmissing-declarations \ > +-Wstrict-null-sentinel" > > case "${host}" in > *-*-mingw32*) > diff --git a/gdbsupport/configure b/gdbsupport/configure > index 197749b5d0ca..1f7d72cc5852 100755 > --- a/gdbsupport/configure > +++ b/gdbsupport/configure > @@ -10853,7 +10853,8 @@ build_warnings="-Wall -Wpointer-arith \ > -Wdeprecated-copy \ > -Wdeprecated-copy-dtor \ > -Wredundant-move \ > --Wmissing-declarations" > +-Wmissing-declarations \ > +-Wstrict-null-sentinel" > > case "${host}" in > *-*-mingw32*) > diff --git a/gdbsupport/warning.m4 b/gdbsupport/warning.m4 > index e2b8a43ddbd5..75bc21ca4261 100644 > --- a/gdbsupport/warning.m4 > +++ b/gdbsupport/warning.m4 > @@ -50,7 +50,8 @@ build_warnings="-Wall -Wpointer-arith \ > -Wdeprecated-copy \ > -Wdeprecated-copy-dtor \ > -Wredundant-move \ > --Wmissing-declarations" > +-Wmissing-declarations \ > +-Wstrict-null-sentinel" Any thoughts on instead dong: +-Wstrict-null-sentinel \ +" so that future changes don't need to change the last line? Helps with blame too. > > case "${host}" in > *-*-mingw32*) > -- > 2.25.0 >