From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5725 invoked by alias); 28 Feb 2020 13:22:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5717 invoked by uid 89); 28 Feb 2020 13:22:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.9 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=H*f:sk:75f7610, H*i:sk:75f7610, HX-Spam-Relays-External:209.85.210.68, H*RU:209.85.210.68 X-HELO: mail-ot1-f68.google.com Received: from mail-ot1-f68.google.com (HELO mail-ot1-f68.google.com) (209.85.210.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2020 13:22:54 +0000 Received: by mail-ot1-f68.google.com with SMTP id z9so2536822oth.5 for ; Fri, 28 Feb 2020 05:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wNE7fFYdEMttZbGv40gP8etCnYFY0geVUpz+NjMKfJQ=; b=opsyni8NP5l5OWVZ+gTOxREXLPMHpuYZCgFdiZfuxPN8/ZI5ajeoWRwkAPmQiTCOGt TovuH+oC5XvmDBPBEBb/0c0UplgixL6aADI+NbKOH/T4loLxMTgyzz/J1Ic7pxxx143e VMjtUzmycBAOqxDO+UNMYZA2clcHHDMp19MlqPQ/+3uXdglgVB9rVcnBuy/Fl61Sq65h iYCYs9aCbSSIbxfjnjQ25V1uEhaTA1DLh6lkj3wzjb6YvLzu6Bfk8iaDGJHOOWqaGihY AJaLTENeB9v0I2g1AxH1lDleCIA7CjTWYitRhc4STSSBLh9HJrmWti9WA7cO8Dah+o9H IdiQ== MIME-Version: 1.0 References: <20200120155315.30333-1-shahab.vahedi@gmail.com> <75f76108-a233-6fce-66a2-86452371e1be@linaro.org> In-Reply-To: <75f76108-a233-6fce-66a2-86452371e1be@linaro.org> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Fri, 28 Feb 2020 13:22:00 -0000 Message-ID: Subject: Re: [Regression] [PATCH] Do not print empty-group regs when printing general ones To: Luis Machado Cc: Shahab Vahedi , Shahab Vahedi , "gdb-patches@sourceware.org" , Claudiu Zissulescu , Francois Bedard , Andrew Burgess Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg01040.txt.bz2 On Fri, Feb 28, 2020 at 7:08 AM Luis Machado wrote: > > On 1/31/20 7:34 AM, Shahab Vahedi wrote: > > This patch was reviewed once (as OK): > > https://sourceware.org/ml/gdb-patches/2020-01/msg00613.html > > > > Could someone review/merge it? > > > > > > Cheers, > > Shahab > > > > FTR, this has broken general register printing for ARM/AArch64. Now > "info reg" shows nothing. > > Given there are already remote stubs, probes and gdbservers running out > there, this is an undesirable change to have. > > I had an IRC chat with Christian and he pointed me at some documentation > stating empty-group registers should not be printed, but i think this is > a case where the implementation has diverged from the documentation. > > https://sourceware.org/gdb/current/onlinedocs/gdb/Target-Description-Format.html#Target-Description-Format > > We could probably patch up any non-standard target description XML's > from now on, but the existing behavior may have to be preserved. Most targets under features/ do not specify group="general" in their XML files for anything (only S/390 does); it seems like that should maybe be fixed either way? Christian