From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23853 invoked by alias); 11 Sep 2019 17:47:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23843 invoked by uid 89); 11 Sep 2019 17:47:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.4 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Received:sk:i20mr30, HX-Received:6830 X-HELO: mail-ot1-f66.google.com Received: from mail-ot1-f66.google.com (HELO mail-ot1-f66.google.com) (209.85.210.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Sep 2019 17:47:41 +0000 Received: by mail-ot1-f66.google.com with SMTP id n7so23395454otk.6 for ; Wed, 11 Sep 2019 10:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=azLZytkxucbdL5zf6by2PbbY8WrFhxggeHokHzHQpnw=; b=EZoyaZukRtN2ZvqHjpSn8lj3ETan/YE6sZvIQ4tFXKWSfHXZ7c+R7fQ5F3TrKCdWbH L3yzUmY+lKgfld8CVaMZyiEBfN357A+pzqHlusVRJE4HcKlVj70RMDQiGkHIXC33x1LQ Ee3GmkTFfC2tnwVywbyx4nx3U9vkXv8B40cg8EFR9m9nsWIZMjDDLopdazd4kDqvJl0i uOScJ6sjDKRACbS/o86nOnSZge9lHIe0pGjol8re7KAe+n3JijoOiQw/sJNLE4kjudGv zVcIMQQxgzZLuh3puVDk0Jx6svf7jw3pgcAw0hS7/iL2UtTHzDW5mL0nd1mCVQxEtArX oE8g== MIME-Version: 1.0 References: <20190910204252.218634-1-cbiesinger@google.com> <87o8zq4to0.fsf@tromey.com> In-Reply-To: <87o8zq4to0.fsf@tromey.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Wed, 11 Sep 2019 17:47:00 -0000 Message-ID: Subject: Re: [PATCH] Change the type of copy_names from int to bool To: Tom Tromey Cc: Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00204.txt.bz2 On Wed, Sep 11, 2019 at 12:41 PM Tom Tromey wrote: > > >>>>> "Christian" == Christian Biesinger via gdb-patches writes: > > Christian> [Does this count as obvious?] > > Normally I'd reserve obvious for build breakage or comment fixes or the > like; but I think there's a consensus for bool-ifying, and so this would > be unobjectionable to me at least. > > Christian> 2019-09-10 Christian Biesinger > > Christian> * dbxread.c (read_dbx_symtab): Update. > Christian> * dwarf2read.c (load_partial_dies): Update. > Christian> * mdebugread.c (parse_partial_symbols): Update. > Christian> (handle_psymbol_enumerators): Update. > Christian> * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool. > Christian> * psymtab.c (add_psymbol_to_bcache): Likewise. > Christian> (add_psymbol_to_list): Likewise. > Christian> * symtab.c (symbol_set_names): Likewise. > Christian> * symtab.h (symbol_set_names): Likewise. > Christian> * xcoffread.c (scan_xcoff_symtab): Update. > > Ok. Thank you. Thanks, pushed as 67547d896b Christian