From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7258 invoked by alias); 19 Dec 2019 19:13:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7244 invoked by uid 89); 19 Dec 2019 19:13:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.2 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Received:6f07, H*RU:209.85.210.65, HX-Spam-Relays-External:209.85.210.65, HX-HELO:sk:mail-ot X-HELO: mail-ot1-f65.google.com Received: from mail-ot1-f65.google.com (HELO mail-ot1-f65.google.com) (209.85.210.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 19:13:40 +0000 Received: by mail-ot1-f65.google.com with SMTP id w1so8476773otg.3 for ; Thu, 19 Dec 2019 11:13:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=izHPF1ssXh1VzVyehaLgA5vIyeYkVVLGod5MJ3hOnk8=; b=CdyeIo6oRu/HXxw9yYhpO6XAKjVvkyAFXgAnOCgKly7pGVjzZHHHLP2kODQBpE3VUR CVlAzvUuoA+yjDNecOUQOEN2kqwAGM9tivQy+SGvSGAu11s6yCWLgnjtc2bl7brxtXt8 wcoAw4IGsGHwRYUIIPi+N3FZUdKDQO+eqesz1KTSkp4QmdBPf/MofEult7O/qidkBJEz kNIQicVH5T81F2+j5kMloRFS7kQmWgif8vJbhPtr2N3gAhv/tt4es8BxepTU7vjBKL0t 9p2CZ60uQYZHVtPwFDyfYLHMrrYixfBTn9ppkXMNQrVE7WqwW2W1YvTwfGpUBqbnC9TS yg1A== MIME-Version: 1.0 References: <20191219000103.36667-1-cbiesinger@google.com> <20191219000103.36667-5-cbiesinger@google.com> <87fthgb2kv.fsf@tromey.com> In-Reply-To: <87fthgb2kv.fsf@tromey.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Thu, 19 Dec 2019 19:13:00 -0000 Message-ID: Subject: Re: [PATCH 3/3] Make the literal argument to pow a double, not an integer To: Tom Tromey Cc: Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00832.txt.bz2 On Thu, Dec 19, 2019 at 12:19 PM Tom Tromey wrote: > > >>>>> "Christian" == Christian Biesinger via gdb-patches writes: > > Christian> 2019-12-18 Christian Biesinger > > Christian> * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of > Christian> 2 to pow (). > > It probably makes sense to add a comment about Solaris here as well. > It's a bit borderline for me, considering it is a constant, but on the > other hand, a comment is definitely safe. So, ok with that change. OK, added this comment: + /* Solaris 11+gcc 5.5 has ambiguous overloads of pow, so we + pass 2.0 instead of 2 to get the right one. */ Christian