From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id o0T7ACy5/V+cRAAAWB0awg (envelope-from ) for ; Tue, 12 Jan 2021 09:58:52 -0500 Received: by simark.ca (Postfix, from userid 112) id E82721EF7E; Tue, 12 Jan 2021 09:58:51 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 987981E940 for ; Tue, 12 Jan 2021 09:58:50 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E4E05386F432; Tue, 12 Jan 2021 14:58:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4E05386F432 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610463529; bh=DlM6StJOmr42FvH83+qn8f8XVIDmdu1+RjJ8VLEwDKA=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VYJQplVFu3hwRPnFequnD13yKiVWlK0ZqYYxe1BbitdgZ3I+UXbm4nQOpnsFP+7xR Pvm1Ml2maDgsIUP4uwnrmhMMNKC1hOj0WMFdBI7iW/2lH8isoXd96ZDpekWaJzV/HO TS9juQDqLinEWC+bTDPa+QkhnKEGf4JG6P5VA5GQ= Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by sourceware.org (Postfix) with ESMTPS id DE10A386F434 for ; Tue, 12 Jan 2021 14:58:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DE10A386F434 Received: by mail-qt1-x836.google.com with SMTP id h19so1648170qtq.13 for ; Tue, 12 Jan 2021 06:58:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DlM6StJOmr42FvH83+qn8f8XVIDmdu1+RjJ8VLEwDKA=; b=kfIxjm1IIXjhiLZgzP0JqxEEktaCHH+rnYeYUGYw7GC1ceJCzshEST0ZtrUdNx9dyu 8i4ySIbXJ1rAy9aomxsHWwYb7uWcLZEhKtcbyV/h1dHr5dxZA7NTjqROmuqQzBpeXmm7 TgGZBofXoFtPfZU1lQjRhtV4y7Qb5CweTiojhTI2VY1Ne+UfsNvXmMpCyzvyYmiaBLIN IXUnWY43uty/ntS4jNcEGMero3/Jypgq4sXADdT/4C2VE10EIo6hUpZ7iD25UD2wM2oK ysSCTjy39Nu6wsJr1Qm/Us4yHudX5B3E+M7U5FZRI4Ju9ikFkxfFbSP2fJbunOo8Qm3N 9xeg== X-Gm-Message-State: AOAM53142seA6/NPoiBDeAAw1RFPYnUeBTYICpbeOXwqTRAiSU5EWEu4 59uYqhk6FYImmdJuS2NGT5AcGPHXSN3aPsT5dxYWvA== X-Google-Smtp-Source: ABdhPJwJmZrWd6Sfs7dPzVPv4wRPSPbUzX+v2wRkzBJmSERMKf8IbdYOQIpfszVtZzrhkPts5kwmcuHZiO/JUjDho90= X-Received: by 2002:ac8:4910:: with SMTP id e16mr5017638qtq.244.1610463526302; Tue, 12 Jan 2021 06:58:46 -0800 (PST) MIME-Version: 1.0 References: <20210112054441.1188693-1-simon.marchi@polymtl.ca> <20210112054441.1188693-2-simon.marchi@polymtl.ca> In-Reply-To: <20210112054441.1188693-2-simon.marchi@polymtl.ca> Date: Tue, 12 Jan 2021 15:58:08 +0100 Message-ID: Subject: Re: [PATCH 2/2] gdb: move read{now, never}_symbol_files declarations to symfile.h To: Simon Marchi Content-Type: text/plain; charset="UTF-8" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Christian Biesinger via Gdb-patches Reply-To: Christian Biesinger Cc: gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Tue, Jan 12, 2021 at 6:44 AM Simon Marchi via Gdb-patches wrote: > -int readnow_symbol_files; /* Read full symbols immediately. */ > -int readnever_symbol_files; /* Never read full symbols. */ Looks like these comments didn't make it into the header file? (It also seems like these should be bool, though I understand that's a bigger change) Christian